From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50511: 27.2; url-http-handle-authentication should not raise error Date: Sat, 11 Sep 2021 15:05:19 +0200 Message-ID: <87k0jnl0ts.fsf@gnus.org> References: <87y284l85d.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6457"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50511@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 11 15:06:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mP2i8-0001Tq-Dv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Sep 2021 15:06:24 +0200 Original-Received: from localhost ([::1]:39782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mP2i7-0001yf-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Sep 2021 09:06:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mP2hm-0001wf-P5 for bug-gnu-emacs@gnu.org; Sat, 11 Sep 2021 09:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mP2hm-0005YV-Hm for bug-gnu-emacs@gnu.org; Sat, 11 Sep 2021 09:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mP2hm-00038e-D6 for bug-gnu-emacs@gnu.org; Sat, 11 Sep 2021 09:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Sep 2021 13:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50511 X-GNU-PR-Package: emacs Original-Received: via spool by 50511-submit@debbugs.gnu.org id=B50511.163136553012021 (code B ref 50511); Sat, 11 Sep 2021 13:06:02 +0000 Original-Received: (at 50511) by debbugs.gnu.org; 11 Sep 2021 13:05:30 +0000 Original-Received: from localhost ([127.0.0.1]:39763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mP2hG-00037p-36 for submit@debbugs.gnu.org; Sat, 11 Sep 2021 09:05:30 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mP2hE-00037b-Db for 50511@debbugs.gnu.org; Sat, 11 Sep 2021 09:05:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Cc3UvXXD2Q895VQTV/4uzu9kp/M5gCvUyLEvPpFjQ/0=; b=fxxLrhViH+nOeedV/Z5mf89nzU kWem3grc/HM1C/QCQtM910hwlMTcs3P0H4lnappfr4KLhTEipdKSuoZgzcugjG0JNOD+qeVkKaUEi v2sFr67rQsCoPuRBLXzaDTY+Iil2wuxExQm1tpWZRZdk/GHZ/KoenwLqzoI7Pgi8lUXM=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mP2h5-0000LK-U8; Sat, 11 Sep 2021 15:05:22 +0200 In-Reply-To: <87y284l85d.fsf@bernoul.li> (Jonas Bernoulli's message of "Fri, 10 Sep 2021 18:14:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214074 Archived-At: Jonas Bernoulli writes: > Since [1: 64b469f6ae] url-http-handle-authentication raises an error > when it detects that we already tried to make an authenticated request. > > 1: 2019-07-26 64b469f6ae8173116ec948ac43cd44efe4b5a221 > Don't infloop in url.el when sending invalid basic auth > > Instead of signaling an error using `error', it should simply return t > to indicate that no further requests should be made and the response > data (in this case error data) should be passed to the handler, i.e. to > indicate that the request "successfully failed". Then the error handler > can inspect the response and decide how to react. > > This is how it is done for all other https response codes, including all > other error codes. This approach also solves the infloop issue but also > makes it possible to use an error handler as intended. Makes sense. Can you propose a patch for this (since you can reproduce the problem and verify that the patch fixes it)? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no