From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck on something nonsensical Date: Tue, 09 Nov 2021 14:39:32 +0800 Message-ID: <87k0hhal3v.fsf@yahoo.com> References: <87k0hhal3v.fsf.ref@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4932"; mail-complaints-to="usenet@ciao.gmane.io" To: 51702@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 09 07:57:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkL4a-00015P-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 07:57:36 +0100 Original-Received: from localhost ([::1]:60766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkL4Y-00026f-ES for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 01:57:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkKna-0007V8-3g for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 01:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48929) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkKnZ-0002uC-MU for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 01:40:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkKnZ-0000dr-KI for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 01:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Nov 2021 06:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16364399952449 (code B ref -1); Tue, 09 Nov 2021 06:40:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Nov 2021 06:39:55 +0000 Original-Received: from localhost ([127.0.0.1]:60475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkKnT-0000dR-8e for submit@debbugs.gnu.org; Tue, 09 Nov 2021 01:39:55 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:33302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkKnO-0000dH-HG for submit@debbugs.gnu.org; Tue, 09 Nov 2021 01:39:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkKnN-0007He-8b for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 01:39:49 -0500 Original-Received: from sonic314-22.consmr.mail.ne1.yahoo.com ([66.163.189.148]:42542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkKnJ-0002rY-2N for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 01:39:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636439983; bh=Rz6PKWWKBpX/jQnVAmlqh16ON0PhVxEgOHmDzscM5Fg=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=WwDKvKCUo0McFG/uSgnFJtp7hCzIUsgwHWDABU3vRS2z6nLA5F/NkR4yKzIFN0N8HmaUqs2KnvJLcSNrU9bpJTNf/vlvc/0blKZV2Tp53/grFZ0de/oVaQP9Ok6vahudCfx2sWgLO3OhLkBYpeP6r6htGQ9/tq9iptyoRt/0lYmvWaDCsoqAJfedCal1s6cnFnJWc8lqgGO5UZzsVmeOumSr92qwX3TiKH9vXoz3dtHGmBI3VRLY2vFR06giILTu+Ux8G/rFQwUenWXlyeGRIcUQPdzXJlAZipR7RsABhG0xvt4HXrufPfoo+uTKs8xppHCkwFq/ASU22yBo0O550g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636439983; bh=h8YoaDVkkzdleD9Zi4ABfZGSN+u2CDSsABQlQ/kIu9K=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=UqIIuQoMCzgth0ZTROiNc47jXz0x81gIAprIoXyEdlgIoN4y3actfFAyXuQde3l2Rmm8pbXRcFZK7GjSWAPxdurmt+IsnT8Mzss5I6wGT0F3bnw2eoQl9rnp+VXBBfJkpbrOZ/aVbcSlN+s6OTYnMxen8MEUXB3gub6g/dWZgZrW2NinGl2xDMYVZqwLO8M5iyWRBZrkEsB8klVJdElIAYdxDoM2md26LKvD722RM8HTwbUHt9cz+5vAODOqzSl2lc0C0XE6Q7HhVinNN9eGPmSZ2pBhGuPsAVxHDAwM79stH7WZu00zepiFCRONfVZdJxapPBPBpJm2LBVqe6aTCw== X-YMail-OSG: gSyQZKoVM1muLhOE83urE82vOjDzVZnNVFR_hH0C4RSl0XnzqMU.wcHmkKPdFg9 Ckcc7yDZgkCBc3chdBY0bsCFU8BnX0pSrsD499icrg3sWzxE3_QFOdWRFi241eY5KyioqEnNJo97 qOfSJhqJS_dlUU45C804DJC23Zz2q5FMKrgmTcnAAGTMCyS9glahnl7ucddtmoNNhPhQJoI2X_Ts 9IDMBmYbGKyaQNt9djGOLNhE_X8efykARtI7eWDMNOiscMS6HE3LWrThoTOqlsLs..til_SvCypm yOUe2Zte6pPsem34wtYaiQdUHj5mrzPdirN7LQW3gtkAOuTfLcA9CMWE4VemzYLSjA3Ld2RA1Xj1 fgS8WkiS3e9QyY5b18msb_dvS8xDNtbBKloTRnUeGt2x9.JD0aJm2H4x7nMdExQYJfed2lYfhGXb wqlWFvFZM2NYKne.PddiZqsAbukacfewH6IC1wmZSEcYw7aXLL_e7jFUhYHhlST9V.hPJ_5y5zAr lzU9zEUfAKhtsCsVe_B2Db3NuMXPnzBgpdwNKzSJO4YtLvvxSGeQ_QrLDfrLhdNlBNFpKZEtr65G ZpZunNNUEmzeZIT.1qtG3bl9Blj_EhAry6ogj.c12vAyKdiOjXvKHUEUYsDAJHwKAkM1aEd_Jp9k D71SGZqkLBkgspafU7oML3nojmPqA7facnmXkfjrxOQ58fuMA5Dl96S.gwTt0wehTcAxLUz7WLmU bP22TZZHov50a6gmxyA9VXDxwcor9XgRpjRyeaIbqGktqusZBZPEMp.B0YdmZ.yuVRns2ML3tC1Z mDKr5fAa4PZfCevN3FKo03X7Uhqw9M3WRYdnTkGLtP X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Tue, 9 Nov 2021 06:39:43 +0000 Original-Received: by kubenode511.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID ffe10f186d163a23ed5c05f9743d52f5; Tue, 09 Nov 2021 06:39:36 +0000 (UTC) X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.148; envelope-from=luangruo@yahoo.com; helo=sonic314-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219407 Archived-At: --=-=-= Content-Type: text/plain Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Always-set-xwidget-title-if-the-event-was-load-finis.patch >From a943d9b995d701d4ae7029f6f6f3ae91ceb3a29b Mon Sep 17 00:00:00 2001 From: Po Lu Date: Tue, 9 Nov 2021 14:37:47 +0800 Subject: [PATCH] Always set xwidget title if the event was "load-finished" * lisp/xwidget.el (xwidget-webkit-callback): Always set title upon load completion. This prevents loading pages such as "about:blank" from not setting the buffer name. --- lisp/xwidget.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index fc37798322..905327083b 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -360,9 +360,11 @@ xwidget-webkit-callback (cond ((eq xwidget-event-type 'load-changed) (let ((title (xwidget-webkit-title xwidget))) ;; This funciton will be called multi times, so only - ;; change buffer name when get a valid title. this can - ;; limit buffer-name flicker in mode-line. - (when (> (length title) 0) + ;; change buffer name when the load actually completes + ;; this can limit buffer-name flicker in mode-line. + (when (or (string-equal (nth 3 last-input-event) + "load-finished") + (> (length title) 0)) (with-current-buffer (xwidget-buffer xwidget) (setq xwidget-webkit--title title) (force-mode-line-update) -- 2.31.1 --=-=-=--