From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers Date: Sun, 21 Nov 2021 18:02:32 +0100 Message-ID: <87k0h1mogn.fsf@gnus.org> References: <87bl44qz5o.fsf@gmail.com> <87wnmgk6r7.fsf@gmail.com> <87tugrmi1j.fsf@gnus.org> <86pmqxuymw.fsf@mail.linkov.net> <87ee7cwqwj.fsf@gnus.org> <86r1bcpo5i.fsf@mail.linkov.net> <87zgpzrznf.fsf@gnus.org> <86y25imyna.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4733"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Matthias Meulien , 51016@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 21 18:03:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moqFG-000170-1D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 18:03:14 +0100 Original-Received: from localhost ([::1]:55112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moqFE-0003vt-Po for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 12:03:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moqF5-0003qj-6C for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 12:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moqF4-0007Aa-Sy for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 12:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moqF4-0000pa-HC for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 12:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Nov 2021 17:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51016 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51016-submit@debbugs.gnu.org id=B51016.16375141683174 (code B ref 51016); Sun, 21 Nov 2021 17:03:02 +0000 Original-Received: (at 51016) by debbugs.gnu.org; 21 Nov 2021 17:02:48 +0000 Original-Received: from localhost ([127.0.0.1]:45871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moqEq-0000p6-Ea for submit@debbugs.gnu.org; Sun, 21 Nov 2021 12:02:48 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:55406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moqEp-0000oq-41 for 51016@debbugs.gnu.org; Sun, 21 Nov 2021 12:02:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Omtny25r2T32R8iiLEIVz6nh3Dxh/CcobTnnnAn/3E0=; b=LPIimOQ0oqYX1c0skMILdyQHCT t0Raq6h5V6LbjP9BoLxN0BU0/ADoBCgPTNF5GSzrIhMGcuv/wnkXQMKOyVCwJEEW2xzIdYa9MEwlZ 4EfFllfcmHNhlLchj1kicJfmL+sRIQC4mFpnCdkpg5GjiNSTGCvJBzHVse4XwOfPf3yw=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moqEf-0007TQ-AB; Sun, 21 Nov 2021 18:02:40 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEX8/Prj4NvV0c3E wLuwraeTkYxgXVqDgXxCPjyBfnkuKikiHh3////XNZo/AAAAAWJLR0QMgbNRYwAAAAd0SU1FB+UL FRA6AdTC+7IAAAGmSURBVDjL1ZNBcuIwEEVRToCUHAAs5gBh5AvY8glQOyHrqBHeQ03NHpXL++EG SanEDfDlRjIBbMIBZr6Xr1rf+v01Gv0bIoTS0Th8t6JJkgT0TQ9CyvwOoT8LAJAJvTmKCMCgTZYM AeEpokFcb/LpADCJpm6a2q7VvD9CZmB8lEOd9UfYj7LyJ6LVABSm8W3bel8jzHvg6SWcFMDRO6uz cc+iNP7QxpEA8h4Q2yoOxLMsLq4mTGA34TuTnjtLsWlP8taqszshSbG1TV175537DL/FTi58JgB2 5WvpNO5WHwC5OIEkERI+8a1yiBo/3kF+gWcuCrD4+5fTe73RIM9g+sQLtOa18jsbAn4BySeXRLA5 nP8K4XpDGkCM5HgMF1yrSyaEpmXdRRLBSmWXvXdZ+fYYQ0St5pPLzTmYaHLogLzukPLOJMrin/7W aYp18wVU3qsW5UsMO/SuRr3oF4jwYm+MNzYMZIPKPc6WiJWzOOxCSJ6ny21sopoPy0uYkPsVgGK3 pR6H7Aslp4sxuSk1S4gUGf/+PijN2OTeu4lvjJA7D+3/0F8Qwb6qT2sEywAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMS0xMS0yMVQxNjo1ODowMCswMDowMIwPamcAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjEtMTEtMjFUMTY6NTg6MDArMDA6MDD9UtLbAAAAAElFTkSuQmCC X-Now-Playing: Four Tet's _Dialogue_: "3.3 Degrees From The Pole" In-Reply-To: <86y25imyna.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 20 Nov 2021 21:17:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220565 Archived-At: Juri Linkov writes: > Actually, =E2=80=98outline-font-lock-keywords=E2=80=99 extends the outlin= e regexp > to (concat "^\\(?:" outline-regexp "\\).+"). And indeed, > > (re-search-forward (concat "^\\(?:" diff-hunk-header-re "\\).+")) > > fails in diff buffers. Don't ask me why outline.el adds ".+" > at the end, I don't know =F0=9F=A4=90 That is quite odd, but it's been that way since 2003? The doc string says --- Regular expression to match the beginning of a heading. Any line whose beginning matches this regexp is considered to start a headi= ng. --- So it's specifying "the beginning", which could imply that there's always supposed to be something after it, but it's an odd limitation. > To circumvent this idiosyncrasy for headings in =E2=80=98describe-binding= s=E2=80=99, I > had to use a different regexp in =E2=80=98outline-minor-mode-highlight-bu= ffer=E2=80=99 > (not based on font-lock): > > (concat "^\\(?:" outline-regexp "\\).*$"))) > > where ".+" is replaced with less-strict ".*". And diff-hunk-header-re definitely specifies an entire line. Perhaps we could just change the .+ thing to .* and see whether it breaks anything? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no