From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#52148: 29.0.50; [PATCH] Make `project-kill-buffers' display list of buffers to kill Date: Sun, 28 Nov 2021 09:42:09 +0100 Message-ID: <87k0gslli6.fsf@gmail.com> References: <87zgppl1ag.fsf@gmail.com> <83lf18yd5t.fsf@gnu.org> <87v90clmwn.fsf@gmail.com> <8335ngy90p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30339"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52148@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 28 09:43:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrFm9-0007gw-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Nov 2021 09:43:09 +0100 Original-Received: from localhost ([::1]:52294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrFm8-0006mi-03 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Nov 2021 03:43:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrFm2-0006mZ-9v for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2021 03:43:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrFm2-0004VR-1n for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2021 03:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrFm1-0001Qx-Vw for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2021 03:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Nov 2021 08:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52148 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52148-submit@debbugs.gnu.org id=B52148.16380889395463 (code B ref 52148); Sun, 28 Nov 2021 08:43:01 +0000 Original-Received: (at 52148) by debbugs.gnu.org; 28 Nov 2021 08:42:19 +0000 Original-Received: from localhost ([127.0.0.1]:34928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrFlL-0001Q3-D2 for submit@debbugs.gnu.org; Sun, 28 Nov 2021 03:42:19 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:37546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrFlI-0001Pp-SA for 52148@debbugs.gnu.org; Sun, 28 Nov 2021 03:42:17 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id d9so8490921wrw.4 for <52148@debbugs.gnu.org>; Sun, 28 Nov 2021 00:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KeBGtj8R7A8rvf7RAPmDBxxdRQBnI0hQB3e3QPcyTj4=; b=Aj8U3yRYUNVfzoaFBy4vnD/diCTMJjlitVoirSY53Ai64J6Jwd/uXuMNAc74EP8Len PLRXu06cOTJVp61HtZTl5V4ecnk46ljw8Urn9ynxegfS3QAm9ROIQ4sTm1BjWn45ZwxX Y26apeQzfB5MUa16o0a2aQyddnRiNXX9u3UyADI7RYO6505Nc4DHx/2TKGb5IhjLNxD2 y/UEqNyXhesCKLOL+V+Kj12JpY6CK85npVW+p/ZoAC5cXAogqKlOVDyPuyzDa0ChaKo7 Ds8gFpq2lBUY76UH3IrcbMqN9hGUV3Bwtl7zIKOTrStYD6kLvO2XXfAU0KJcpcWS4mhL xZ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=KeBGtj8R7A8rvf7RAPmDBxxdRQBnI0hQB3e3QPcyTj4=; b=EarmCbZ89tONXfy9IOb46/qplNf9rTWzFjCklGk7/rDGZNoKJ62ajJ7xZIngqzqdeB t0A6QfcB5V+ZSXTWFAsHG1LZSmEwgb4qEFavXFoxuXtB7UKqGf9+Ly6xviubrlKVrbKM 1+GPY49qTIN6RNZdEirFgNJbl2uLUb5VNQsIxflL66b0Xmjpf37lGT21Dw3pQR9xhoLU VDw+YUkLYi5egRArA3WA9sVEbrhdCfR1aj0Gro0bBNxrnt6SIq+mcnwUsju0E/aBYpHz YPw229h5ezLSeblarEG978wMSarfBzDn13L6A/+Va3aFaIIte1dQXN2M6L/I884/XDXj xB2A== X-Gm-Message-State: AOAM5307eLnGwl/svSJbIcaEAzUXa7qgHwOIlHp6TUsEG0Idj/nR3Atm xXI2EqcMIEoybzQd23R/6wnSJY+PJN0= X-Google-Smtp-Source: ABdhPJzzlyc8B2lcohnLS83aP9p4Fha07526CTynSmBjX2CllP1Zxycm29VLzP/4Wslb844ms8Tp1w== X-Received: by 2002:adf:d1cb:: with SMTP id b11mr25740277wrd.33.1638088930825; Sun, 28 Nov 2021 00:42:10 -0800 (PST) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id l4sm10262900wrv.94.2021.11.28.00.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 00:42:10 -0800 (PST) In-Reply-To: <8335ngy90p.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 28 Nov 2021 10:33:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220960 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Thanks. A couple of minor comments below. Updated patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-project-kill-buffers-can-display-list-of-buffers-to-.patch >From fbb8829f93f7e898b3d243e9ed80101f0f0e1b8b Mon Sep 17 00:00:00 2001 From: Matthias Meulien Date: Sat, 27 Nov 2021 22:43:20 +0100 Subject: [PATCH] project-kill-buffers can display list of buffers to kill * lisp/progmodes/project.el (project-kill-buffers-display-buffer-list): Option to toggle temporarily display of the list of buffers to kill when calling project-kill-buffers (project-kill-buffers): Handle project-kill-buffers-display-buffer-list option --- etc/NEWS | 4 ++++ lisp/progmodes/project.el | 37 +++++++++++++++++++++++++++++++++---- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 87a7a43a5e..2bc1e0046a 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -427,6 +427,10 @@ it with new 'term-{faint,italic,slow-blink,fast-blink}' faces. *** 'project-find-file' and 'project-or-external-find-file' now accept a prefix argument which is interpreted to mean "include all files". +*** 'project-kill-buffers' can display the list of buffers to kill. +Customize the user option 'project-kill-buffers-display-buffer-list' +to enable the display of the buffer list. + +++ *** New command 'xref-go-forward'. It is bound to 'C-M-,' and jumps to the location where 'xref-go-back' diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index ed076a683d..14df03570d 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1210,6 +1210,15 @@ project-kill-buffer-conditions :group 'project :package-version '(project . "0.6.0")) +(defcustom project-kill-buffers-display-buffer-list nil + "Non-nil to display list of buffers to kill before killing project buffers. +Used by `project-kill-buffers'." + :type 'boolean + :version "29.1" + :group 'project + :package-version '(project . "0.8.1") + :safe #'booleanp) + (defun project--buffer-list (pr) "Return the list of all buffers in project PR." (let ((conn (file-remote-p (project-root pr))) @@ -1276,14 +1285,34 @@ project-kill-buffers interactively." (interactive) (let* ((pr (project-current t)) - (bufs (project--buffers-to-kill pr))) + (bufs (project--buffers-to-kill pr)) + (query-user (lambda () + (yes-or-no-p + (format "Kill %d buffers in %s? " + (length bufs) + (project-root pr)))))) (cond (no-confirm (mapc #'kill-buffer bufs)) ((null bufs) (message "No buffers to kill")) - ((yes-or-no-p (format "Kill %d buffers in %s? " - (length bufs) - (project-root pr))) + (project-kill-buffers-display-buffer-list + (with-current-buffer-window + (get-buffer-create "*Buffer List*") + `(display-buffer--maybe-at-bottom + (dedicated . t) + (window-height . (fit-window-to-buffer)) + (preserve-size . (nil . t)) + (body-function + . ,#'(lambda (_window) + (list-buffers-noselect nil bufs)))) + #'(lambda (window _value) + (with-selected-window window + (unwind-protect + (funcall query-user) + (when (window-live-p window) + (quit-restore-window window 'kill)))))) + (mapc #'kill-buffer bufs)) + ((funcall query-user) (mapc #'kill-buffer bufs))))) -- 2.30.2 --=-=-= Content-Type: text/plain -- Matthias --=-=-=--