From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Tue, 28 Dec 2021 23:28:31 +0100 Message-ID: <87k0fouzxs.fsf@gmail.com> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> <871r1zm7ji.fsf@gmail.com> <87wnjrkrwd.fsf@gmail.com> <86ilv8pnf3.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51809@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 28 23:29:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2Kxy-0003CH-HP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 23:29:10 +0100 Original-Received: from localhost ([::1]:46772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2Kxx-0005iW-4o for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Dec 2021 17:29:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2Kxq-0005i6-JY for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 17:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2Kxq-00006Z-8R for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 17:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2Kxq-000728-2p for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 17:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Dec 2021 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.164073052027007 (code B ref 51809); Tue, 28 Dec 2021 22:29:02 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 28 Dec 2021 22:28:40 +0000 Original-Received: from localhost ([127.0.0.1]:47663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2KxT-00071W-Mv for submit@debbugs.gnu.org; Tue, 28 Dec 2021 17:28:39 -0500 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:39459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2KxS-00071K-39 for 51809@debbugs.gnu.org; Tue, 28 Dec 2021 17:28:38 -0500 Original-Received: by mail-wr1-f44.google.com with SMTP id s1so40807604wra.6 for <51809@debbugs.gnu.org>; Tue, 28 Dec 2021 14:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=aMa2Vq88Si5TONexhYXkJVTUI/P57YQi/3G/L+Hd9/o=; b=l6MHL57tKANiLPQAhYQp9GnbKwRXdQk/FuwBzAOlgSDHYupRhBbsnQSWBpjF2bSqaE cIL+mH2ZtREWwz+TG7+RaerHhnAQH+4WXXigplchOMeGeresNwt99rvt+T3kyylJFYzG yA2QHsvqlC6gFQlC/c50bA5MVXrqPX9TTp1O8y6Cm1MVaeWKXRrA5ntaNmiXL/tCqFfm SWBO4/t/mSd3jLUBzNHJA5t2THbe2uI9WpwHsvCDRYvInCw683ysXbvloRXJ+ayqhoMu 7HqlMAphCdUnDlchRg9FDgsRZnw5itbEgada8UKAvhQsKg7M0ZI4efYQ/2Lo1nuDj87C uMxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=aMa2Vq88Si5TONexhYXkJVTUI/P57YQi/3G/L+Hd9/o=; b=w1rEB5MU19OgS61QDuRUsG2r29wLRqKqkKyc/k9g8zBpt+R/6OT8BOvNQdSD0da+LM jt3b2VPGyB1uQz46TX4EhrMQ7sivhts0xhwCuo1WezW34HUeszA6MpAOVH0raf76ShbM sWHbjgMLCSpeixvjRA6z2Z+sWTzJh1eogLz1CwIyAUh7EWfHIuM8Tn7KMPghU2LYHM77 oA3oUq3f0NAF9WTTv3vzVP+iWFrPOAgLgM9LmcJL7g399qVm7AmVvZ8YcX/+6/1ZPDl6 yo1WQnc2uNF21QsG8DKZglS2siqWoC+ouiK7oG5w9BVgEvw6nPclAIyOPtnXk7NHgi11 zvOQ== X-Gm-Message-State: AOAM533ulQf+EiF3kuho329+VM/OFK5F2dE6wB9qvZOrPitab0Wn90iE KoD3VvgAF2lwL7vbSMe4fKygH0/v2Io= X-Google-Smtp-Source: ABdhPJyM591TKs7Op0uM8t8/CWZ2RU0ZTEVJre1EajckPt5mntWORU5DCuV6DOqhEir+Tqb7dugowg== X-Received: by 2002:a5d:64c3:: with SMTP id f3mr17802952wri.295.1640730512236; Tue, 28 Dec 2021 14:28:32 -0800 (PST) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id l26sm18836055wrz.44.2021.12.28.14.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Dec 2021 14:28:31 -0800 (PST) In-Reply-To: <86ilv8pnf3.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 28 Dec 2021 20:37:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223295 Archived-At: Juri Linkov writes: > (...) Also xref works nicely, although I don't know why it requires > `outline-apply-default-state' after enabling `outline-minor-mode': It's a mistake to rely on `hack-local-variables-hook' to call `outline-apply-default-state' when Outline minor mode is enabled since `hack-local-variables-hook' is run after processing a file's local variable specs. An explicit call to `outline-apply-default-state' in the implementation of outline-minor-mode fix the problem: diff --git a/lisp/outline.el b/lisp/outline.el index 1a878dee04..65956b9dae 100644 --- a/lisp/outline.el +++ b/lisp/outline.el @@ -439,8 +439,7 @@ outline-minor-mode (setq-local line-move-ignore-invisible t) ;; Cause use of ellipses for invisible text. (add-to-invisibility-spec '(outline . t)) - (add-hook 'hack-local-variables-hook - #'outline-apply-default-state nil t)) + (outline-apply-default-state)) (when (or outline-minor-mode-cycle outline-minor-mode-highlight) (if font-lock-fontified (font-lock-remove-keywords nil outline-font-lock-keywords)) I'll send an updated patch after some time using this. -- Matthias