From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. Date: Wed, 23 Mar 2022 19:54:14 +0100 Message-ID: <87k0ck7b55.fsf@gmail.com> References: <87sftyweb2.fsf@gmail.com> <861r1iyrvw.fsf@mail.linkov.net> <87zgo6owaf.fsf@gmail.com> <86k0f9xnrn.fsf@mail.linkov.net> <87tuedp6pl.fsf@gmail.com> <861r1g7n3b.fsf@mail.linkov.net> <87o84jcx5x.fsf@gmail.com> <8635lvif0r.fsf@mail.linkov.net> <87mtidip1w.fsf@gmail.com> <86sfrjia5u.fsf@mail.linkov.net> <87ilseyks7.fsf@gmail.com> <868rt9wwji.fsf@mail.linkov.net> <871qz11w82.fsf@gmail.com> <86ilsc7e31.fsf@mail.linkov.net> <87tubwz9dd.fsf@gmail.com> <86sfrc2zr8.fsf@mail.linkov.net> <87o820iedv.fsf@gmail.com> <86h77s2wqo.fsf@mail.linkov.net> <87k0coibrt.fsf@gmail.com> <864k3o3j1g.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29632"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 53126@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 23 19:55:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX68a-0007UM-5n for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 19:55:16 +0100 Original-Received: from localhost ([::1]:60276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nX68Z-0000QO-5t for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 14:55:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nX68M-0000Q6-Bk for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 14:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nX68M-0006DM-1r for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 14:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nX68L-0001OT-LQ for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 14:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2022 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53126-submit@debbugs.gnu.org id=B53126.16480616665304 (code B ref 53126); Wed, 23 Mar 2022 18:55:01 +0000 Original-Received: (at 53126) by debbugs.gnu.org; 23 Mar 2022 18:54:26 +0000 Original-Received: from localhost ([127.0.0.1]:46032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX67l-0001NU-QU for submit@debbugs.gnu.org; Wed, 23 Mar 2022 14:54:26 -0400 Original-Received: from mail-ej1-f49.google.com ([209.85.218.49]:41690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX67j-0001NF-38 for 53126@debbugs.gnu.org; Wed, 23 Mar 2022 14:54:23 -0400 Original-Received: by mail-ej1-f49.google.com with SMTP id a8so4703695ejc.8 for <53126@debbugs.gnu.org>; Wed, 23 Mar 2022 11:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=d8ljeTm5j1NOPGkrGqsay/eJxEUSJiKHkGFjlAEvCzQ=; b=BDDCA3PNV9SIezhn4uUYL6z1CK4hDpZJ0Lv95htnLN1xWeuVyG2OVn9yoH69cjHElQ 22PblobxOFfioJLg3ZLP7UDRxWpF4N94fdfaoDixNVTEe8yXnaTbgRQvkTU447imj84t 0jn9n8TtJT6ZqGyYfkCnSxYIYdaQtkqUqzAsBR/cGGaAnZpw71trU+/l3q/WUz2Y3Vxd 99xnPAvoQUW38tLV3NGtCTr3qoTA+NJSMSXaqyu/4PmcraVe21sLP4D/F0LBjG/1hSwI RX776fDqrzhiVH2vhfXK/65nJdhpxBl5FG8+D3XhJR1eVw8gDnVQL2NWngJCqJEcAuG/ xE0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=d8ljeTm5j1NOPGkrGqsay/eJxEUSJiKHkGFjlAEvCzQ=; b=KvugackxfF19s0BkEFe7H9SP1vN7ZOPrZ7UbnqrlsCJxKLmAQwwBhydSWK/aE+kuKz 5X9FpYLuagnWC46FRijeBMmYfxMcNVMeD7pwMXqh1LCI6FsiGtiMoR67Zh2kKbDAW/kG X/DBblxZMvhXlPF0xrGd39mjxYDWIHWO0eyVuAzRRhQd8IqrtefZ5zxkQpPe+sBnH1uE xs6mhJM17z15Yqbdo8XmYWmMeNGb5z5hk+sSGMDM9Xu6Oj1EzR1BB5ulaXKtJd3I0MU4 2B7cvpRjeHGja4pb52gepa8qs+UZ3EadK1hoaVT6eLiqdyW3GEPLyHEkC1a+4ebteos2 8kAA== X-Gm-Message-State: AOAM533eGZ9yZ440O1eaREyTy3RWGZL67csj7jOdFJrqubHUoypbD5ac K2L86BoCtxQuFeolmCfalihjwsVCmRg= X-Google-Smtp-Source: ABdhPJyFL8wcQ4jObCi+4W3mzhJjP9frIeMILC8WO9Kr3d/lV2goeFqziixCPzQixPWcG3pvEGBZVA== X-Received: by 2002:a17:907:3e16:b0:6df:b4f0:5cc2 with SMTP id hp22-20020a1709073e1600b006dfb4f05cc2mr1641625ejc.285.1648061656681; Wed, 23 Mar 2022 11:54:16 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::758e]) by smtp.gmail.com with ESMTPSA id u3-20020a17090657c300b006d01de78926sm261383ejr.22.2022.03.23.11.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 11:54:16 -0700 (PDT) In-Reply-To: <864k3o3j1g.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 23 Mar 2022 20:20:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228828 Archived-At: --=-=-= Content-Type: text/plain On Wed, 23 Mar 2022 at 20:20, Juri Linkov wrote: > Unfortunately, there is a regression: isearch-yank-char-in-minibuffer > bound to C-f and [right] in the minibuffer of isearch-edit-string > doesn't work anymore. The following patch solves to problem for me. The point doesn't move visually, so selecting the isearch window puts it in the right place. But what exactly happens to the point in the searched buffer? I find this rather confusing! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-regression-in-isearch-yank-char-in-minibuffer.patch >From b9ed18bdfa72667b7d1e25982b7fd85dcb2c4166 Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Wed, 23 Mar 2022 19:43:13 +0100 Subject: [PATCH] Fix regression in isearch-yank-char-in-minibuffer * lisp/isearch.el (isearch-yank-char-in-minibuffer): Select the original window in order to restore point. This is needed when minibuffer lazy highlight is in effect. --- lisp/isearch.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/isearch.el b/lisp/isearch.el index 1a83586ef8..9b311cb49e 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2670,7 +2670,7 @@ isearch-yank-char-in-minibuffer (interactive "p") (if (eobp) (insert - (with-current-buffer (cadr (buffer-list)) + (with-minibuffer-selected-window (buffer-substring-no-properties (point) (progn (forward-char arg) (point))))) (forward-char arg))) -- 2.35.1 --=-=-=--