From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds Date: Fri, 01 Apr 2022 10:00:10 +0800 Message-ID: <87k0c9imvp.fsf@yahoo.com> References: <165c1dab82dbf3233ed5f9f481a008eb724aff31.camel@teloden.nl> <87o81t5x9o.fsf@yahoo.com> <83fsn5b6cj.fsf@gnu.org> <8735j55js6.fsf@yahoo.com> <83czi9b5gh.fsf@gnu.org> <87v8w143h6.fsf@yahoo.com> <87o81s2osr.fsf@yahoo.com> <88d833f72df4f4cbb5769f1a75057d3f957a812c.camel@teloden.nl> <87bkxnx1co.fsf@yahoo.com> <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26335"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Eli Zaretskii , 54564@debbugs.gnu.org To: Pieter van Prooijen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 01 04:01:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1na6b8-0006f9-UU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Apr 2022 04:01:11 +0200 Original-Received: from localhost ([::1]:33308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1na6b7-00082Y-Ok for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 22:01:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na6b0-00082P-LO for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 22:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1na6az-0000p8-VD for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 22:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1na6az-0005NV-Nw for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 22:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Apr 2022 02:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54564-submit@debbugs.gnu.org id=B54564.164877842820623 (code B ref 54564); Fri, 01 Apr 2022 02:01:01 +0000 Original-Received: (at 54564) by debbugs.gnu.org; 1 Apr 2022 02:00:28 +0000 Original-Received: from localhost ([127.0.0.1]:40408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1na6aS-0005MZ-E6 for submit@debbugs.gnu.org; Thu, 31 Mar 2022 22:00:28 -0400 Original-Received: from sonic302-20.consmr.mail.ne1.yahoo.com ([66.163.186.146]:40366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1na6aR-0005MK-OC for 54564@debbugs.gnu.org; Thu, 31 Mar 2022 22:00:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648778421; bh=QJIKymCWedLL5diUU0QuAP/Lje/UICltqUdNvFwN+X0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=QxCx7peyPPBV++2OUfdg/ScGesVKWnuQP3fS4EoYrJ5TMinN2kWB3KSiAE/CE2+RoOyDFBoMaEgioaeS51fr+ACn37CJeskInMFp55odRMvCmqGipq/ALwnq5iV/eI47f7yISviVNQCEJtN0Bt+vKJjRGXOb8rio08h9UdtXBLWF606C6xXoL25G2y4W8Fn0iknedWimQMVqKLppwE6j5uqBbNhneevHqkxHkYsW1KdXNmccgupOXZRUSfk1L7rAPnCYLnl0nRxaC3cPFksOx8Bxsgil9BOov75xgmW8Lq4yLpCvgXDGOd8eYShRrVMksV2d3iwrhcvxKSwEJpKMFw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648778421; bh=mQBMObSk6k5xkv41SK5KkMFjPe6+SfYX+TOScJjFdlu=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ELEW+bFw0LI3OE5fxUDgyrllvmXRW2WseF33sb7Z1cfU2SgI6nJOOahdaouZam8jo0K7b5Dh6Thc4n9C+5kGppP8+a/JlaAAI/DzZOvWcnaVy+f/XML0s6NPzqqjjaj0ocbhagxp8qFEf1k4u3HR6cFJ8GU++TgbTX3WMERv+vrBkUhKmivYfrHeDRnEDdLKpWyOEnHjjzO69k4XiPrT9HX8ufq+8AYgEbpKVBPBEf+lsHzAxDD6zdU5ZY1IZGl8BBnfWW7s9Es8TUEGgio2zVzUSsNlHmrjxSLmWiqELHxRVx1R5JRkEa+Zy5QpW2ol2JWSdiO/Q71jWfBXFkt4uA== X-YMail-OSG: 2nV6qHkVM1kXjfTIh8unxYUzUJiSoK5TnLNFHtQFswr67vm27IjjFi3tc3b8AMn vG3TGvDLfIVQ_C.vSrNbYsh90Q9lp.zZ0TY3KKHBSYp4f28oLSnM7vF10cJ40qGa8Gyw7tw6.D2F g2zov2Ty_TXRD.X6XXFY.JSQTUQxr88Ex43hxDtv3JOCd2R84pq5Ap7QgIkizAqzC8QA.7jHvBsx fKqkScC6ZhEWtSGffLKwGn4E4lrcdazJWlMrnB0Nf_Y_QMlXGm95STI5bPZaxjxeYnq7eUvakkxP QBDwy8VvGB118P.2mFunPGboUR8Q2elmRmekr3RVSBzWB47.g8NEEThUrc39c7stKmjDqAN38GqA 0LFxLr_BNpUN6E9MrW0sbgT7hRGUFiV458bOkZblb29NPs9wlKR9GItmcX4fFCsu8cUlPM2ToXCb QMVwuulAAtOAm3TEtYFHINwqLtSMgDNmbxroRtKD0ysKJ9SfHuQqMf4EMmR0QjNRS_NsOgfmbE7P z7Vm0RdL6Y8Er9zYlxcyyAJXNOSYkps8fJOX7LdqsH2zsHbXp8zglNmNOOioicTIU6Mo.PpcL4kD 3qu9DKK25czK88tDkTqmAEZeefUJOvXNLXfd5JxHmwzgwSIwaTAPOS7kbWCL_zW7gGBUWQfPaNHh CmQ9Dp19c1m7mVzFNuS1Bxr0MtMoEDcTTHNjRE_9z7L_7aZ1lU7PVHkQYggCbnUhb56DVftfbr86 wU8mydyurJJvlxwWhXaSHjIcDdJDIk4Jdr8FjNZiUkyAgV5ydrpabc9kbhDsVvu1JE5oTTvpwFdy 6HIgM1KljU6PsDUrUR7VtQfGRWh1lv7w8o0XAphx5. X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Fri, 1 Apr 2022 02:00:21 +0000 Original-Received: by hermes--canary-production-sg3-65d7bd97b5-nlj7h (VZM Hermes SMTP Server) with ESMTPA ID 8f4b154e6d772bbebec20f76c33358b2; Fri, 01 Apr 2022 02:00:14 +0000 (UTC) In-Reply-To: <211c08916190ef05cc1677956a77fca0c6122eda.camel@teloden.nl> (Pieter van Prooijen's message of "Thu, 31 Mar 2022 19:30:58 +0200") X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229197 Archived-At: Pieter van Prooijen writes: > Hi All, > > Thanks for the review, I've updated the commit message and other > changes you mentioned in the attached=C2=A0patch (against > c5af19cba5924de89a38e7a177c07f42fd3cd543) > > I've requested the form for the copyright assignment, but have not > received it yet, will send it in as soon as it arrives. > > No progress yet on the problem with subpixel antialiasing, but it > doesn't look like a fontconfig issue, as a non-pgtk build from the same > source works correctly, will have to dig deeper to find out what is > happening.=20 Thanks. >> > +=C2=A0=C2=A0 on the result.=C2=A0 */ Hmm... Is there an actual non-breaking space character here, or is your MUA munging the messages? > + if (dpyinfo_valid (first_dpyinfo)) > + store_config_changed_event (Qfont_render, > + XCAR (first_dpyinfo->name_list_element= )); You got the indentation wrong here. The "s" in "store_config_changed_event" should be two spaces behind where it is now. Otherwise, LGTM. Hopefully the copyright paperwork can be finished soon.