From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 09:12:27 +0200 Message-ID: <87k0b9he68.fsf@fastmail.fm> References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13381"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.13; emacs 29.0.50 Cc: 55149@debbugs.gnu.org, monnier@iro.umontreal.ca, iarchivedmywholelife@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 09:43:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njyoO-0003Gt-LO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 09:43:42 +0200 Original-Received: from localhost ([::1]:34988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njyoN-0007it-He for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 03:43:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyNe-0003ix-WE for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njyNe-0008LN-KL for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njyNe-0006oM-74 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 07:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , No Wayman , 55149@debbugs.gnu.org, Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.165113012626134 (code B ref -1); Thu, 28 Apr 2022 07:16:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Apr 2022 07:15:26 +0000 Original-Received: from localhost ([127.0.0.1]:45131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njyN3-0006nR-Ik for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:15:25 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njyMx-0006n4-PM for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:15:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyMx-0002yC-8s for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:15:19 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:43969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njyMv-0008Cy-Bf for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:15:19 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E87383200946; Thu, 28 Apr 2022 03:15:13 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 28 Apr 2022 03:15:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651130113; x=1651216513; bh=SyGQ8dSC6K hSOwOsAsUehDdVy45tvXHLDUq1DNDp71M=; b=UJ0q9naPmAk8YtLcL3co6Nj1vP yuiEQyqbShhEBUkqn8ujF72/xHi2myZ1ZCVu/uVGI5iag9l8honxelAVBFMQ04jZ osxIKztiSZgShtyXL+B/EGgGLv1WK7nI1RtTqV1gvIp167bl6Mz5tAeVHnKlKcsI VPqy5zDBb6mMhc8SbrU/2MugJDv9eB3Ax3xzybZ9xQxC2orWatXhRJr/Xmt95Rlq CTvpM+V2Lo/j619SxIu67MjKyajoTr3sbOTh0vhqWMuY79QnKfxT6WLYn6QDpgDM HPfi99vLVGD1A3Hwheak7Clbct190txL+JkVa/Ha4dgUCtdmXp7fAcv8NX9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651130113; x= 1651216513; bh=SyGQ8dSC6KhSOwOsAsUehDdVy45tvXHLDUq1DNDp71M=; b=k tcE639MxtMJP8w4eiOEDey11Mycf0qH/wTKPajJY4rydCVq9rYtimo1jpc+3wEd6 fycTG5SDHCfdn9A8/S0ichZLen+YKkI2I+lUdFvE11/2osLOOb1WRneX+a0cefK0 vliUCJZX0jvGWOSkJHHeMHcuNJQiiNdjvTYSFTINZOT1puK7VtGyZLDbXUJcE0mv KUc5rd6y8GvOs6tWtwpU5mqr123PPjR3lgYOW/HTu9/YakYdJTFGNgP6zKRIGjbu 0be/mSxAKYOoudlZ6wS8+7Bn5Ri2cGl+HDD551/w8cnaQ8qWSw/jA5vcP1r3EJUd IQq7T2izFTGk4Q36NCECg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhhohhrnhesfhgrshhtmhgrihhlrdhfmheqnecuggftrfgrth htvghrnhepgeffiefhjeekueeiueehteetgfehtefgffegfeduheejiefhgfehteektefh vdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhrnhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 03:15:12 -0400 (EDT) In-reply-to: <86bkwly9qy.fsf@mail.linkov.net> Received-SPF: pass client-ip=64.147.123.19; envelope-from=thorn@fastmail.fm; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230841 Archived-At: Juri Linkov writes: > I have the same problem, and distilled it to the shortest test case: > > ``` > (defun testa () > 1) > > (advice-add 'testa :after > (lambda (&rest _) 2)) > > (defun testb () > (interactive) > (message "! %S" (testa))) > ``` > > In 28 it returns 1. > In 29 it returns 2. > > The regression is that the return value of :after now overrides > the return value of the original function. Oh, indeed. But isn't that exactly as documented for add-function? :after (lambda (&rest r) (apply OLDFUN r) (apply FUNCTION r)) Of course, we'd rather want :after (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) Bye, Tassilo