unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "C. Michailidis" <signal3@gmail.com>, 56110@debbugs.gnu.org
Subject: bug#56110: 27+; switching from line-mode to char-mode
Date: Thu, 23 Jun 2022 18:56:30 +0200	[thread overview]
Message-ID: <87k097mi81.fsf@web.de> (raw)
In-Reply-To: <jwv1qvgqmeu.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 22 Jun 2022 20:02:55 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > That works - but I fail to understand why a simple `let' doesn't suffice
> > (which works as well):
>
> Depends if you want to have to think about what other code does or
> not.

I want.  The initial revision by Richard already looks like

#+begin_src emacs-lisp
(unwind-protect
    (progn
      (setq term-input-sender (symbol-function 'term-send-string))
      (end-of-line)
      (term-send-input))
  (setq term-input-sender save-input-sender))
#+end_src

I checked (using variable watchers) that when I replace
unwind-protect+setq with let, the executed code doesn't leave the scope
of the let.  So why was it written like that?  `term-input-sender' has a
buffer local binding (it already had in the initial revision from 1994)
- but the current buffer is not changed in between.

Did `let' back then not work with buffer-local bindings - or what could
have been the intention to avoid `let'?

> If you don't, then `let` is not the same: e.g. if some other code uses
> `add/remove-function` on that variable within your `let`, their changes
> will be lost when your `let` ends.

Yeah, such things - but I don't think anything like this is crucial
here.


Thanks,

Michael.





  reply	other threads:[~2022-06-23 16:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20 14:20 bug#56110: 27+; switching from line-mode to char-mode C. Michailidis
2022-06-21 11:47 ` Michael Heerdegen
2022-06-21 12:20   ` Michael Heerdegen
2022-06-22 17:23     ` Michael Heerdegen
2022-06-22 19:22       ` signal3
2022-06-22 21:14         ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-22 22:23           ` signal3
2022-06-23  0:02       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-23 16:56         ` Michael Heerdegen [this message]
2022-06-23 21:45           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-25 12:17             ` Michael Heerdegen
2022-06-26  8:17               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-26 11:24                 ` Michael Heerdegen
2022-06-26 12:23                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-26 13:04                     ` Michael Heerdegen
2022-06-26 15:15                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-26 14:49             ` Michael Heerdegen
2022-06-26 15:08               ` Andreas Schwab
2022-06-26 15:30                 ` Michael Heerdegen
2022-06-26 16:01               ` signal3
2022-06-26 18:00                 ` Michael Heerdegen
2022-06-26 18:39                   ` Michael Heerdegen
2022-06-26 18:40                   ` Lars Ingebrigtsen
2022-06-26 18:44                     ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k097mi81.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=56110@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=signal3@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).