From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Date: Mon, 11 Jul 2022 18:25:35 +0800 Message-ID: <87k08kymhs.fsf@yahoo.com> References: <87tu7p1z75.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38110"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 56462@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 11 12:26:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAqcx-0009lg-D1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 12:26:55 +0200 Original-Received: from localhost ([::1]:54124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAqcv-0002Gc-Fh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 06:26:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAqc7-0002FM-Ew for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 06:26:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44504) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAqc6-0002Ea-3W for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 06:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAqc5-0006Mv-U0 for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2022 06:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.165753515224458 (code B ref 56462); Mon, 11 Jul 2022 10:26:01 +0000 Original-Received: (at 56462) by debbugs.gnu.org; 11 Jul 2022 10:25:52 +0000 Original-Received: from localhost ([127.0.0.1]:38401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAqbw-0006MQ-78 for submit@debbugs.gnu.org; Mon, 11 Jul 2022 06:25:52 -0400 Original-Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:43311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAqbu-0006M9-A7 for 56462@debbugs.gnu.org; Mon, 11 Jul 2022 06:25:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657535144; bh=kWebO08RdHsXohVonEv7LqLLlFo1dcxaqFzAodBk6uo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Id/AbXM76b7uy76JhBVUoQbe7s89nP2mQKKKKkjab93LONUu2hbYwXMmUP3evH+ilpQiybDmnxkdo/gjrqnYGFT6hZSgEsVP5EcorHnPFVsp9WWfBzpLqUpukNoCkNw4cqK9oe7gbja56zZFqZMmiES6o3NgxCbYQC+r2gBxPrqFBqa81lOx8REPs1Gnnh4KiNUA+ntwuovE33OO5mAawHJpPFap6gVvC9fTpikFnFzLiEua/i+np4tdn7nosgBDZWh9cFcm4hfM0nn2/2afJ0EE5pHMA+QJWjLQzy8cvLH14v79RFBbWTTy+K+wtQyZPhTtes7FTG/Vuhn3AtRAXw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657535144; bh=MtfSe2VXeEW8EgQgdJM8wjZezdAURzfPq5vLry6aoNv=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=G9sBTTPE2tm5Pd8MKJUkYVmkhY5EuopRFBvEZga8aFNlHS3w3W333DEMIDsehccyLlNVv+zPebKi1brFRKEI7vjf/nMDgF4zKTbBAtzORb77andYPYeYlcxKf5g9BSv2PLf09rFMiffnRVYlTNA+Gpm3ukvjhtCWfTicHo94bWThkAjbn5l6A59qkIuvhQihKwVZSMgZPyE1qXBKhiLB5pktg8vBKkogM+ZLmTh96As3uvHNUeRazUcUD6iD5VFG1ZXno3A27iHWSbvZ05FDRQxK3ah2JSrcCtevq9HGkvW82einBAZ397FGl3S0l7eQA0YD3OEhG602FQ1LfNlQPQ== X-YMail-OSG: FQ8JT1IVM1khcNICTel5fHO8dgxfOimuDR9kgwlgVH2LD.7UlNY8u307hsPxdlU GdnYbCzDgPqeFGlYSglDMVATJyKDmwD7m_WXmsgg84hCS5kBR5kh6bNep4GaP7XEjIVhtLwuwi2e Gkoocv8K41AHV4Sded5KHwk3wq241jklOUqhbuFJSjH1bJXtljdV8zrDl0iHu4Q3SccX2gKfdQYF EXri4sZ5SuZZ9Eac0MtzSVR.lzb5hhN9G.SSjoDIwyPJDAfIBCRus0L7lVf7UOr5P2wyxub2_DhY SRiI91jb.SC_OWxIBWqlzIOTeoPCvICZjEX2lbYo24NheXL3QoQ.8B7MLG5rUEh3ue8uT1aYgZEJ W_nzPi2WvdTM_fePMe9XFD3iR7TYl8.48oj4S32ij5nyb8ToWlJdV0tW36eYFCNf0j_xB64Q3l2G glq_3GO7ygJj3yxOAYHw.iUOYz266.WM_MqJ9EYap0PH3XbsuPVwvoVUCJ1Ha9lUPVJxjS00wShB k2qH84.E.CLjNI7RpHIMttZDYKvQnFKHT.ejXLxkxnbln_KTAjzpXIZoVAUgZazJo.FJCLl0UGpf smIJl4DH6TsNW5Q7o5rlxWG_aEv5_Yw3v4xifSlewTdyuws6OwJLT4pN84t7GYAa6FkrBj16SKUw uMVk6bxugS2cEsyf0MhWrFxNpXcQ3XGule6OkqEkZd9zgvcXaVnwBb5q93L6pA8NSy4y8x6jKIO. _IYRF96syUCy8fyw9dFLBLKu74VFl1FjCJm5U7jP2cCUPoyQ.YtvH1sOKsTpHd1zpnAyUucO3rqa cJ7Phf4McNwKREDvgiETXAr0f9HOXTL5fJMw_Hp2Sx X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Jul 2022 10:25:44 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-qg7qj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 15bd29704b2839bf4bca6e26d291abfc; Mon, 11 Jul 2022 10:25:39 +0000 (UTC) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sun, 10 Jul 2022 22:52:08 +0200") X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236628 Archived-At: Daniel Mart=C3=ADn writes: > Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >>> >>> Thanks. But I think the use of static variables there is rather ugly, >>> and it would be much nicer if we replicated the `x_setup_relief_color' >>> logic there. >>> >>> Do you want to work on that, or should I? >> >> Thanks, I can give it a try. > > Here's a patch where the static variables are now proper fields in the > ns_output structure. Is that what you had in mind? Now installed, so I'm closing this bug.