From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Tue, 09 Aug 2022 19:52:51 +0200 Message-ID: <87k07hwbgs.fsf@gnus.org> References: <83tu6ltlcq.fsf@gnu.org> <87y1vxwe0y.fsf@gnus.org> <83k07htjxf.fsf@gnu.org> <87o7wtwcu9.fsf@gnus.org> <83fsi5tj31.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1646"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57079@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 19:54:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLTRC-0000FH-UW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 19:54:43 +0200 Original-Received: from localhost ([::1]:44282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLTRB-00058o-Sd for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 13:54:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTQY-0004wD-13 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55093) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLTQX-0001Kd-Nm for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLTQX-00062A-K6 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 17:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.166006758523125 (code B ref 57079); Tue, 09 Aug 2022 17:54:01 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 9 Aug 2022 17:53:05 +0000 Original-Received: from localhost ([127.0.0.1]:44842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTPc-00060v-Mx for submit@debbugs.gnu.org; Tue, 09 Aug 2022 13:53:04 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTPZ-00060P-5U for 57079@debbugs.gnu.org; Tue, 09 Aug 2022 13:53:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=f+tw9+7b/bB2t51uDUcFZjYytYVryCQdYLbnW0MDiVQ=; b=tmeBO8Q/YnhADJ9Txr3WeTVZeX 669CG1bo0EIfHvz2wmVjlLLCPk5ahjiQnIEtTSSla1fTVoJfD3KbeTu5FvekeubqC9UEr0mNlRBGR UkyOL1q3ZN7BKhmeqNmXUWz62vH8Xqc3d3nC9fQuk0qaFR599VpPqIeD9O/zGK5mF+OE=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLTPQ-0006F4-GB; Tue, 09 Aug 2022 19:52:54 +0200 In-Reply-To: <83fsi5tj31.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Aug 2022 20:36:34 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEUKBAcjFitoYmSF foAoK2EmR5YnWqomWaz////PNYGJAAAAAWJLR0QIht6VegAAAAd0SU1FB+YICRE0A352PX4AAAF4 SURBVDjLlZNRbsMgDIaLtAOEigOscIKRHaCRoO+VMDsB5AIrXH92CIoTNQ/zQx74+G3z27lc/h9X o/Wn1vZm7Giv2hpj9bgAbfTNGvtlRv2Nl4y20nSVPMkmMQb6vDlfY3cuzsB2PJxmOlEo6eSxhKPw wTmWTahJOYCYAMPdWSa6m3Othci0AYUA5oqRURSGN6CWfAB+BbWkMHEAHdQEHHjsaQUZ3F4R567Y iiwAclccwVqFA9lAbF3BZoqgdpsE387bRe8I5EJuTeyBeL9p0FxKJDqASIceswxCIVBDBy08pheO ufuxHM8lPJ4XGZ9sUA+yO9aXm4Svv2yEngDMLyfVD2LW1pIrlkCgwjZcsfQKOQWPILCpq0ZiLXN9 sRF2CZnCbd8A+VhOFNgVX9K1BvnL3MUgd2PKVIKvIraFNrZdTLwEPTG1RHyAHbTSByB86qsV7nvQ u83hoMgrgT1Y+l3CTXsFLSktw3T4d2XbH3AO/1BcFZL9AU2AuNk9yzc1AAAAJXRFWHRkYXRlOmNy ZWF0ZQAyMDIyLTA4LTA5VDE3OjUyOjAzKzAwOjAwUiA95QAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy Mi0wOC0wOVQxNzo1MjowMyswMDowMCN9hVkAAAAASUVORK5CYII= X-Now-Playing: Grace Jones's _Warm Leatherette_: "Love Is The Drug" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239182 Archived-At: Eli Zaretskii writes: > But the above means that using seq-uniq with TESTFN nil is going to be > unnecessarily slow from the get-go. People shouldn't use seq-uniq if > they don't need a non-default TESTFN, because much faster > implementations exist. > > IOW, since this bug is about speed, not anything else, I think making > seq-uniq faster when TESTFN is nil isn't the right solution, the right > solution is to point out that seq-uniq's purpose in this case is not > to be a Speedy Gonzales. I didn't make seq-uniq faster just when TESTFN is nil -- I made it faster for all lists, so I don't follow you at all here.