From: Michael Heerdegen <michael_heerdegen@web.de>
To: 57115@debbugs.gnu.org
Cc: larsi@gnus.org, bmsac0001@gmail.com, monnier@iro.umontreal.ca
Subject: bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level
Date: Sun, 14 Aug 2022 04:02:14 +0200 [thread overview]
Message-ID: <87k07boa55.fsf@web.de> (raw)
In-Reply-To: <jwvv8qwp1v3.fsf-monnier+emacs@gnu.org> (Stefan Monnier via's message of "Sat, 13 Aug 2022 12:06:37 -0400")
Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> Should be fixed on `master` now.
modified lisp/emacs-lisp/nadvice.el
@@ -167,31 +167,31 @@ advice-eval-interactive-spec
(defun advice--interactive-form (function)
"Like `interactive-form' but tries to avoid autoloading functions."
- (when (commandp function)
- (if (not (and (symbolp function) (autoloadp (indirect-function function))))
- (interactive-form function)
- `(interactive (advice-eval-interactive-spec
+ (if (not (and (symbolp function) (autoloadp (indirect-function function))))
+ (interactive-form function)
+ (when (commandp function)
+ `(interactive (advice--eval-interactive-spec
^^
That function doesn't exist...?
TIA,
Michael.
next prev parent reply other threads:[~2022-08-14 2:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 0:55 bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level Pythonora Nybon
2022-08-12 15:27 ` Lars Ingebrigtsen
2022-08-13 4:37 ` Michael Heerdegen
2022-08-13 16:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-14 2:02 ` Michael Heerdegen [this message]
2022-08-14 13:20 ` Stefan Kangas
2022-08-14 22:53 ` Michael Heerdegen
2022-08-15 14:29 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k07boa55.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=57115@debbugs.gnu.org \
--cc=bmsac0001@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).