From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51130: 29.0.50; shell completion fails to complete filenames Date: Tue, 13 Sep 2022 13:19:07 +0200 Message-ID: <87k0674j4k.fsf@gnus.org> References: <87a67496rq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4339"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51130@debbugs.gnu.org, Carlos Pita To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 13 13:20:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY3y4-0000wZ-5F for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 13:20:40 +0200 Original-Received: from localhost ([::1]:51638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oY3y3-0001Ki-6k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 07:20:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY3xS-0001KI-OF for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 07:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60341) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oY3xS-0006SF-3u for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 07:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oY3xR-0002MC-No for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 07:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 11:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51130-submit@debbugs.gnu.org id=B51130.16630679598991 (code B ref 51130); Tue, 13 Sep 2022 11:20:01 +0000 Original-Received: (at 51130) by debbugs.gnu.org; 13 Sep 2022 11:19:19 +0000 Original-Received: from localhost ([127.0.0.1]:49036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY3wl-0002Kx-1I for submit@debbugs.gnu.org; Tue, 13 Sep 2022 07:19:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:35298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY3wj-0002Kl-Q7 for 51130@debbugs.gnu.org; Tue, 13 Sep 2022 07:19:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ynaH8hNw5PCMiiZ9aqXEDIT+8I34nolXyVbqtAOd8YI=; b=VnN4Qby7hXp5E/pV0sr7W80MUS yM6JAB6a9cNffJ0owggAUnaluCUT9sZVSJ+UhfgPSsYA6pJhHEHzIZdO0ZWs4jp+Ypz6P7/5qhm/g nMg02hfNvY3YyB5bZci6gQwKAT0D4RYUqYL8PVKOfMlXbA5AxqvedrZWinUCIJ2qvZpw=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY3wa-00023n-4O; Tue, 13 Sep 2022 13:19:10 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 12 Sep 2022 10:33:35 -0400") X-Now-Playing: Laurel Halo's _Quarantine_: "Mk Ultra" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242337 Archived-At: Stefan Monnier writes: >> * lisp/shell.el: Require and use pcomplete. >> (shell-dynamic-complete-functions): Add pcomplete-completions-at-point. >> (shell-completion-vars): Set pcomplete-default-completion-function. >> >> Just leaving pcomplete-default-completion-function alone seems to give >> better results in shell-mode (after testing very briefly), so I'm not >> sure why that was added. > > It was added because leaving `pcomplete-default-completion-function` > alone means that the functions after `pcomplete-completions-at-point` in > `shell-dynamic-complete-functions` are not used any more. Uhm... I don't follow the logic at all. pcomplete-default-completion-function is documented to be applied if everything else has failed to do completion, isn't it?