From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#57536: 28.1; filenotify problems on macOS with symbolic links to directories Date: Sat, 17 Sep 2022 17:15:04 +0200 Message-ID: <87k062oww7.fsf@gmx.de> References: <890113EA-44AF-42FB-87AF-130D7AB164AD@easesoftware.com> <83edwuqome.fsf@gnu.org> <87h71nbc2v.fsf@gmx.de> <83mtbfl1z5.fsf@gnu.org> <87czcbb4gh.fsf@gmx.de> <83leqzkxdi.fsf@gnu.org> <87v8pmw2pa.fsf@gmx.de> <83k062150s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7681"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: pedz@easesoftware.com, 57536@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 17 17:16:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZZYG-0001tH-M8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 17:16:16 +0200 Original-Received: from localhost ([::1]:37766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZZYE-0002R5-Um for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 11:16:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZZY2-0002PO-Mh for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 11:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZZY2-0000oJ-FU for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 11:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZZY1-0001xs-Vo for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 15:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57536 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57536-submit@debbugs.gnu.org id=B57536.16634277587544 (code B ref 57536); Sat, 17 Sep 2022 15:16:01 +0000 Original-Received: (at 57536) by debbugs.gnu.org; 17 Sep 2022 15:15:58 +0000 Original-Received: from localhost ([127.0.0.1]:46960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZZXy-0001xc-5A for submit@debbugs.gnu.org; Sat, 17 Sep 2022 11:15:58 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:51971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZZXt-0001xL-OL for 57536@debbugs.gnu.org; Sat, 17 Sep 2022 11:15:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663427705; bh=4O7HVFNgvz6JxG/qhSTeHE0M7o0JTEkJ0dNQC9RdAsQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=jibRVu6VvHL7vtOZetukAShMyPIv5wteW/MbBvrS70pJ+Yu/iytMQo8P49IUc6GA5 mOiCjUqLac6gXRjzqoBYIVexZ1RG6DBkbgfX7S/hF7wvEBSCgSl4F98VwFw3/zfIZB tsNx5vYnc4ULjM2dkedvMOopH4TmfLcJnMlUV9yk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([79.140.119.121]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M3DJv-1oaP0m1MNh-003dEW; Sat, 17 Sep 2022 17:15:05 +0200 In-Reply-To: <83k062150s.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Sep 2022 16:53:23 +0300") X-Provags-ID: V03:K1:CrT4NPtzTtMxM/KtQSDhZHQ2CkQ3wIELsGnewQ6ySqJI7aeMmxP VsZQhdd5JyePHWF/08gJm5Lid/2wLw2Kv35pBTmkmwNKE/v+w9zsvAxeRWcscMBShkow4Hs J++lP0qUSVLWBdLRyiIb2IXR1ugNjV+0qPrDI88WppF30QUA6Yq9i87cmiD2Ccbs07Vk2CU Q0Sc37wCZDJiKu/jL2Hcg== X-UI-Out-Filterresults: notjunk:1;V03:K0:lCVGlHGZcJE=:vzZY/1DFa7xShEYxCrS8mW HJCLPbqEPaqicmfrFEsURG0D8zzME0gvnyXLuVSmTq0MzVZ2eM85Cv0psYCTduoRpKyZYiosN yaHJaUnjSOLDVmfmnkYRjFw+qn8uf5IN1tuR1wguDXFP9PzAF8Rq+rlFYhiui+Vd0gLuLHyCf QmzkJ8SKo3IFC1eBDGNVPty5MmFhzTn00CAeh16vkxI1B0XLQEn9Xu8778HwOgTE1R7n7R8Hr +O0tQzdOU+9tEGloQj5go7sCw+PdKNEOcROAskTIe8bgOBMhVzUzlS1KVy7BCtDIbTRsV3dt8 TzmC2hZJVEUcbWzLjnJga2oIT5X4gYdA9UNe2FuVt8LTy1vGRJIYoLZgg8sZvA5u2w5kPBa4G b8KEReScSiEyqgeAHlLJjcecu3bjiJ7XVqdDNJq01fy05Pey92XoHOaBZkLTMU9rvwK93DRBN RgQfvsXJQg1aMka9i6FO4Ta6ptcd2lS4y7O2+rXVOEx8syDGkhOzIrnEvqb1RcUvz8+YNa7g0 ssMgt8yPE2q/aTpLQPXz3pTLGUaaVJBbQqWf8W22PwnNRpFtjqhx5pzkuWEvsTxKHsrUdr4E8 K2sGdki23n62JuhkvOWoRpOpK2OJSQd+/tbq90/chYmFfwhwTNTvjBKZfnQa1BHq1SOzXOtmG 0ujDirFIxN5fK10ahG5G/VCLoHl5oSjOqAo+KDiYqUb9NSP7HabTxPT1+6CZXW0tNb4Rgtn5b ZiXU2iDtoPIHjAipiqbWoFSHa2IHAbpx8WEc2WrHxgQi4eMih3wWhllvCXNlfQ+oZelJyECN X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242879 Archived-At: Eli Zaretskii writes: Hi Eli, >> Besides this, do we want to extend file notifications to follow symlinks >> when indicated? As said already, we could add a new symbol `follow' to >> be used in the FLAGS argument for that function. Implementation shall be >> simple for inotify and w32notify; for the other backends it needs to be >> investigated. > > I'm not sure this is needed: clients can always resolve the symlinks > themselves, no? OK. > I'd start by documenting that we no longer follow symlinks when > watching: that's a kind-of incompatible change. Then I'd go by > complaints, if any. I've extended already the doc yesterday, see (info "(elisp) File Notificati= ons") --8<---------------cut here---------------start------------->8--- If FILE is a symlink, it doesn=E2=80=99t follow that link. Just FILE itself will be watched. --8<---------------cut here---------------end--------------->8--- And it isn't a visible incompatibility. Yes, inotify and w32notify did follow the link, and they have raised events for the link target. But in file-notify-handle-event this event must be adapted in order to keep the unified action names we have introduced in filenotify.el. And the event will be propagated only in case the full file name in that event is supervised via file-notify-add-watch. This didn't happen for the followed file names (the symlink targets), such events weren't propagated, and the effect for the users was the same as when inotify and w32notify didn't follow the link (as we have now). So I believe we have nothing to explain but just the clarification I have done yesterday. >From my pov, this bug can be closed. The problem with kqueue I will work on once I have a new FreeBSD VM. Best regards, Michael.