unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: 58363@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved
Date: Sat, 08 Oct 2022 15:41:51 +0200	[thread overview]
Message-ID: <87k05asa8w.fsf@gnus.org> (raw)
In-Reply-To: <87mta7lb3o.fsf@bernoul.li> (Jonas Bernoulli's message of "Fri, 07 Oct 2022 20:52:59 +0200")

Jonas Bernoulli <jonas@bernoul.li> writes:

> sqlite-select does not signal any errors.  This just returns nil for
> example:
>
>   (sqlite-select (sqlite-open nil) "SELECT * FROM no_such_table")
>
> At least some of the other functions do signal errors when appropriate.

I've now made this signal an error:

Debugger entered--Lisp error: (error "SQL logic error")

Eli, this also required changes for the Windows macrology at the start
of src/sqlite.c -- can you check whether I broke anything?





  reply	other threads:[~2022-10-08 13:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 18:52 bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved Jonas Bernoulli
2022-10-08 13:41 ` Lars Ingebrigtsen [this message]
2022-10-08 14:35   ` Eli Zaretskii
2022-10-08 14:51     ` Lars Ingebrigtsen
2022-10-08 22:47   ` Jonas Bernoulli
2022-10-09 14:18     ` Lars Ingebrigtsen
2022-10-10 10:56       ` Jonas Bernoulli
2022-10-11  0:23         ` Lars Ingebrigtsen
2022-10-14 17:52           ` Jonas Bernoulli
2022-10-21 21:06           ` bug#58363: [PATCH 0/3] Improve error data signaled by sqlite-execute et al Jonas Bernoulli
2022-10-21 21:06             ` bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type Jonas Bernoulli
2022-10-22  6:45               ` Eli Zaretskii
2022-10-22 10:45                 ` Jonas Bernoulli
2022-10-22 11:45                   ` Eli Zaretskii
2022-10-22 15:32                     ` Jonas Bernoulli
2022-10-22 15:59                       ` Eli Zaretskii
2022-10-21 21:06             ` bug#58363: [PATCH 2/3] Introduce a new sqlite-error Jonas Bernoulli
2022-10-22  9:14               ` Michael Albinus
2022-10-22 10:47                 ` Jonas Bernoulli
2022-10-21 21:06             ` bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al Jonas Bernoulli
2022-10-22  6:49               ` Eli Zaretskii
2022-10-22 11:07                 ` Jonas Bernoulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k05asa8w.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=58363@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jonas@bernoul.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).