From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58960: 29.0.50; Assert fails when browsing an URL, bug#58960: 29.0.50; Assert fails when browsing an URL Date: Wed, 02 Nov 2022 11:20:31 +0100 Message-ID: <87k04dodxs.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16961"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= , 58960@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 11:21:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqArx-0004C4-8p for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 11:21:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqArq-00017q-Kr; Wed, 02 Nov 2022 06:21:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqArm-00016R-Mx for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 06:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqArm-0008Bu-FO for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 06:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqArl-0005VK-So for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 06:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58960 X-GNU-PR-Package: emacs Original-Received: via spool by 58960-submit@debbugs.gnu.org id=B58960.166738444121109 (code B ref 58960); Wed, 02 Nov 2022 10:21:01 +0000 Original-Received: (at 58960) by debbugs.gnu.org; 2 Nov 2022 10:20:41 +0000 Original-Received: from localhost ([127.0.0.1]:44963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqArQ-0005UO-Td for submit@debbugs.gnu.org; Wed, 02 Nov 2022 06:20:41 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:33377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqArO-0005UB-L2 for 58960@debbugs.gnu.org; Wed, 02 Nov 2022 06:20:39 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id h9so23854091wrt.0 for <58960@debbugs.gnu.org>; Wed, 02 Nov 2022 03:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Z0kbe5sJjAcmaL2Dk9bCiQ3q248lOkslqKEq0ih7tQk=; b=UHsYsq3dtoVc8EmCBxICdNrFj3lzN+cBl4iO0oy1Nl2KI2jFpfQjyod10pTVlXBKK6 QRwztMIKuO5z4gRO9cfH4C+Kcpd0UEeozezCbI8kgfx/uJxwdxmP8Y6kuZvnVziWpI2q pvBgMaDuFdMRxSUTqCA6F4qRE0LmcGmG4ZGWtyL/yrl6N2DaVqpFcNqjosnR2pEvx4X0 ZtKfvTlYyayyjmlb2xyYxuqZ60HaBCMeXjNNohyfp3ns0OgP0oK8MzII1X0s+O6i2nJS x7+SnKVPUz5K2mGrQi77QokJYQvp/dKy/Wv35h2BYmuaOLxfTdE0XQ7XMWQM+933aPtG YTYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z0kbe5sJjAcmaL2Dk9bCiQ3q248lOkslqKEq0ih7tQk=; b=keaA6AzpqneYFcDjw2b5YOQrzAGfvIsdPozS9io8SzBATHQQmCLoZ9yPLonlg5sFCV JsDfsoYS3MoyEfmEmXZ/WouIBovLJlkys2s2PPxuSJHPOyG+rVlv0nZswoZpyslJNhE+ oSEvjBb9DNRH7XNyPl4atugUvhyzQ8cy2tWtqXPOfvygz2KjCFFtZLbSevBMKNhHIKdm vDjIdi2F5nXpirMFm9TFaBIRmWpAygCFZ6t07f1Dd3rd3UNjdbJmYaxxvnAJ/9kQ3UzF HukGAIZbhD5wSpnDBx6ZSsy3wYZJGU3aU327NHSQ6jiJhKI+wEOGkOqffC8tOEQ/if2G Wxxg== X-Gm-Message-State: ACrzQf140H9nYfJ33tPEvVBkkL/LHFGHxO1ltKm66LZg4b16miTtexjK 0r8QEdRUqhIJshrnBYSDNZ0= X-Google-Smtp-Source: AMsMyM5xP1gUi5pczTvmRu7QX3/ZZjzSQxBNyPIOIr+T9vP02VR1CxbtoNNLdo0JBk1MaMxi4FXh2Q== X-Received: by 2002:adf:f4c7:0:b0:236:c415:c707 with SMTP id h7-20020adff4c7000000b00236c415c707mr11392696wrp.24.1667384432688; Wed, 02 Nov 2022 03:20:32 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id h17-20020a5d6e11000000b002356c051b9csm12343103wrz.66.2022.11.02.03.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 03:20:32 -0700 (PDT) In-Reply-To: (Tino Calancha's message of "Wed, 2 Nov 2022 05:48:30 +0100 (CET), Wed, 2 Nov 2022 05:48:30 +0100 (CET)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246857 Archived-At: >>>>> On Wed, 2 Nov 2022 05:48:30 +0100 (CET), Tino Calancha said: Tino> emacs -Q Tino> M-x browse-url RET Tino> https://www.example.com RET Tino> [The URL is opened by my default browser and Emacs crashes with t= he Tino> following backtrace] Tino> process.c:7386: Emacs fatal error: assertion failed: 0 <=3D fd This goes away if you do something like 'M-x shell' first, right? Looks like `call-process' needs to ensure the child signal fd=CA=BCs are set up before calling `emacs_spawn'. I=CA=BCm suprised nobody has run into this before. Does the (dirty) patch below fix things for you? Robert --=20 diff --git i/src/process.c w/src/process.c index 358899cded..4690addcf1 100644 --- i/src/process.c +++ w/src/process.c @@ -292,7 +292,7 @@ network_lookup_address_info_1 (Lisp_Object host, const = char *service, descriptor to notify `wait_reading_process_output' of process status changes. */ static int child_signal_write_fd =3D -1; -static void child_signal_init (void); +void child_signal_init (void); #ifndef WINDOWSNT static void child_signal_read (int, void *); #endif @@ -7323,7 +7323,7 @@ DEFUN ("process-send-eof", Fprocess_send_eof, Sproces= s_send_eof, 0, 1, 0, =20 /* Set up `child_signal_read_fd' and `child_signal_write_fd'. */ =20 -static void +void child_signal_init (void) { /* Either both are initialized, or both are uninitialized. */ diff --git i/src/callproc.c w/src/callproc.c index 4d4b86629c..10ec643861 100644 --- i/src/callproc.c +++ w/src/callproc.c @@ -328,7 +328,7 @@ DEFUN ("call-process", Fcall_process, Scall_process, 1,= MANY, 0, this case NARGS must be at least 2 and ARGS[1] is the file's name. =20 At entry, the specpdl stack top entry must be close_file_unwind (FILEFD= ). */ - +extern void child_signal_init (void); static Lisp_Object call_process (ptrdiff_t nargs, Lisp_Object *args, int filefd, specpdl_ref tempfile_index) @@ -650,7 +650,7 @@ call_process (ptrdiff_t nargs, Lisp_Object *args, int f= ilefd, =20 block_input (); block_child_signal (&oldset); - + child_signal_init (); child_errno =3D emacs_spawn (&pid, filefd, fd_output, fd_error, new_argv, env, SSDATA (current_dir), NULL, false, false, &oldset);