From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#59805: 28.2; erc-track: handle faces modified with erc-button-add-face Date: Mon, 12 Dec 2022 06:36:57 -0800 Message-ID: <87k02wwuwm.fsf__8720.69374179176$1670856139$gmane$org@neverwas.me> References: <87h6ycprpt.fsf@cern.ch> <87bkoglilv.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35167"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org, git@david.leatherman.fm, nacho.barrientos@cern.ch To: 59805@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 15:42:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4k0Q-0008tZ-Ko for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 15:42:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4jwS-0005In-8e; Mon, 12 Dec 2022 09:38:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4jwQ-0005Gb-Bq for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 09:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4jwQ-0003OK-2K for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 09:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4jwP-0007eE-TK for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 09:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 14:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59805 X-GNU-PR-Package: emacs Original-Received: via spool by 59805-submit@debbugs.gnu.org id=B59805.167085583229388 (code B ref 59805); Mon, 12 Dec 2022 14:38:01 +0000 Original-Received: (at 59805) by debbugs.gnu.org; 12 Dec 2022 14:37:12 +0000 Original-Received: from localhost ([127.0.0.1]:53378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4jvb-0007dw-P6 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 09:37:12 -0500 Original-Received: from mail-108-mta198.mxroute.com ([136.175.108.198]:41761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4jvZ-0007do-Uj for 59805@debbugs.gnu.org; Mon, 12 Dec 2022 09:37:10 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta198.mxroute.com (ZoneMTA) with ESMTPSA id 18506c483030001d7e.003 for <59805@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 12 Dec 2022 14:37:00 +0000 X-Zone-Loop: 3d2c1f89447b0101585cd47cae1c9ccf34877133321d X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ejcDj/kCJqHD0hOVYupvCGqPbqdg/+dZS3BuVSgTDCs=; b=lswB9uxBZkh9H6krijrHW3/OII kTyFAJeR2MAtdK9039JEm5hS/WJiwzrAPk6dUg+35rIaDLiX8YYtFsn9WKOjTVFaLhWmQUQJE4EdX QCj4DeELmr+0Th9wEAZhWCEAPocVAvHxK/QQkfW3DtJgxMv+O6fcchtVUKNY6YuZIK6NzhktYk4f+ lely71r8desU0VLiY9yY2e+vDPn4/SkbwlgiWiUXhwMjCWl1wNelozGlMivGEy0cXpkZ8OoPv5OTq SSe/CluJNPgUXxfuC8HB/3i+J+IRCQ5ZUaS844i0Q1WjXW3Id6rkqQTjBS+913dO4nbIMU7D0gPZx SHVdbF6w==; In-Reply-To: <87bkoglilv.fsf@neverwas.me> (J. P.'s message of "Tue, 06 Dec 2022 06:19:56 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250707 Archived-At: "J.P." writes: > Just noticed a semi-flagrant bug here (not yours). > > I'm seeing that `font-lock-default-function' (at least these days) adds > buffer-local variables to the current buffer, making this test a > polluter. To better respect the commons, we probably ought to do > something more like this: > > (ert-deftest erc-track--erc-faces-in () > [...] > (with-current-buffer (get-buffer-create "*erc-track--erc-faces-in*") > (font-lock-default-function 1) ; set buffer-local variables Yeah, this is nonsense (sorry, people). Not sure what I was smoking, but ERT runs its tests in a temporary buffer, so buffer-local stuff just evaporates.