From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Mon, 02 Jan 2023 09:27:41 +0000 Message-ID: <87k025mgky.fsf@localhost> References: <87o7ri74qv.fsf@localhost> <9bc9c69ac20a37ded741@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 10:28:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCH7F-0007sZ-ED for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 10:28:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCH6y-00027V-OS; Mon, 02 Jan 2023 04:28:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCH6x-00027H-0b for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 04:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCH6w-0005lH-PT for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 04:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCH6w-0000I4-5f for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 04:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 09:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.16726516431065 (code B ref 60467); Mon, 02 Jan 2023 09:28:02 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 2 Jan 2023 09:27:23 +0000 Original-Received: from localhost ([127.0.0.1]:42497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCH6I-0000H4-Hq for submit@debbugs.gnu.org; Mon, 02 Jan 2023 04:27:22 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:60037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCH6G-0000Gn-S1 for 60467@debbugs.gnu.org; Mon, 02 Jan 2023 04:27:21 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id F30D224026F for <60467@debbugs.gnu.org>; Mon, 2 Jan 2023 10:27:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672651635; bh=uXZUu6LDqt3UwIHYtAUXVQozcEr9mD2/SOsWcl2GCDQ=; h=From:To:Cc:Subject:Date:From; b=nI9B0N/Z1HtMQbW91wa5r6XIkOH/hWA2n10VCSx05grxBxSVCf5KBWjYKOxn6Fswo 5RTxDhNYFO5UMdTKY6BdXuQMpB+KrVZtVEzkzAQap0iKvGZ7FQQMLASkHK+aDcs5la /54r15VJvsFQgMjCdo1CuSa16FxWodjD0N9dvBc+NQzdzFHqKv6vGo608PhYG5FxGt f4NerVTmXcxHE01K4C8UbLrzUiT/eozazaekI+WGa5TaBi+u88la9pKvyZfkcnoQuw C+hz/SK8mvK/66qTwwSr6ZoIJl8wQsg8Nnpe12NLgxvDt0yD/6W6Ua2WN4gw+NsYvm 1XWla2JSAFIOw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Nlr9W3nq4z9rxM; Mon, 2 Jan 2023 10:27:11 +0100 (CET) In-Reply-To: <9bc9c69ac20a37ded741@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252316 Archived-At: Gregory Heytings writes: > The culprit is 85e0a69567 (in the Org repository), and the bug is fixed > by: > > - (combine-change-calls (point) (save-excursion (org-end-of-subtree t)) > - (org-with-limited-levels (org-map-tree 'org-promote)))) > + (org-with-limited-levels (org-map-tree 'org-promote))) > (org-fix-position-after-promote)) Unfortunately, `combine-change-calls' is there for a reason. Heading manipulation involves adding/removing stars. When done in batch, this involves drastic AST changes. `combine-change-calls' here is used to merge AST cache modifications into a single update request. It makes orders of magnitudes performance improvement in some scenarios. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at