bug#60884: 30.0.50; Compile failure - followup

bug#60884: 30.0.50; Compile failure - followup

[William C Doughty III]

[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]


With chrrent origin/master - compile results showing error:

Compilation started at Tue Jan 17 10:47:14

make -k
make actual-all || make advice-on-failure make-target=all exit-status=$?
make[1]: Entering directory '/home/n2ocm/Devel/emacs-dev/emacs'
make -C lib all
make[2]: Entering directory '/home/n2ocm/Devel/emacs-dev/emacs/lib'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/n2ocm/Devel/emacs-dev/emacs/lib'
make -C lib-src all
make[2]: Entering directory '/home/n2ocm/Devel/emacs-dev/emacs/lib-src'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/n2ocm/Devel/emacs-dev/emacs/lib-src'
make -C src BIN_DESTDIR=''/usr/local/bin/'' \
	 ELN_DESTDIR='/usr/local/lib/emacs/30.0.50/' all
make[2]: Entering directory '/home/n2ocm/Devel/emacs-dev/emacs/src'
  GEN      globals.h
  CC       dispnew.o
  CC       frame.o
  CC       xdisp.o
  CC       menu.o
  CC       xmenu.o
  CC       window.o
  CC       ccl.o
  CC       term.o
  CC       terminal.o
  CC       xfaces.o
  CC       xterm.o
xterm.c: In function 'handle_one_xevent':
xterm.c:24495:26: error: 'struct frame' has no member named 'last_tool_bar_item'; did you mean 'last_tab_bar_item'?
24495 |                   if (f->last_tool_bar_item != -1)
      |                          ^~~~~~~~~~~~~~~~~~
      |                          last_tab_bar_item
make[2]: *** [Makefile:425: xterm.o] Error 1
  CC       xfns.o
  CC       xselect.o
  CC       xrdb.o
  CC       xsmfns.o
  CC       xsettings.o
  CC       gtkutil.o


-- 

William C Doughty III 
System Programmer (Retired)
Nassau County Dept of Information Technology


[-- Attachment #2: pgp public key --]
[-- Type: application/pgp-keys, Size: 677 bytes --]

bug#60884: 30.0.50; Compile failure - followup

[Eli Zaretskii]

merge 60884 60883
thanks

> From: William C Doughty III <n2ocm@optonline.net>
> Date: Tue, 17 Jan 2023 10:52:32 -0500
> 
> With chrrent origin/master - compile results showing error:
> 
> Compilation started at Tue Jan 17 10:47:14
> 
> make -k
> make actual-all || make advice-on-failure make-target=all exit-status=$?
> make[1]: Entering directory '/home/n2ocm/Devel/emacs-dev/emacs'
> make -C lib all
> make[2]: Entering directory '/home/n2ocm/Devel/emacs-dev/emacs/lib'
> make[2]: Nothing to be done for 'all'.
> make[2]: Leaving directory '/home/n2ocm/Devel/emacs-dev/emacs/lib'
> make -C lib-src all
> make[2]: Entering directory '/home/n2ocm/Devel/emacs-dev/emacs/lib-src'
> make[2]: Nothing to be done for 'all'.
> make[2]: Leaving directory '/home/n2ocm/Devel/emacs-dev/emacs/lib-src'
> make -C src BIN_DESTDIR=''/usr/local/bin/'' \
> 	 ELN_DESTDIR='/usr/local/lib/emacs/30.0.50/' all
> make[2]: Entering directory '/home/n2ocm/Devel/emacs-dev/emacs/src'
>   GEN      globals.h
>   CC       dispnew.o
>   CC       frame.o
>   CC       xdisp.o
>   CC       menu.o
>   CC       xmenu.o
>   CC       window.o
>   CC       ccl.o
>   CC       term.o
>   CC       terminal.o
>   CC       xfaces.o
>   CC       xterm.o
> xterm.c: In function 'handle_one_xevent':
> xterm.c:24495:26: error: 'struct frame' has no member named 'last_tool_bar_item'; did you mean 'last_tab_bar_item'?
> 24495 |                   if (f->last_tool_bar_item != -1)
>       |                          ^~~~~~~~~~~~~~~~~~
>       |                          last_tab_bar_item
> make[2]: *** [Makefile:425: xterm.o] Error 1
>   CC       xfns.o
>   CC       xselect.o
>   CC       xrdb.o
>   CC       xsmfns.o
>   CC       xsettings.o
>   CC       gtkutil.o
> 

Thanks, but please don't report the same problem with different
Subject lines, because then the bug tracker creates a new issue for
each of your reports.

This should be fixed now on the master branch.

bug#60884: 30.0.50; Compile failure - followup

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> This should be fixed now on the master branch.

No further comments within 9 months, so I'm assuming the fix worked.

I'm therefore closing this bug report.