From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon Date: Mon, 13 Feb 2023 05:52:22 +0100 Message-ID: <87k00mb20p.fsf@web.de> References: <87sffab61y.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1065"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61460@debbugs.gnu.org To: Ulrich =?UTF-8?Q?M=C3=BCller?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 13 05:53:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRQqC-00006h-PA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Feb 2023 05:53:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRQps-0006rA-MP; Sun, 12 Feb 2023 23:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRQpr-0006r2-1d for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 23:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRQpq-0002P2-P3 for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 23:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRQpq-0001Hi-Dc for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 23:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Feb 2023 04:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61460 X-GNU-PR-Package: emacs Original-Received: via spool by 61460-submit@debbugs.gnu.org id=B61460.16762639714921 (code B ref 61460); Mon, 13 Feb 2023 04:53:02 +0000 Original-Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 04:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:47343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRQpf-0001HJ-8o for submit@debbugs.gnu.org; Sun, 12 Feb 2023 23:52:51 -0500 Original-Received: from mout.web.de ([212.227.15.3]:33703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRQpc-0001H1-W6 for 61460@debbugs.gnu.org; Sun, 12 Feb 2023 23:52:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676263944; bh=NrllF9C/mwJEQIEOStnBsAC1E8BSWb6B/fIIamgoclw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=lSgmB7l4VgrbeBZz6ni2Jg9ZHaKmQaaIoAl4472L1xkMKFAZKcItuCht4SafEGzcu YQD9hLfJJqX7lLkmy3Z/0GVNlZJ/I/pQPcu3cwO0KENDTW0a4CT1VzQlrMYTeDOUkO EgaPqPtgD0jVyowyV5RfnoSzW7yUdyGtLDoK1RHemirl80mUW9fV3zLd13HhASOw28 U4yxLV4HowMGxSISUUb6Sd8z2KX9BcTVr4P/JfoIQt4CN5hNLD7jaLDSpG5abgJKXw Ci74dcZ6g+kyTRrLjM3oXiLGCXVBWaK47MTZ1iOK9ujId1iMj+QC1cjUb+wbxOubtS 3mGdWqZoLeB1A== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MhWkh-1owmuR0LLf-00eaki; Mon, 13 Feb 2023 05:52:24 +0100 In-Reply-To: <87sffab61y.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Feb 2023 04:25:13 +0100") X-Provags-ID: V03:K1:iPwsMr2gR0qHViAYM3FCVth4KAXa0SG9D+otZRt9HAUPyqlLEnn AKUUD9oECBlhLA1MP3FekhCvy9IpFjfp/uvrdLbrGE5aJZZTv8qPAMl2X6IHbo6joYhT7kV rMOo6uEpuQpi7dIb8QOk/fbbEHUwkkd//Pn/xYcOhM6Fy9HP0xt5JLSVleGzLm6vptfZ65V 9iglpWKu6DmrlqKm+PafA== UI-OutboundReport: notjunk:1;M01:P0:MSLpWGX42RM=;E4zPA0tDvBBUvB0XYC83t6k0Q2j o5+bfb+VmYLN4qEFRzJceb0cXVd2h8fwOBweDQAVSW2srKcKz/vnBgkBaWU5tt/oBWJuQpkd/ 5l2diQsvhJqOYZzDHB1CvHXeWSanXYi+AbXPy1DSK35J/C8RqMOSFLzI+Z3fBscW9YkcFX+yH 1e61n8x++Z7NO9LKFCINWoOuzAWaVT331L4XnixBSaclP2zf210xxZ+WKpykLxz3ZFrDeQxye s842710tKUxnifyxRH0QxspidXNZCMvLhf4hDTkPj2S0xUq2hZlxdW4kwFy7A4AgCiz72LuNm XPhaBygcDUPqwjcQTuo6Nx/zTKX/NxqqIpHUPwL6sVkG27qxsLJ9vJHHGiNKzeOs8Syok869d B6SzDIIGw4mY+Nav9ASo4x32cUkl43QmACiJslu5R6LdI2IWrj8zQD8TED7JlVh261EA08HyZ G7S5es7FnpouOxPV1sk5JxQEq2FiqTZSVaHd5aIYOaj2O5fOUiyUGYpk+EsQVh+tfzzBDtCgA AKPw++erXT/LnTJR29CcZmJH26F/Xn09eI6gXDT8m8ISPk8y1k+7IQ42bFyWMJkHZCxkQZFER 0mBbuAuj52hnjUF4Xd4DpW4AcEcx8S0U+6UI97bsGq+sokMR26M29LwJdl9+H+tTqq0YTCwjR PTv1V4MV59hwOzhxnIiJeJlQ/FeuiE/gGB+6x2pffjH7skp5W6Pvomvslz1sczE/Cl8UiXJr4 +T3d1fXW0wj2uxkixjBEGcQBggEG6Onq9CNs39T7ha+uEveWlZBi884ot0cr2/LcLhnzjota X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255462 Archived-At: Michael Heerdegen writes: > > (phase-name (cond ((= phase 0) "Solar") > > ((= phase 2) "Lunar") > > (t "")))) > > - (cond ((< moon-lat 2.42600766e-1) > > + (cond ((string= phase-name "") > > + "") > > + ((< moon-lat 2.42600766e-1) > > (concat "** " phase-name " Eclipse **")) > > ((< moon-lat 0.37) > > (concat "** " phase-name " Eclipse possible **")) > > (1) AFAIU, the "phase name" is derived from one of four values of the > moon "phase". Is this really good enough to decide whether it is new > moon or full moon? I understand this now: That code is only ever called at the day of the start of each (quarter) moon phase, so your patch should be correct, in my opinion. > (2) https://en.wikipedia.org/wiki/Lunar_node tells that the limit for > the longitude of the moon is different for lunar vs. solar eclipses. > The same will be the case when we test the latitude. The test we > currently use doesn't reflect that. Should it? I still have that question, though. I only found values for the longitude, we test the latitude (which is available in the surrounding code, this should be no problem). But it really looks to me like those two values 0.24 and 0.37 should depend on the moon phase (or kind of eclipse respectively) instead of testing both. Michael.