From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#61350: Eglot over Tramp freezes with large project Date: Tue, 28 Feb 2023 16:01:43 +0100 Message-ID: <87k0016dgo.fsf@gmx.de> References: <87y1ootw2t.fsf@gmail.com> <69968923.705640.1677163650760@office.mailbox.org> <87a613f0b7.fsf@gmx.de> <87r0udvmzr.fsf@gmx.de> <878rglxrzm.fsf@gmail.com> <87cz5wmjbx.fsf@gmx.de> <87h6v8f7u9.fsf@gmail.com> <87o7pflfcd.fsf@gmx.de> <87wn43e9ht.fsf@gmail.com> <874jr6oont.fsf@gmx.de> <87sfeqd4zi.fsf@gmail.com> <877cw1swjm.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Thomas Koch , 61350@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 28 16:02:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX1VC-0009Jb-Je for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Feb 2023 16:02:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pX1UT-00028T-RE; Tue, 28 Feb 2023 10:02:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX1UQ-00023S-VO for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2023 10:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pX1UQ-0003UO-Gv for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2023 10:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pX1UQ-0002cx-9I for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2023 10:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Feb 2023 15:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61350 X-GNU-PR-Package: emacs Original-Received: via spool by 61350-submit@debbugs.gnu.org id=B61350.167759651310080 (code B ref 61350); Tue, 28 Feb 2023 15:02:02 +0000 Original-Received: (at 61350) by debbugs.gnu.org; 28 Feb 2023 15:01:53 +0000 Original-Received: from localhost ([127.0.0.1]:51754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX1UG-0002cV-RF for submit@debbugs.gnu.org; Tue, 28 Feb 2023 10:01:53 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:55609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX1UF-0002cI-Bh for 61350@debbugs.gnu.org; Tue, 28 Feb 2023 10:01:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1677596505; i=michael.albinus@gmx.de; bh=YXDLA9jdAp71jsMXrVJECSw9vUmMMD41knBsvKcWmVI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=F+1EF2yqhssJi+KkgrPeDjrXrHYr/mqE1BXFU/tGhhSxPAaBfW65yBrbcz3mcpgeR ipM0ydeZFREEfjgKwUTduGst74lLIGBH5WmfFi2BgX+uzjCHDRwwTIxk/kbsYD3PCv s09mhCdpixhuWuKIEH0g9YE7R4c+CQ+pV13XnJ4VjBlJtYJlz+6Q8s2PrLQjq3cC8a 83yV4mH+QF7OMlfHfwmVSrVObPkXv69yYmV6dJI7fXyM52I+d+Hx30TIXRLUkz5jWV rXkwRkzY/bcpSNMYn3UiMv6amq18CPjeKz/iH16xyIGcHsy/DCg9kRbf2jyfbh/MkM /olxil9G4hGrw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.22]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4s0t-1pVdmB3RB9-0022ng; Tue, 28 Feb 2023 16:01:44 +0100 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 28 Feb 2023 14:51:17 +0000") X-Provags-ID: V03:K1:A5X30BwW7n751+pv4G4epzA+s+n8l5UIdzSKZm/rP+JUYD2EEeF 1nICDvuehzKzZbepP3rOVHyaTGd5iCrxRFQ+r1B3WcMs7un3sMXx0hYD32M2IwihHG8Haqv lUatN2xDlDV/GNwqKAhwFk9zQVsTYhEJSRBpvlXPMZAIfGEfLYHKxFvX6n1t6zbW1M1oiMh ALnVRxnK1lTSaK6DDETAA== UI-OutboundReport: notjunk:1;M01:P0:LnzM6HZwSHU=;l0rNGqGQrg+DsZxbNHRTk1Q1PtX utUrsyjCVoqG05CqtfRr/i6c2+GpRIrvBW4hDASD4L+AEgoYk3o4xSBi4M8TmHsJe1VGlg74g g1lXDxnnDlnZ9Rm4q9KZujlccGpUUmUonoM36e7KYq9FOxeN4yDt9XkOlgx9OWeATV53Qhk0m RgalOwGzA/xE9gvIclcdhhTMrgBxuu0kHzsZJUfIlHDb3TLNf/srkk9kyu3YyYpSwdYptBj+Y lSv5z60wg9Qw8LqTqqea7wchk6K0FXJSO/4iXDYjP0cwPML1gJK6Yns6mL4SiRpuWI76JpoE1 sBhX5NlnXHN4YVHpGviA/dPLwpWmPQyPcH2iFxkliAXSHH0B36l3UVcy3VMbZUjg5HERbSSoK r3+/Wscol/7COOiyVubqEmB2Rgo8tS1/tUBUC9L4A1iRnhqauCwGHnD431JExRXOazchSv1GH 4vkhArX531eKZbi9E6umveyja9DkWMkDJIpZ5PrAcCBmB1nHC175I2t8eYEsiH/nneuBB+ZS9 cJwBBlK+jJg+DBUgxcK2k2SSZJOqHCudlXjBzUGFgf3tvv6feYoynF7DQ/6kaiDgAFGUpQBFk z+VOeXf8N7WjdfSzp7T4zTlllOZRpqKkIs+mc/1lpoqBMlPVTSg+0eKt+CjOYmm7NOwVSPZlh CQaVrK7j0xXeuWhogL/Br++DsxVIABPx3cT5q8IuU87e/RsURt4skAatuz7LFxJoqpQZxGfBZ 7MRaejl4iUa8MZq+ONB/9AmQHzMhUSIq9geFNs3/RRo94O59Sb5QjJyr+NO4g2Bt0nZ8eTBi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256978 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, > Looking at the Tramp code, I think Thomas's idea of using > > -o "ControlMaster=3Dno" -o "ControlPath=3Dnone" > > would probably be quite effective. It would work with previous > Tramp versions that Eglot users might be using. Yes, that I have also in mind. > Thomas, can you try this patch? > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index e20d209332d..83462633dd9 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -130,6 +130,8 @@ > (defvar markdown-fontify-code-blocks-natively) > (defvar company-backends) > (defvar company-tooltip-align-annotations) > +(defvar tramp-ssh-controlmaster-options) > +(defvar tramp-use-ssh-controlmaster-options) > > > > @@ -1247,7 +1249,15 @@ eglot--connect > (contact (cl-subseq contact 0 probe))) > `(:process > ,(lambda () > - (let ((default-directory default-directory)) > + (let ((default-directory default-directory) > + ;; bug#61350: Tramp turns a feature on > + ;; by default that can't (yet) handle > + ;; very much data so we turn it off > + ;; unconditionally -- just for our > + ;; process. > + (tramp-use-ssh-controlmaster-options t) > + (tramp-ssh-controlmaster-options > + "-o ControlMaster=3Dno -o ControlPath=3Dn= one")) > (make-process > :name readable-name > :command (setq server-info (eglot--cmd contac= t)) Even better than my proposal :-) There is the small risk that a user runs a local ssh client which is not aware of the ControlMaster option. For such a user, Eglot on a remote host might fail. Tramp is busy to check, whether ControlMaster could be applied. OTOH, I don't know if such ssh clients are still used in the wild, at least by Eglot users. Best regards, Michael.