From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61974: 29.0.60; customize checkbox and radio widgets don't render on macOS Date: Sun, 05 Mar 2023 16:01:10 +0800 Message-ID: <87jzzvtynt.fsf@yahoo.com> References: <10c87ff5-223f-9300-5ecd-46317fa98881@porkrind.org> <831qm3af59.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61974@debbugs.gnu.org, David Caldwell To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 05 09:02:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYjK3-0006tS-ER for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Mar 2023 09:02:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYjJl-0007vf-Pm; Sun, 05 Mar 2023 03:02:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYjJj-0007tV-05 for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 03:02:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYjJi-0001fp-CO for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 03:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYjJi-0006Hr-1S for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 03:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Mar 2023 08:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61974 X-GNU-PR-Package: emacs Original-Received: via spool by 61974-submit@debbugs.gnu.org id=B61974.167800328524116 (code B ref 61974); Sun, 05 Mar 2023 08:02:02 +0000 Original-Received: (at 61974) by debbugs.gnu.org; 5 Mar 2023 08:01:25 +0000 Original-Received: from localhost ([127.0.0.1]:38357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYjJ6-0006Gu-W0 for submit@debbugs.gnu.org; Sun, 05 Mar 2023 03:01:25 -0500 Original-Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]:36971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYjJ4-0006Gh-Vy for 61974@debbugs.gnu.org; Sun, 05 Mar 2023 03:01:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678003277; bh=wVo3Qr8BDwi3C0Jl3zQJQd2Bx6vUIyK6LToA0F+eWrw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=bGulbww5RxpPBxUOTBGHUrfFdKyyxXfPYas35h7BkM4fqQYE0MQE19uvpRddly1EHNItG+/cnhPnoE1OFplP74/Ce1pcyZ3+uapMEvQgtvx+2fZkRbup6iGckyHbcc37Qd7GCCFWLP7VwSsDOR//hapiuCanDP9s5HoK/uOtzLM2HLQ0aqdyI+vnochUb9OI1T+Ohl7y94Ku8Z0oHfg1yo76WnIWVCEYcz/+52B/+kRcmg2Qj+/7sKu4Q7dsQfLKqg3wGZ83tp6+UXzcTDXaZZca5lfDFxq538NG5ckDpjY8MxkQCTqDzSsFrNXBEopGw7LiCAwxEKwdNBFPBLomUA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678003277; bh=oPcHMlrGmDsuWjzcWZ+/N4xYbW1Syq/W4t9Mh19AmIL=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Q5y7M+43ReSsX8ZNfkifjcvwjjJC7HXADCbdaK88DfUdUzhUvkDr6FjVgMOLCIJ41SWMZP8gj3tcq0FVVNt0fvW5w9IR3ablX6eydYUb7OZGEVDoWeB+j6mEwjqWNuQieYnG76hAm/jqE2QmLf9cSbGXgoSCY4AQfDSgiGtT+yOOxEhMNm755WezMkbfiw8QCIGFLgMowqMSnMPbccX5wuIFTvdfKZNIgisH/Q6kWTwzCBID6zXLD7q1vQk2E5ioCXKRcm6CJJrv/KUkXDxZZqTkJu9h+OBaEjs/9x0ZHEqmY3wUhlg/fo/9Cj9ZgU5nveWkKjYhNnCC0c89N4TCAA== X-YMail-OSG: Ko.qZRMVM1lA55P4PnPR1KcnHZ.UBEQ0yyrWdaVWdLp1.w50.aBPniG.r7zNkbs ZhyKdFunbT6VAHNYTGhqMaq.HOG86M.7QmaGE1uPTIGUSvnPcwltGnYeOjsC5JmeTdlqw01s7mrt Bwiod32r0pCP51nW5HxMvSq7RcYsdqedtj6RjqFTir0XvZPeu8XYEOVO.kynHT09nPO6QXU_UdXk f30nfu6hHz827C91XOFfLmGanC2DR6rkBafFwxrR6GYaFMgXsuQ60gYJMxt6A1C.n6iWveF99whf _XAvKdaqa4DAVFazlyWUNex3rNlx5cK0h6eaMCSg18j4qXAm6qIuAbcqdfdLDFHH5XaVTaKoJPLI k9Gclxhi_hU2N5yx_qHw7McgDGPe98Z7EQIxlXV0NRHVw5rZ9zsOSHRcCwvaW2z6Pd2aNPTgq_8t G8FUfbprWL1e27o_F4Vgcmi5mJtZz15I8HsJoG1S2JqJmfDD_tzHl3aKKufaP5_VTDplbP.jaGiZ Z.hmvISjBRj5ah3n9m8iIC.wwzTCuw55L4xmzgRDqCupDkUp_fP9FaWsZpGWg1PqyuNYMjjnsuMp dtw6VPGWMpIxH0liYQjmSo4XR1qI.HHUAmU76JKGsiIAL9Yf4PzMQ.P1Y6kVJ0CNtQJzHIRggue9 G7_wrJS2bTAcn50Xd.Zx9yMLl7MkcKk9sOhQ.d8JX.HIlZtT4ToTb5FrAezHzoZQBjED925iZgbf Si6i40EcgzoK.iaTfscBoikeL7JJFbnnWfbOC6Wn14vMprOyQL.7Q3_Bl4pO.i5KYhquiR18Ptvu xkU9Jyziu9Zr8Kk27LRUjPubNw_VjvNMBBnosONkCb X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sun, 5 Mar 2023 08:01:17 +0000 Original-Received: by hermes--production-sg3-67c57bccff-5lh9j (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1c0518d7e4430dde57d41626ea5b0e34; Sun, 05 Mar 2023 08:01:15 +0000 (UTC) In-Reply-To: <831qm3af59.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Mar 2023 08:25:22 +0200") X-Mailer: WebService/1.1.21221 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257338 Archived-At: Eli Zaretskii writes: >> Date: Sat, 4 Mar 2023 17:35:16 -0800 >> From: David Caldwell >> >> Fails: >> >> (insert-image (find-image '((:file "checked.svg")))) >> >> Works: >> >> (insert-image (find-image '((:file "splash.svg")))) >> >> It appears to be because the checkbox and radio svgs in etc/images all >> use height="1em" and the mac native renderer doesn't like that. >> >> It works with rsvg because the emacs code that interfaces with rsvg code >> passes some extra styling info to it so that it can render that properly >> (image.c:11226 in the emacs-29 branch for me today). >> >> Unfortunately the native renderer in nsimage.m doesn't do this. I spent >> some time today trying to figure it out, but it appears that the cocoa >> apis just don't have this feature, so it would have to be done some >> other way. >> >> I can confirm this is the issue by opening "etc/images/checked.svg", >> hitting "C-c C-c" to edit, changing the "1em" to "16" and "C-c C-c"ing >> again to re-render it. It will appear with a non-percentage height. > > Does it work to use the checked.xpm image instead? If it does, > perhaps we should switch the macOS build to using the XPM images > (assuming the problem you report is common to all macOS builds, that > is). Shouldn't we disable SVG display with native image APIs instead? In general, the native image API code we have at present cannot display SVG images as well as librsvg, because it cannot know the scale at which the image will be displayed.