From: Visuwesh <visuweshm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62790@debbugs.gnu.org
Subject: bug#62790: 29.0.60; WEBP header regexp in image-type-header-regexps fails files containing newlines
Date: Wed, 12 Apr 2023 22:22:29 +0530 [thread overview]
Message-ID: <87jzyhdovm.fsf@gmail.com> (raw)
In-Reply-To: <835ya16qry.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Apr 2023 18:53:21 +0300")
[புதன் ஏப்ரல் 12, 2023] Eli Zaretskii wrote:
> merge 62790 62789
> thanks
>
>> From: Visuwesh <visuweshm@gmail.com>
>> Date: Wed, 12 Apr 2023 19:17:23 +0530
>>
>> Attached image contains a newline in the header after "RIFF" which the
>> regexp in image-type-header-regexps fails to match. This makes
>> create-image return nil for such an image when FILE-OR-DATA is DATA and
>> DATA-P is non-nil.
>
> Not sure why you filed two identical reports. Did you send the same
> email twice to the bug tracker?
It was an accident. I was having power cuts every 15 mins, it got me
and I managed to send the mail twice.
[புதன் ஏப்ரல் 12, 2023] Eli Zaretskii wrote:
>> From: Visuwesh <visuweshm@gmail.com>
>> Date: Wed, 12 Apr 2023 19:17:13 +0530
>>
>> Attached image contains a newline in the header after "RIFF" which the
>> regexp in image-type-header-regexps fails to match. This makes
>> create-image return nil for such an image when FILE-OR-DATA is DATA and
>> DATA-P is non-nil.
>
> Thanks, but please show a recipe, starting from "emacs -Q", to
> reproduce the problem with this image. I just visited it with
> "C-x C-f" and didn't see any problems.
Please evaluate
(create-image
(with-temp-buffer
(insert-file-contents-literally "/path/to/attached/image")
(buffer-string))
nil t)
in emacs -Q and observe the return value. It will return nil even
though it is a valid webp file. The reason C-x C-f succeeds is because
the file has the "webp" extension and thusly `image-supported-p' call in
`image-type' returns non-nil.
next prev parent reply other threads:[~2023-04-12 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 13:47 bug#62790: 29.0.60; WEBP header regexp in image-type-header-regexps fails files containing newlines Visuwesh
2023-04-12 15:53 ` Eli Zaretskii
2023-04-12 16:52 ` Visuwesh [this message]
2023-04-12 17:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzyhdovm.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=62790@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).