From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62734: Always fully rebuild autoloads in package-generate-autoloads Date: Sun, 30 Apr 2023 09:17:16 +0000 Message-ID: <87jzxtg25f.fsf@posteo.net> References: <87lej2oz14.fsf@le0.gs> <874jp0aw7h.fsf@posteo.net> <83pm7oqa7d.fsf@gnu.org> <87o7n7ga4x.fsf@posteo.net> <83o7n7ri64.fsf@gnu.org> <87fs8jg93g.fsf@posteo.net> <83mt2rqm57.fsf@gnu.org> <87354jnlrc.fsf@posteo.net> <83y1mbou6s.fsf@gnu.org> <874jozym0u.fsf@posteo.net> <83r0s2q3ok.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36408"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62734@debbugs.gnu.org, leo.gaskin@le0.gs To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 30 11:17:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pt3BR-0009Dw-DU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Apr 2023 11:17:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pt3B4-0000DK-01; Sun, 30 Apr 2023 05:17:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pt3B1-0000Cs-Dx for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 05:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pt3B0-0003Ox-Tp for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 05:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pt3B0-0005i8-69 for bug-gnu-emacs@gnu.org; Sun, 30 Apr 2023 05:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Apr 2023 09:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62734-submit@debbugs.gnu.org id=B62734.168284621821939 (code B ref 62734); Sun, 30 Apr 2023 09:17:02 +0000 Original-Received: (at 62734) by debbugs.gnu.org; 30 Apr 2023 09:16:58 +0000 Original-Received: from localhost ([127.0.0.1]:37186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pt3Av-0005hn-VO for submit@debbugs.gnu.org; Sun, 30 Apr 2023 05:16:58 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:57575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pt3Ar-0005hX-2U for 62734@debbugs.gnu.org; Sun, 30 Apr 2023 05:16:56 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 35188240195 for <62734@debbugs.gnu.org>; Sun, 30 Apr 2023 11:16:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682846207; bh=MAnPEiSxAhUbjydQgU+Oj5XX8jI6ydPR7BL4IYRazaA=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=XXKaoV062BeQAkmZpMcVS/wYUIrdUyTYBVCOu2FplkTMcdFVZ7HNs+pRiJXQsauaZ 3KASkxwIxNVvtWuD4G9Qx+vJocvOD9f+G0Ur0S7HDKD9pzPLKe4Cfo2iryd3Vf6WNW 8u8abV8cBZaL3yBVcIlIdPLl44fcoYer/fVnDBK/nUMGaUXAwsS7sv7h5WBufVSQb/ VNtjBG0pUzruLTfvh9iKjRJOZSKFu+55YuahpvNaRu7IqpQEFQG+e9a9tb0B7r0noJ E31dSPI7RjOpeFcpecu5etWqB93h1h6WHv6n4E3X8OvhovijI+8NesY/i092Fg8XMX FKOynciz8RRnQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q8LM02tzwz9rxM; Sun, 30 Apr 2023 11:16:44 +0200 (CEST) In-Reply-To: <83r0s2q3ok.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Apr 2023 15:21:47 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260827 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: leo.gaskin@le0.gs, 62734@debbugs.gnu.org >> Date: Sat, 29 Apr 2023 11:18:25 +0000 >> >> > "Building" is a strange term when we are talking about a Lisp package. >> >> How come? > > There's nothing to "build". Everything is already built. The idea is that this mirrors the building of a tarball on the ELPA server, but as I said, I will think about this matter. >> >> I think the central issue here is the >> >> >> >> (and (not defs) extra-data) >> >> >> >> check. Just because we did not find any new definitions to autoload >> >> /and/ EXTRA-DATA is non-nil, does not mean the old contents should be >> >> discarded. The else-case already does the right thing, so I really do >> >> think that getting rid of the `if' could resolve the issue: >> > >> > What happens if a package has no autoloads? The doc string says in >> > that case passing EXTRA-DATA will produce OUTPUT-FILE regardless. >> > Does your patch handle that? (It's hard to tell, given all the >> > whitespace changes in the patch.) >> >> It would, as the else-case of the if branch I am proposing to eliminate >> would still insert the EXTRA-DATA. > > And if EXTRA-DATA is nil, then will we generate an empty OUTPUT file? No, we still generate the right file with the right information (in this case just a `register-definition-prefixes' invocation).