From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#64619: [PATCH] Add toggle-window-dedicated command Date: Fri, 14 Jul 2023 19:42:47 +0000 Message-ID: <87jzv2p9e0.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34151"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64619@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 14 21:43:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKOhI-0008ci-5y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jul 2023 21:43:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKOgy-0007Ba-Q8; Fri, 14 Jul 2023 15:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKOgx-0007BD-04 for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 15:43:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKOgw-0005RP-OB for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 15:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKOgw-0003DR-BI for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 15:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jul 2023 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64619-submit@debbugs.gnu.org id=B64619.168936378012353 (code B ref 64619); Fri, 14 Jul 2023 19:43:02 +0000 Original-Received: (at 64619) by debbugs.gnu.org; 14 Jul 2023 19:43:00 +0000 Original-Received: from localhost ([127.0.0.1]:43548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKOgt-0003DA-IU for submit@debbugs.gnu.org; Fri, 14 Jul 2023 15:43:00 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:41389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKOgp-0003Cu-3g for 64619@debbugs.gnu.org; Fri, 14 Jul 2023 15:42:58 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BBD5F240027 for <64619@debbugs.gnu.org>; Fri, 14 Jul 2023 21:42:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689363768; bh=yQScqL5/cB+ESk62YTA31aK2fj4RxnDxFsLPR27lsew=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=mJlOAkSoUUj9LCZzcv6QX+DNhuawE57I9Uuij7J+riA/IBugR+3xipfNqTx3NT35b kSjoKURNK3doaDbyFFKdYsip1eyFAAdrzgTLxor11UFjV+TFQvr5c2lkho8BdaSf3+ 3NSBwJIK03Gt4H0jbnfTD1U1C+phTa5R3lyyebZFBLnBMTGJttFmHQCMmW26oCWvuL sY9sURQFcTD3AV1N59AFgxWSSG6gMCmC/deoJnLZkYr/bKN39vf/jApB9t0P+8SZkx ZAtj9gX1WyWtWHkhHfjLDUt9y2aWN5/xbA0ycpmccRw5crztuaTit/+sGXSMVDp+Wg QVAGGGBrQXbHQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R2hhm09Mdz6tw8; Fri, 14 Jul 2023 21:42:47 +0200 (CEST) In-Reply-To: (Spencer Baugh's message of "Fri, 14 Jul 2023 11:38:59 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265124 Archived-At: Spencer Baugh writes: > Tags: patch > > > It's sometimes useful to interactively make certain windows dedicated. > This allows a level of interactive control over which window > display-buffer uses. I think this sounds interesting, I think there is a lot that can be improved when it comes to window management. > * lisp/window.el (toggle-window-dedicated): Add. > (window-prefix-map): Add C-x w d binding. > > > In GNU Emacs 29.0.92 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo > version 1.15.12, Xaw scroll bars) of 2023-07-10 built on > igm-qws-u22796a > Repository revision: dd15432ffacbeff0291381c0109f5b1245060b1d > Repository branch: emacs-29 > Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 > System Description: CentOS Linux 7 (Core) > > Configured using: > 'configure --config-cache --with-x-toolkit=lucid > --with-gif=ifavailable' > >>>From 2e8caf7d1f0a402568fac9e8767064a452499d60 Mon Sep 17 00:00:00 2001 > From: Spencer Baugh > Date: Fri, 14 Jul 2023 11:38:24 -0400 > Subject: [PATCH] Add toggle-window-dedicated command > > It's sometimes useful to interactively make certain windows dedicated. > This allows a level of interactive control over which window > display-buffer uses. > > * lisp/window.el (toggle-window-dedicated): Add. > (window-prefix-map): Add C-x w d binding. > --- > lisp/window.el | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/lisp/window.el b/lisp/window.el > index d91bbabc010..f884d9aaf16 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -7463,6 +7463,20 @@ display-buffer-mark-dedicated > The actual non-nil value of this variable will be copied to the > `window-dedicated-p' flag.") > > +(defun toggle-window-dedicated (&optional window interactive) > + "Toggle whether WINDOW is dedicated. > + > +See `set-window-dedicated-p' for more details. WINDOW defaults > +to the currently selected window." Shouldn't "interactive" be documented as well? > + (interactive "i\np") How about (interactive (list (window-normalize-window window) t)) > + (setq window (window-normalize-window window)) > + (if (window-dedicated-p window) > + (progn > + (set-window-dedicated-p window nil) > + (when interactive (message "Window can now be used to display other buffers"))) > + (set-window-dedicated-p window 'dedicated) > + (when interactive (message "Window will now display only its current buffer")))) > + > (defconst display-buffer--action-function-custom-type > '(choice :tag "Function" > (const :tag "--" ignore) ; default for insertion > @@ -10746,6 +10760,7 @@ window-prefix-map > "2" #'split-root-window-below > "3" #'split-root-window-right > "s" #'window-toggle-side-windows > + "d" #'toggle-window-dedicated > "^ f" #'tear-off-window > "^ t" #'tab-window-detach > "-" #'fit-window-to-buffer