From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68214: Completion sorting customization by category Date: Tue, 09 Jan 2024 19:31:02 +0100 Message-ID: <87jzoiqryx.fsf@daniel-mendler.de> References: <86a5pnzst1.fsf@mail.linkov.net> <868r5630ft.fsf@mail.linkov.net> <8ebc33fb-d01f-4426-a716-69a11f6dfad1@daniel-mendler.de> <86le95m2ue.fsf@mail.linkov.net> <86sf3cjj6o.fsf@mail.linkov.net> <871qawrxh0.fsf@daniel-mendler.de> <86r0iuxu4f.fsf@mail.linkov.net> <87plye9wbz.fsf@daniel-mendler.de> <86wmslhvdk.fsf@mail.linkov.net> <87h6jpdm63.fsf@daniel-mendler.de> <86o7dul766.fsf@mail.linkov.net> <86il42l6gz.fsf@mail.linkov.net> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6782"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68214@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 19:32:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNGte-0001YV-M3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 19:32:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNGtJ-00034F-T2; Tue, 09 Jan 2024 13:31:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNGtH-00033s-Gj for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:31:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNGtH-0005ut-4u for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:31:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNGtO-0002R1-2T for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68214 X-GNU-PR-Package: emacs Original-Received: via spool by 68214-submit@debbugs.gnu.org id=B68214.17048250808512 (code B ref 68214); Tue, 09 Jan 2024 18:32:02 +0000 Original-Received: (at 68214) by debbugs.gnu.org; 9 Jan 2024 18:31:20 +0000 Original-Received: from localhost ([127.0.0.1]:40919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNGsh-0002DE-S5 for submit@debbugs.gnu.org; Tue, 09 Jan 2024 13:31:20 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:36187 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNGsf-00024F-Lz for 68214@debbugs.gnu.org; Tue, 09 Jan 2024 13:31:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=asEBl+UPKEmBOszkEHusyMvn8jCK0EuLjuE6Gudmaok=; b=W9egfAyZSDFMtiMtXfFJ0GHlP2 Ws6E792yJI6K05Y2FickPC8T5FubClbnkgVajunBZewIltiS/ChJGQD1WEk0Hu+j6sIpQhLGKK1VR hLAhuJQlZUaxeF/ES475VKew2gWUSi8oSQkVsopjO7jB77GSjBU26x6MI0rCji5UC6W0=; In-Reply-To: <86il42l6gz.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 09 Jan 2024 20:14:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277643 Archived-At: Juri Linkov writes: >> Now I tried to use a more user-friendly let-binding of >> 'completion-extra-properties' like below, but then discovered >> that it doesn't work for the category. >> >> Maybe 'completion-metadata-get' could try to get a category >> from 'completion-extra-properties' as well? > > Sorry, this was imprecise. I meant another layer of indirection: > to get a category from 'completion-extra-properties' > to be able to get 'display-sort-function' by category. Indeed. I forgot about this indirection. This should be added as well. Not sure if there a significantly easier way to write this than as follows with a separate helper function? (defun completion--metadata-get-1 (metadata prop) (or (alist-get prop metadata) (plist-get completion-extra-properties ;; Cache the keyword (or (get prop 'completion-extra-properties--keyword) (put prop 'completion-extra-properties--keyword (intern (concat ":" (symbol-name prop)))))))) (defun completion-metadata-get (metadata prop) "Get property PROP from completion METADATA. If the metadata specifies a completion category, the variables `completion-category-overrides' and `completion-category-defaults' take precedence for category-specific overrides. If the completion metadata does not specify the property, the `completion-extra-properties' plist is consulted. Note that the keys of the `completion-extra-properties' plist are keyword symbols, not plain symbols." (if-let (((not (eq prop 'category))) (cat (completion--metadata-get-1 'category metadata)) (over (completion--category-override cat prop))) (cdr over) (completion--metadata-get-1 prop metadata)))