From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode Date: Sat, 20 Jan 2024 10:46:00 +0100 Message-ID: <87jzo4ficn.fsf@daniel-mendler.de> References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> <83le8ktl9j.fsf@gnu.org> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25388"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67527@debbugs.gnu.org, Eason Huang , Eshel Yaron , simon@ecksd.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 20 10:47:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rR7wT-0006LR-38 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Jan 2024 10:47:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rR7wN-0007MN-I3; Sat, 20 Jan 2024 04:47:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR7wJ-0007M8-Ea for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 04:47:00 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rR7wJ-0001uf-6Z for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 04:46:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rR7wL-0004PB-TW for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2024 04:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Jan 2024 09:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67527 X-GNU-PR-Package: emacs Original-Received: via spool by 67527-submit@debbugs.gnu.org id=B67527.170574397714472 (code B ref 67527); Sat, 20 Jan 2024 09:47:01 +0000 Original-Received: (at 67527) by debbugs.gnu.org; 20 Jan 2024 09:46:17 +0000 Original-Received: from localhost ([127.0.0.1]:60879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7vb-0003km-Vc for submit@debbugs.gnu.org; Sat, 20 Jan 2024 04:46:16 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:50171 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rR7vX-0003ZG-D8 for 67527@debbugs.gnu.org; Sat, 20 Jan 2024 04:46:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TzBji7EoK8dgMki+It21pOjgJYvAkvuEYr5DFtDnewk=; b=yucDpjpZbvs79OCGdZDYuhZJ+w U3f0k9T1j/2qb7E/JAl5CFLH5IxUecORxv7LtCMnXCXTaFjq1S7JcAEDtwnmWzJXyqziMECZZqv0Q N6sZJYcPnEIWs8A2cPYYSjJrchMyT2mxv1T5IiR/VOyT2OtNbGWgHfDlNRzvaPGtyEP4=; In-Reply-To: <83le8ktl9j.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Jan 2024 11:19:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278584 Archived-At: Eli Zaretskii writes: >> From: Eason Huang >> Cc: 67527@debbugs.gnu.org, simon@ecksd.com >> Date: Sat, 13 Jan 2024 17:03:28 +0800 >> >> Eli Zaretskii writes: >> >> > I guess I'm confused. In your original report, which started this >> > discussion, you said: >> > >> > Because when I enable the autocomplete by corfu or company, it will >> > always popup the candidate when I input English characters. >> > I don't want to diable the autocomplete of corfu or company, because I >> > need it in org code block. >> > >> > I was asking about that part in your report -- how did the new support >> > for completion-at-point in text mode and its descendants change the >> > behavior when you enable autocomplete by corfu or company, and why >> > were you talking about disabling autocomplete of corfu and company? >> > >> >> I have `cape-elisp-block` capf backend in org-buffer, and it only >> works in code block, that's why I need the autocomplete. >> >> I also need the `flyspell-mode` in org-mode, the `flyspell-mode` will add >> ispell-completion-at-point to capf, but when I input characters in >> org-buffer, I don't need the ispell-completion-at-point backend. >> >> Anyway, the below workaround works for me: >> >> ``` >> (add-hook 'text-mode-hook >> (lambda () >> (remove-hook 'completion-at-point-functions 'ispell-completion-at-point t))) >> ``` > > Thanks. > > Eshel, given this feedback, I think it would make sense to add a new > defcustom that would make text-mode avoid adding > ispell-completion-at-point to completion-at-point-functions. Would > you please submit such a change and the documentation changes to go > with it? TIA. Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word' could be renamed and reused, taking three values? This way we avoid introducing multiple defcustoms for tweaking the same feature. - `command': Bind `ispell-complete-word' to TAB. - `capf': Add `ispell-completion-at-point' to the `completion-at-point-functions'. - `nil': None of the above. Daniel