From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#68985: [PATCH v3] Add option gnus-mode-line-logo Date: Fri, 09 Feb 2024 20:20:16 -0800 Message-ID: <87jzndympr.fsf@ericabrahamsen.net> References: <877cjg3p5k.fsf@posteo.de> <86eddnxz7e.fsf@gnu.org> <87y1bu3f1j.fsf@posteo.de> <87r0hmmvy5.fsf@ericabrahamsen.net> <87fry253r3.fsf@ledu-giraud.fr> <87il2xmrzt.fsf@ericabrahamsen.net> <877cjd73x0.fsf@ledu-giraud.fr> <87plx52t8r.fsf@posteo.de> <87r0hlkz0x.fsf@ericabrahamsen.net> <87h6ih2hnt.fsf@posteo.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33721"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Manuel Giraud , 68985-done@debbugs.gnu.org To: Mekeor Melire Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 10 05:21:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYerR-0008Zh-Jr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Feb 2024 05:21:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYerB-0006fi-3q; Fri, 09 Feb 2024 23:20:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYer9-0006f9-EN for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 23:20:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYer9-0002eZ-5q for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 23:20:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYerO-00013r-G5 for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 23:21:02 -0500 Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Feb 2024 04:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 68985 X-GNU-PR-Package: emacs Mail-Followup-To: 68985@debbugs.gnu.org, eric@ericabrahamsen.net, mekeor@posteo.de Original-Received: via spool by 68985-done@debbugs.gnu.org id=D68985.17075388444026 (code D ref 68985); Sat, 10 Feb 2024 04:21:02 +0000 Original-Received: (at 68985-done) by debbugs.gnu.org; 10 Feb 2024 04:20:44 +0000 Original-Received: from localhost ([127.0.0.1]:38548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYer5-00012s-Oy for submit@debbugs.gnu.org; Fri, 09 Feb 2024 23:20:44 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:42364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYer3-00012W-Ju for 68985-done@debbugs.gnu.org; Fri, 09 Feb 2024 23:20:42 -0500 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5FBCAFA0B2; Sat, 10 Feb 2024 04:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1707538819; bh=xbZoUF2DpOQSZyDkaVNwzMUehTmBmFYXaS1A5JOdRxc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FfkMKCBYTFRaAr2QeH4dJXYsc0aF2menUz3mVGfnFhHhDpxx7MzT86sZodg3PFLqv 9N9qP8/8ClTlVhttYgUvAGJ52pZSnZCI/3L6SoBETTIHXI85B6Ex9DHXztjJE1XYcw xbC4glB2soAXKFDJeDxjmxtLe4CyKuUyRFF+cxsw= In-Reply-To: <87h6ih2hnt.fsf@posteo.de> (Mekeor Melire's message of "Sat, 10 Feb 2024 02:03:06 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279719 Archived-At: Mekeor Melire writes: > 2024-02-09 15:18 eric@ericabrahamsen.net: > >> Looks good! You've tested this, I assume? > > Yes. > > - Tested the customize interface. > - Setting to nil works as documented. > - Setting to another image spec works as documented. > - As documented, in non-graphical displays (emacs -nw), no logo is > displayed, just like before. > - There are no byte-compilation warnings. > - There are no new checkdoc warnings. > >> I think 'gnus-visual is the right group. > > Great! > >> Custom types are always a little frustrating, but this might work >> better: >> >> '(choice >> (repeat :tag "Image specs" (plist)) >> (const :tag "No logo" nil)) > > This is great, too. Find attached another version of the patch which > uses this custom-type, repeat-(plist). Looks good! Thanks very much for the work. I've put the patch in. I'll close the bug but it also occurred to me we didn't put anything in the manual. I'll take a look at that and maybe follow up with another patch later. Thanks, Eric