bug#69312: 30.0.50; [WISHLIST] dicitionary buffer should retain search information

[No Wayman <iarchivedmywholelife@gmail.com>]

Juri Linkov <juri@linkov.net> writes:

> close 69312 30.0.50
> thanks
>
>>>> This won't work. The buffer is in read-only mode, but even if 
>>>> that is
>>>> inhibited,
>>>> the string is overwritten by the call to the display function 
>>>> at the end:
>>>
>>>> (funcall function reply)
>>>
>>> With it installed, the dictionary-do-matching command is 
>>> broken.
>>> It results in:
>>>
>>> dictionary-do-matching: Buffer is read-only: #<buffer 
>>> *Dictionary*>
>>
>> Please provide a test case to reproduce the issue that you see.
>
> Never mind, I see now what is missing.  So this is fixed now.
> Thanks for the bug report.

To clarify the issue:

(defun dictionary-do-matching (word dictionary strategy function)
  "Search for WORD with STRATEGY in DICTIONARY and display them 
  with FUNCTION."

;;This insertion is thrown away...

  (insert (format-message "Lookup matching words for `%s' in `%s' 
  using `%s'\n"
                          word dictionary strategy))

;; [OMITTED FUNCTION BODY]

;; ...when this display function is called
    (funcall function reply)))