From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69815: [PATCH] Fix some CSS issues on elpa.gnu.org Date: Sun, 17 Mar 2024 10:56:55 +0000 Message-ID: <87jzm19le0.fsf@posteo.net> References: <87sf0rpf9n.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21183"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69815@debbugs.gnu.org To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 17 11:58:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rloDH-0005Jh-8V for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Mar 2024 11:58:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rloCm-0000Hv-Jc; Sun, 17 Mar 2024 06:57:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rloCk-0000Hf-7c for bug-gnu-emacs@gnu.org; Sun, 17 Mar 2024 06:57:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rloCj-0003hB-4N for bug-gnu-emacs@gnu.org; Sun, 17 Mar 2024 06:57:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rloDK-00015O-Hn for bug-gnu-emacs@gnu.org; Sun, 17 Mar 2024 06:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Mar 2024 10:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69815 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69815-submit@debbugs.gnu.org id=B69815.17106730634150 (code B ref 69815); Sun, 17 Mar 2024 10:58:02 +0000 Original-Received: (at 69815) by debbugs.gnu.org; 17 Mar 2024 10:57:43 +0000 Original-Received: from localhost ([127.0.0.1]:57687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rloD0-00014r-Tz for submit@debbugs.gnu.org; Sun, 17 Mar 2024 06:57:43 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:37833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rloCx-00014b-RF for 69815@debbugs.gnu.org; Sun, 17 Mar 2024 06:57:41 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 25CF2240027 for <69815@debbugs.gnu.org>; Sun, 17 Mar 2024 11:56:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1710673016; bh=Nt8EnFF5Iu1oO7ReZG2isopyo3Ria/jEBrUQKnhFYOI=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=RL5epQY6L1e2lGR9H0dWUH9PEQuSqi6Yl/S2AjU2hPNHLISpytqeBLoMFNEix3a/G K1xtANAlN/Hmydqq6IO+degy8pFh9UPRg4vA4VyilDc5uxQK9iuPFlk8DCQEz8G7XJ SOOirgy/BDDOmHPxrKwAf6nvtGyq9PAEefUSK88UyV9mc2yQAUg/eKHxNnfErosCV7 oZz7a72wMIJqfPoCyVoKVqFnzqW0K8otvtyHSsgVuK1bs+rUYapCKW/+Kfd/2+fqlz 6/UchfHQZS9YkelWtuqPa5VCotRd3pTMpqIpW+1A7WzvZjDfVQovNZ95CDrncapFGD saFWVlnWHxotw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TyFKz4S5Pz6txc; Sun, 17 Mar 2024 11:56:55 +0100 (CET) In-Reply-To: <87sf0rpf9n.fsf@pub.pink> (john muhl's message of "Fri, 15 Mar 2024 12:37:56 -0500") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281759 Archived-At: john muhl writes: > Here are a few patches fixing some minor issues. The first one > makes the packages table always full-width and expands the footer > background so it contains all the footer text (see before.png). > > I noticed that with a very narrow view the CSS drops the rank > column to help fit but it doesn=E2=80=99t help quite enough to prevent > horizontal overflow (narrow.png). It seems to me that the version > column is the least important so the second patch changes the > narrow view to drop it instead of the rank (after.png). > > The last patch fixes the doctype for sub-pages. PUBLIC> is not a valid doctype and so triggers quirks mode. Not a > big deal but probably better avoided. > >>>From f13cc711f0bf368f9acb1ae579ab9e078aefce1e Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Thu, 14 Mar 2024 13:22:52 -0500 > Subject: [PATCH] Fix some CSS issues > > * html/layout.css (footer): Remove fixed height so the background > expands to encompass all footer content. > (table): Make packages table always use full page width. > --- > html/layout.css | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/html/layout.css b/html/layout.css > index 7d3be41..9d04958 100644 > --- a/html/layout.css > +++ b/html/layout.css > @@ -1,4 +1,4 @@ > -l/* Copyright (C) 2010-2022, 2024 Free Software Foundation, Inc. > +/* Copyright (C) 2010-2022, 2024 Free Software Foundation, Inc. >=20=20 > This file is free software: you can redistribute it and/or modify > it under the terms of the GNU General Public License as published by > @@ -74,7 +74,7 @@ html, body { > height: 100%; > margin: 0 auto -50px; /* the bottom margin is the negative value of th= e footer's height */ > } > -footer, .push, .footer { > +.push { > height: 90px; /* .push must be the same height as .footer */ > } >=20=20 > @@ -302,6 +302,10 @@ footer p, .footer p { > line-height: 1.4em; > } >=20=20 > +table { > + width: 100%; > +} > + > @media screen and (max-width: 999px) { > .container { > width: 600px; > @@ -313,10 +317,6 @@ footer p, .footer p { > font-size: 1em; > } >=20=20 > - table { > - width: 100%; > - } > -=20=20 > .container { > width: 90%; > padding: 40px 5%; > --=20 > 2.41.0 Looks good. > >>>From 5dafd0d3483336ff50b5039942bc35c41d30644f Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Thu, 14 Mar 2024 13:46:54 -0500 > Subject: [PATCH] Show rank instead of version on narrow displays > > * html/layout.css (td): > (th): Hide version and right align rank column. > --- > html/layout.css | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/html/layout.css b/html/layout.css > index 9d04958..02dfb87 100644 > --- a/html/layout.css > +++ b/html/layout.css > @@ -283,6 +283,11 @@ td { > border-bottom: 1px solid #ddd; > } >=20=20 > +td:last-child, > +th:last-child { > + text-align: right; > +} > + > footer, .footer { > border-top: 1px solid #999; > text-align:center; > @@ -330,7 +335,7 @@ table { > width: 300px; > } >=20=20 > - td:last-child, th:last-child { > + td:nth-child(2), th:nth-child(2) { > display: none; > } >=20=20 > --=20 > 2.41.0 Why not show both, and allow scrolling horizontally (x-overflow: auto) if there is not enough space? > > >>>From 16547922cc9339e4f920ae62a1bee09c38625cbf Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Thu, 14 Mar 2024 16:54:45 -0500 > Subject: [PATCH] * elpa-admin.el (elpaa--html-header): Fix DOCTYPE. > > --- > elpa-admin.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/elpa-admin.el b/elpa-admin.el > index d4a9dcf..9475336 100644 > --- a/elpa-admin.el > +++ b/elpa-admin.el > @@ -1544,7 +1544,7 @@ readme file has an unconventional name" > ;;; Make the HTML pages for online browsing. >=20=20 > (defun elpaa--html-header (title &optional header head-extra) > - (format " > + (format " What difference does this make? Or rather how is this related to the other patches? That should be explained in the commit message. > > > %s --=20 Philip Kaludercic on peregrine