From: Thierry Volpiatto <thievol@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: thievol@posteo.net, christopher@librehacker.com,
70725@debbugs.gnu.org, schwab@linux-m68k.org,
Juri Linkov <juri@linkov.net>
Subject: bug#70725: 29.3; dired-do-touch completion
Date: Sat, 18 May 2024 15:46:41 +0000 [thread overview]
Message-ID: <87jzjrt95q.fsf@posteo.net> (raw)
In-Reply-To: <86seyfecil.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 May 2024 11:43:14 +0300")
[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Juri Linkov <juri@linkov.net>
>> Cc: Andreas Schwab <schwab@linux-m68k.org>, christopher@librehacker.com,
>> Eli Zaretskii <eliz@gnu.org>, 70725@debbugs.gnu.org
>> Date: Tue, 07 May 2024 19:48:54 +0300
>>
>> > However this doesn't explain why dired-do-touch uses a completing-read
>>
>> Indeed, this was an oversight. Here is the patch
>> that replaces 'completing-read' with 'read-string':
>
> Thierry, is this solution okay with you?
This fix one issue, but default is still wrong IMHO:
When pressing RET with an empty prompt the value is different than what
is inserted in minibuffer with M-n. Why do we bother setting the
timesamp at the exact time when pressing RET instead of when pressing
"T", I mean user would consider the timestamp is set once "T" is
pressed, with this the behavior would be consistent with RET and M-n and
the code much simpler.
>> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
>> index a2ce3083cfe..f3343b9b637 100644
>> --- a/lisp/dired-aux.el
>> +++ b/lisp/dired-aux.el
>> @@ -658,10 +658,13 @@ dired-mark-read-string
>>
>> Optional arg COLLECTION is a collection of possible completions,
>> passed as the second arg to `completing-read'."
>> - (dired-mark-pop-up nil op-symbol files
>> - 'completing-read
>> - (format prompt (dired-mark-prompt arg files))
>> - collection nil nil initial nil default-value nil))
>> + (apply #'dired-mark-pop-up
>> + nil op-symbol files
>> + (if (eq op-symbol 'touch) 'read-string 'completing-read)
>> + (format prompt (dired-mark-prompt arg files))
>> + (if (eq op-symbol 'touch)
>> + `(,initial nil ,default-value nil)
>> + `(,collection nil nil ,initial nil ,default-value nil))))
>>
>> \f
>> ;;; Cleaning a directory: flagging some backups for deletion
--
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 686 bytes --]
next prev parent reply other threads:[~2024-05-18 15:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 19:51 bug#70725: 29.3; dired-do-touch completion Christopher Howard
2024-05-03 4:55 ` Thierry Volpiatto
2024-05-03 6:13 ` Eli Zaretskii
2024-05-03 7:10 ` Thierry Volpiatto
2024-05-04 11:43 ` Eli Zaretskii
2024-05-04 12:31 ` Thierry Volpiatto
2024-05-05 6:46 ` Juri Linkov
2024-05-06 5:40 ` Thierry Volpiatto
2024-05-06 6:50 ` Juri Linkov
2024-05-06 10:18 ` Thierry Volpiatto
2024-05-06 11:35 ` Andreas Schwab
2024-05-06 12:25 ` Thierry Volpiatto
2024-05-07 16:48 ` Juri Linkov
2024-05-18 8:43 ` Eli Zaretskii
2024-05-18 15:46 ` Thierry Volpiatto [this message]
2024-05-21 6:20 ` Juri Linkov
2024-05-21 13:04 ` Thierry Volpiatto
2024-05-21 14:33 ` Thierry Volpiatto
2024-05-21 17:22 ` Juri Linkov
2024-05-21 20:11 ` Thierry Volpiatto
2024-05-22 4:31 ` Thierry Volpiatto
2024-05-22 6:06 ` Juri Linkov
2024-05-22 17:10 ` Thierry Volpiatto
2024-05-23 15:42 ` Thierry Volpiatto
2024-05-21 16:16 ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzjrt95q.fsf@posteo.net \
--to=thievol@posteo.net \
--cc=70725@debbugs.gnu.org \
--cc=christopher@librehacker.com \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).