From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69410: 30.0.50; [WISHLIST] Use-package: allow :ensure to accept package spec instead of separate :vc keyword Date: Sun, 30 Jun 2024 10:42:18 +0000 Message-ID: <87jzi6lnjp.fsf@posteo.net> References: <87wmqryzv2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38184"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Tony Zorman , 69410@debbugs.gnu.org To: No Wayman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 30 12:43:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNs1j-0009jL-VP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jun 2024 12:43:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNs1Q-0005it-7y; Sun, 30 Jun 2024 06:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNs1O-0005iO-7w for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 06:43:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNs1N-0001HO-WB for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 06:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNs1N-0001fm-Pn for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 06:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2024 10:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69410 X-GNU-PR-Package: emacs Original-Received: via spool by 69410-submit@debbugs.gnu.org id=B69410.17197441476372 (code B ref 69410); Sun, 30 Jun 2024 10:43:01 +0000 Original-Received: (at 69410) by debbugs.gnu.org; 30 Jun 2024 10:42:27 +0000 Original-Received: from localhost ([127.0.0.1]:55226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNs0p-0001eh-5S for submit@debbugs.gnu.org; Sun, 30 Jun 2024 06:42:27 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:37739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNs0n-0001eB-Lx for 69410@debbugs.gnu.org; Sun, 30 Jun 2024 06:42:26 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0C652240105 for <69410@debbugs.gnu.org>; Sun, 30 Jun 2024 12:42:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1719744140; bh=QiIPUWPykJDmfszyM7jJr/cJpzAWr0K5Jeonma94oYI=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=I8cleJ2o+ZC8YCS4D7Ex0NFjzIRQ44/DYW0+s17RVb4krjBYWGYuQN0cBuKRFqjuN 2NSdEQrS2uvU2hgjofKyj6WWmIrXzdFo+/IopDGPzd06GLmAOs7jDDO8BuGA9X5RRA Uvp5mRGUDFiJICyF6WOFn4OERFHbUdhyL7+R9YY9gilfG3ZQ0a5eeDNuggW23FqwnG HvweJmoX8rmnEaqsqWMYDIo/bg0uW0wYWGuY3Y28KmRFzFN5B1xCzgR89IXOulax8d nMMGGpO38fsK4282DUoFSJplHvm7sctu9d672yK7nlOpHkSnndY6HP0IdzAL8/jWIw WxQZaRsnaTgSw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WBm2g36yjz6tsg; Sun, 30 Jun 2024 12:42:19 +0200 (CEST) In-Reply-To: <87wmqryzv2.fsf@gmail.com> (No Wayman's message of "Mon, 26 Feb 2024 11:06:09 -0500") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288186 Archived-At: No Wayman writes: > I think it would be cleaner to allow use-package's :ensure keyword to > accept the arguments the :vc keyword currently does. e.g. > > ;; Install EXAMPLE package from ELPA archive > (use-package example :ensure t) > > ;; Install EXAMPLE package from source > (use-package example :ensure (:url > "https://www.forge.com/maintainer/example")) > > My reasoning is that this has greater potential to work across > multiple package managers. > Instead of each package manager adding their own use-package keyword > (e.g. :vc, :straight, :elpaca), they can all interpret the :ensure > keyword's value. It would make things simpler for package maintainers > offering example declarations and users switching between package > managers. I am adding Tony to the CCs, as he implemented the :vc keyword to see if he has anything to comment (generally it is good to add a X-Debbugs-CC header, mentioning specific maintainers or people involved in a feature when submitting a bug). My own take is that setting aside timing issues and the fact that the Emacs 30 branch has been cut, ... - The :vc keyword allows just passing t to download the package as specified in the ELPA archive. I don't see an elegant away to allow this using :ensure. - I am not a fan of encouraging the usage of VC packages, since version control brings in some complications that tarballs avoid (especially when it comes to upgrading). - If I try to evaluate the expression you suggest I get a warning: =E2=9B=94 Error (use-package): Failed to parse package example: use-package: :ensure wants an optional package name (an unquoted symbol name), or ( :pin ) and I am wondering, if there is a potentially ambiguous conflict between your suggestion and the ( :pin ) case, that might trigger an edge case in some configuration. > Thoughts?=20 --=20 Philip Kaludercic on peregrine