bug#71998: 31.0.50; Typescript grammar v0.21.2 causes test failure

[john muhl <jm@pub.pink>]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Theodor Thornhill <theo@thornhill.no> writes:

> I now synced to latest master, and I can no longer reproduce this. John,
> do you still see an issue after syncing with master?

I have been testing the emacs-30 branch and still see it there as
of 68615a38669.

On master (ccb856189f4) there are segfaults running the tests for
typescript, c, java and ruby -ts-modes caused by 1abf3bdd7ed.

With that reverted I get the same test failure as on emacs-30.


[-- Attachment #2: typescript-ts-mode-tests.log --]
[-- Type: text/plain, Size: 2308 bytes --]

Running 1 tests (2024-07-21 11:55:33-0500, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
Test typescript-ts-mode-test-indentation backtrace:
  signal(ert-test-failed (("Mismatch in test \"JSX indentation\", file
  ert-fail(("Mismatch in test \"JSX indentation\", file /home/build/em
  ert-test--erts-test(((code lambda nil (setq indent-tabs-mode nil) (s
  ert-test-erts-file("/home/build/emacs-build/src-minimal/test/lisp/pr
  #f(compiled-function () #<bytecode 0x14a5cebb>)()
  #f(compiled-function () #<bytecode 0x11e6b718>)()
  handler-bind-1(#f(compiled-function () #<bytecode 0x11e6b718>) (erro
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name typescript-ts-mode-test-indentation :
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test typescript-ts-mode-test-indentation condition:
    (ert-test-failed
     ("Mismatch in test \"JSX indentation\", file /home/build/emacs-build/src-minimal/test/lisp/progmodes/typescript-ts-mode-resources/indent.erts"
      #("const foo = (props) => {\n  return (\n    <div>\n    <div>\n    <div>\n    <div>\n    {\n      props.foo\n\11? Hello, foo!\n\11: Hello, World!;\n    }\n    </div>\n    </div>\n    </div>\n    </div>\n  );\n}\n"
	40 41 (syntax-table (15)) 179 180 (syntax-table (15)))
      "const foo = (props) => {\n  return (\n    <div>\n      <div>\n        <div>\n          <div>\n            {\n              props.foo\n                ? Hello, foo!\n                : Hello, World!;\n            }\n          </div>\n        </div>\n      </div>\n    </div>\n  );\n}\n"))
   FAILED  1/1  typescript-ts-mode-test-indentation (0.503101 sec) at lisp/progmodes/typescript-ts-mode-tests.el:26

Ran 1 tests, 0 results as expected, 1 unexpected (2024-07-21 11:55:33-0500, 0.690149 sec)

1 unexpected results:
   FAILED  typescript-ts-mode-test-indentation