bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Sébastien Gendre]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

Hello,

I got a bug when I try to yank a screenshot made with Gnome-shell into
an org-mode buffer.

From the reply I get on the Org-mode mailing list, the bug come from
Emacs itself.


What I do:

* From the system menu of Gnome-shell, I choose the action to take a
  screenshot

* I took a screenshot from a selected zone, confirm the screenshot and
  got a notification message telling me "You can past the screenshot
  from the clipboard"

* On an Org-mode document, I place the point where I want to past the
  screenshot and call the Emacs function "yank-media"


What I get:

* In the mini-buffer, I get the error message:
  "Wrong type argument: sequencep, image/png"

* If I go into the "*Messages*" buffer, the full error message is:
  "seq-do: Wrong type argument: sequencep, image/png"

* If I enable debug-on-error, here is the full backtrace:

Debugger entered--Lisp error: (wrong-type-argument sequencep image/png)
  mapc(#f(compiled-function (elt) #<bytecode 0x1ebc9d0d6093f55d>) image/png)
  seq-do(#f(compiled-function (elt) #<bytecode 0x1ebc9d0d6093f55d>) image/png)
  #f(compiled-function #'sequence #<bytecode 0x19945316743f723a>)(#f(compiled-function (elt) #<bytecode 0x94038afefa059ab>) image/png)
  apply(#f(compiled-function #'sequence #<bytecode 0x19945316743f723a>) #f(compiled-function (elt) #<bytecode 0x94038afefa059ab>) image/png nil)
  seq-map(#f(compiled-function (elt) #<bytecode 0x94038afefa059ab>) image/png)
  seq-filter(#f(compiled-function (type) #<bytecode 0x17bbb7cb3b4b0c6d>) image/png)
  yank-media--find-matching-media("x/special-\\(?:gnome|KDE|mate\\)-files")
  yank-media()
  funcall-interactively(yank-media)
  command-execute(yank-media record)
  execute-extended-command(nil "yank-media" "yank")
  funcall-interactively(execute-extended-command nil "yank-media" "yank")
  command-execute(execute-extended-command)


What I expected:

* The image present in the clipboard is attached to the org-mode heading
  and a link to this attachment is created under the point


Versions:

* Org-mode: 9.7.2

* Emacs: 29.4

* Gnome-shell: 46.3.1


Best regards

-------
Gendre Sébastien

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 23 Jul 2024 12:57:36 +0200, Sébastien Gendre <seb@k-7.ch> said:

    Sébastien> Hello,
    Sébastien> I got a bug when I try to yank a screenshot made with Gnome-shell into
    Sébastien> an org-mode buffer.

    Sébastien> From the reply I get on the Org-mode mailing list, the bug come from
    Sébastien> Emacs itself.


    Sébastien> What I do:

    Sébastien> * From the system menu of Gnome-shell, I choose the action to take a
    Sébastien>   screenshot

    Sébastien> * I took a screenshot from a selected zone, confirm the screenshot and
    Sébastien>   got a notification message telling me "You can past the screenshot
    Sébastien>   from the clipboard"

    Sébastien> * On an Org-mode document, I place the point where I want to past the
    Sébastien>   screenshot and call the Emacs function "yank-media"

If instead of running `yank-media' at this point, what happens if you
evaluate:

   (gui-get-selection 'CLIPBOARD 'TARGETS)

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Eli Zaretskii]

> Cc: 72254@debbugs.gnu.org
> From: Robert Pluim <rpluim@gmail.com>
> Date: Tue, 23 Jul 2024 13:21:36 +0200
> 
> >>>>> On Tue, 23 Jul 2024 12:57:36 +0200, Sébastien Gendre <seb@k-7.ch> said:
> 
>     Sébastien> Hello,
>     Sébastien> I got a bug when I try to yank a screenshot made with Gnome-shell into
>     Sébastien> an org-mode buffer.
> 
>     Sébastien> From the reply I get on the Org-mode mailing list, the bug come from
>     Sébastien> Emacs itself.
> 
> 
>     Sébastien> What I do:
> 
>     Sébastien> * From the system menu of Gnome-shell, I choose the action to take a
>     Sébastien>   screenshot
> 
>     Sébastien> * I took a screenshot from a selected zone, confirm the screenshot and
>     Sébastien>   got a notification message telling me "You can past the screenshot
>     Sébastien>   from the clipboard"
> 
>     Sébastien> * On an Org-mode document, I place the point where I want to past the
>     Sébastien>   screenshot and call the Emacs function "yank-media"
> 
> If instead of running `yank-media' at this point, what happens if you
> evaluate:
> 
>    (gui-get-selection 'CLIPBOARD 'TARGETS)

In addition, please show the value of yank-media--registered-handlers
at this point.

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 23 Jul 2024 14:03:49 +0200, Sébastien Gendre <seb@k-7.ch> said:

    Sébastien> Robert Pluim <rpluim@gmail.com> writes:
    >> If instead of running `yank-media' at this point, what happens if you
    >> evaluate:
    >> 
    >> (gui-get-selection 'CLIPBOARD 'TARGETS)

    Sébastien> If I evaluate this, I get the result:

    Sébastien> image/png

Hmm, thatʼs supposed to be a vector, not a symbol. Could you try the
following patch and see if it improves things?

diff --git a/lisp/term/x-win.el b/lisp/term/x-win.el
index ced2750202b..cc952672580 100644
--- a/lisp/term/x-win.el
+++ b/lisp/term/x-win.el
@@ -1370,6 +1370,16 @@ gui-backend-get-selection
   (x-get-selection-internal selection-symbol target-type
                             time-stamp terminal))
 
+(cl-defmethod gui-backend-get-selection ((selection-symbol (eql 'CLIPBOARD))
+                                         (target-type (eql 'TARGETS))
+                                         &context (window-system x)
+                                         &optional time-stamp terminal)
+  (let ((sel (x-get-selection-internal selection-symbol target-type
+                                       time-stamp terminal)))
+    (if (vectorp sel)
+        sel
+      (vector sel))))
+
 ;; Initiate drag and drop
 (add-hook 'after-make-frame-functions 'x-dnd-init-frame)
 (define-key special-event-map [drag-n-drop] 'x-dnd-handle-drag-n-drop-event)


Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 23 Jul 2024 14:33:07 +0200, Sébastien Gendre <seb@k-7.ch> said:

    Sébastien> I have evaluate the added method, but when I evaluate (gui-get-selection
    Sébastien> 'CLIPBOARD 'TARGETS) I still get the result:

How did you evaluate the `cl-defmethod'? I tested with 'C-x C-e' after
the form.

Maybe visiting yank-media.el and doing 'M-x eval-buffer' will help.

    Sébastien> image/png

    Sébastien> And when I run the command yank-media, I have this traceback:

    Sébastien> Debugger entered--Lisp error: (wrong-type-argument sequencep image/png)
    Sébastien>   mapc(#f(compiled-function (elt) #<bytecode 0x1ebc9d0d6093f55d>) image/png)
    Sébastien>   seq-do(#f(compiled-function (elt) #<bytecode 0x1ebc9d0d6093f55d>) image/png)
    Sébastien>   #f(compiled-function #'sequence #<bytecode 0x19945316743f723a>)(#f(compiled-function (elt) #<bytecode 0x94038b48f0aa5ab>) image/png)
    Sébastien>   apply(#f(compiled-function #'sequence #<bytecode
    0x19945316743f723a> ) #f(compiled-function (elt) #<bytecode
    0x94038b48f0aa5ab> ) image/png nil)
    Sébastien>   seq-map(#f(compiled-function (elt) #<bytecode 0x94038b48f0aa5ab>) image/png)
    Sébastien>   seq-filter(#f(compiled-function (type) #<bytecode 0x17bbb7cb3b4b0c6d>) image/png)
    Sébastien>   yank-media--find-matching-media("x/special-\\(?:gnome|KDE|mate\\)-files")
    Sébastien>   yank-media()
    Sébastien>   funcall-interactively(yank-media)
    Sébastien>   command-execute(yank-media record)
    Sébastien>   execute-extended-command(nil "yank-media" "yank")
    Sébastien>   funcall-interactively(execute-extended-command nil "yank-media" "yank")
    Sébastien>   command-execute(execute-extended-command)

Yes, itʼs still using the old `gui-get-selection'.

Maye you need to rebuild emacs with the patch.

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 23 Jul 2024 15:04:07 +0200, Sébastien Gendre <seb@k-7.ch> said:

    Sébastien> Robert Pluim <rpluim@gmail.com> writes:
    >> How did you evaluate the `cl-defmethod'? I tested with 'C-x C-e' after
    >> the form.
    >> 
    >> Maybe visiting yank-media.el and doing 'M-x eval-buffer' will help.

    Sébastien> If I visit yank-media.el and eval the buffer, calling (gui-get-selection
    Sébastien> 'CLIPBOARD 'TARGETS) inside my org-mode buffer after doing a screenshot
    Sébastien> give me the same result.

    Sébastien> I evaluated the `cl-defmethod` by coping it inside the *Scratch* buffer
    Sébastien> and evaluate it with key binding `C-x C-e`.

Thatʼs exactly what I do, so I donʼt understand why itʼs not working
for you. What about if you replace the body of the `cl-defmethod' with
something like

(message "Hello world!")

and evaluate it, does that make any difference?

    Sébastien> I have installed Emacs on my system with the distribution package
    Sébastien> manager. So, modifying lisp/term/x-win.el.gz will result in conflict
    Sébastien> with the package manager.

    Sébastien> Robert Pluim <rpluim@gmail.com> writes:
    >> Maye you need to rebuild emacs with the patch.

    Sébastien> I have never built Emacs from the sources code. I ignore the compilation
    Sébastien> flags used by my distribution.

OK. Weʼll work on that later if we have to.

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 23 Jul 2024 15:16:15 +0200, Sébastien Gendre <seb@k-7.ch> said:

    Sébastien> If I evaluate this:

    Sébastien> (cl-defmethod gui-backend-get-selection ((selection-symbol (eql 'CLIPBOARD))
    Sébastien>                                          (target-type (eql 'TARGETS))
    Sébastien>                                          &context (window-system x)
    Sébastien>                                          &optional time-stamp terminal)
    Sébastien>   (message "Hello World!"))


    Sébastien> And then take an screenshot and evaluate (gui-get-selection 'CLIPBOARD
    Sébastien> 'TARGETS) from an org-mode buffer, I still get the same result: image/png

OK. Which Linux distribution is this?

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Visuwesh]

[செவ்வாய் ஜூலை 23, 2024] Robert Pluim wrote:

>>>>>> On Tue, 23 Jul 2024 15:16:15 +0200, Sébastien Gendre <seb@k-7.ch> said:
>
>     Sébastien> If I evaluate this:
>
>     Sébastien> (cl-defmethod gui-backend-get-selection ((selection-symbol (eql 'CLIPBOARD))
>     Sébastien>                                          (target-type (eql 'TARGETS))
>     Sébastien>                                          &context (window-system x)
>     Sébastien>                                          &optional time-stamp terminal)
>     Sébastien>   (message "Hello World!"))
>
>
>     Sébastien> And then take an screenshot and evaluate (gui-get-selection 'CLIPBOARD
>     Sébastien> 'TARGETS) from an org-mode buffer, I still get the same result: image/png
>
> OK. Which Linux distribution is this?
>
> Robert

Hearing that OP uses GNOME, are we sure OP is not running the PGTK port?
If that is the case, AFAIU context will not be x?

FWIW, I tried copying an image to clipboard and the gui-get-selection
above returns [TARGETS image/png] in a PGTK build of the emacs-30
branch.

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 23 Jul 2024 18:41:58 +0200, Sébastien Gendre <seb@k-7.ch> said:

    Sébastien> Yes, the Emacs version in Fedora repo is PGTK. And I use Wayland.

Ah, that would have been good to know from the beginning.

    Sébastien> But if I copy an image to clipboard from Firefox, I can past it into an
    Sébastien> org-mode buffer with `yank-media`.

Try this `cl-defmethod' instead.

diff --git a/lisp/term/pgtk-win.el b/lisp/term/pgtk-win.el
index 505174048f6..d0dbf11cc48 100644
--- a/lisp/term/pgtk-win.el
+++ b/lisp/term/pgtk-win.el
@@ -140,6 +140,15 @@ gui-backend-get-selection
                                          &context (window-system pgtk))
   (pgtk-get-selection-internal selection-symbol target-type))
 
+(cl-defmethod gui-backend-get-selection ((selection-symbol (eql 'CLIPBOARD))
+                                         (target-type (eql 'TARGETS))
+                                         &context (window-system pgtk))
+  (let ((sel (pgtk-get-selection-internal selection-symbol target-type
+                                          time-stamp terminal)))
+    (if (vectorp sel)
+        sel
+      (vector sel))))
+
 
 (defvar pgtk-preedit-overlay nil)
 


Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 23 Jul 2024 19:16:23 +0200, Sébastien Gendre <seb@k-7.ch> said:

    Sébastien> If I evaluate this `cl-defmethod', and then evaluate (gui-get-selection
    Sébastien> 'CLIPBOARD 'TARGETS) from an Org-mode buffer after taking an screenshot,
    Sébastien> I get this error:

My bad. Try this instead:

diff --git a/lisp/term/pgtk-win.el b/lisp/term/pgtk-win.el
index 505174048f6..06f962ff714 100644
--- a/lisp/term/pgtk-win.el
+++ b/lisp/term/pgtk-win.el
@@ -140,6 +140,14 @@ gui-backend-get-selection
                                          &context (window-system pgtk))
   (pgtk-get-selection-internal selection-symbol target-type))
 
+(cl-defmethod gui-backend-get-selection ((selection-symbol (eql 'CLIPBOARD))
+                                         (target-type (eql 'TARGETS))
+                                         &context (window-system pgtk))
+  (let ((sel (pgtk-get-selection-internal selection-symbol target-type)))
+    (if (vectorp sel)
+        sel
+      (vector sel))))
+
 
 (defvar pgtk-preedit-overlay nil)
 

Po Lu, is this the right level to fix this? Or should we handle
'CLIPBOARD + 'TARGETS specially in `pgtk-get-selection-internal'? (And
maybe we should add "&optional time_stamp terminal" to the
`cl-defmethods' in pgtk-win.el)

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Tue, 23 Jul 2024 19:16:23 +0200, Sébastien Gendre <seb@k-7.ch> said:
>
>     Sébastien> If I evaluate this `cl-defmethod', and then evaluate (gui-get-selection
>     Sébastien> 'CLIPBOARD 'TARGETS) from an Org-mode buffer after taking an screenshot,
>     Sébastien> I get this error:
>
> My bad. Try this instead:
>
> diff --git a/lisp/term/pgtk-win.el b/lisp/term/pgtk-win.el
> index 505174048f6..06f962ff714 100644
> --- a/lisp/term/pgtk-win.el
> +++ b/lisp/term/pgtk-win.el
> @@ -140,6 +140,14 @@ gui-backend-get-selection
>                                           &context (window-system pgtk))
>    (pgtk-get-selection-internal selection-symbol target-type))
>  
> +(cl-defmethod gui-backend-get-selection ((selection-symbol (eql 'CLIPBOARD))
> +                                         (target-type (eql 'TARGETS))
> +                                         &context (window-system pgtk))
> +  (let ((sel (pgtk-get-selection-internal selection-symbol target-type)))
> +    (if (vectorp sel)
> +        sel
> +      (vector sel))))
> +
>  
>  (defvar pgtk-preedit-overlay nil)
>  
>
> Po Lu, is this the right level to fix this? Or should we handle
> 'CLIPBOARD + 'TARGETS specially in `pgtk-get-selection-internal'? (And
> maybe we should add "&optional time_stamp terminal" to the
> `cl-defmethods' in pgtk-win.el)

I would prefer to treat this as a bug in GTK by installing a workaround,
perhaps in the spirit of:

diff --git a/src/pgtkselect.c b/src/pgtkselect.c
index c9f117126b2..0535482b8de 100644
--- a/src/pgtkselect.c
+++ b/src/pgtkselect.c
@@ -1644,10 +1644,24 @@ DEFUN ("pgtk-get-selection-internal", Fpgtk_get_selection_internal,
 
   if (NILP (val) && FRAME_LIVE_P (f))
     {
-      Lisp_Object frame;
+      Lisp_Object frame, val;
       XSETFRAME (frame, f);
-      return pgtk_get_foreign_selection (selection_symbol, target_type,
-					 time_stamp, frame);
+
+      val = pgtk_get_foreign_selection (selection_symbol, target_type,
+					time_stamp, frame);
+
+      /* A window property holding just one item is indistinguishable
+	 from an array of one element, and is always decoded as the
+	 former, producing issues with programs that expect the TARGETS
+	 property always to return vectors, even when the toolkit
+	 reports just one data type.  Though X sidesteps this ambiguity
+	 by defining TARGETS as returning at least two properties
+	 TARGETS and MULTIPLE, GTK knows no such scruples, and therefore
+	 symbol values (or nil) should be enclosed in vectors when
+	 TARGETS is being requested.  (bug#72254) */
+      if (EQ (target_type, QTARGETS) && (NILP (val) || SYMBOLP (val)))
+	val = make_vector (NILP (val) ? 0 : 1, &val);
+      return val;
     }
 
   if (CONSP (val) && SYMBOLP (XCAR (val)))

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Wed, 24 Jul 2024 17:29:54 +0800, Po Lu <luangruo@yahoo.com> said:

    Po Lu> I would prefer to treat this as a bug in GTK by installing a workaround,
    Po Lu> perhaps in the spirit of:

That works for me (once I remove the '&' from `val' in the make_vector
call) on Fedora 40 with a pgtk emacs.

An x11 emacs on the same system doesnʼt need a similar fix. I guess
this is the GTK folks removing 'legacy' stuff.

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Wed, 24 Jul 2024 12:42:29 +0200, Sébastien Gendre <seb@k-7.ch> said:
    Sébastien> After:

    Sébastien> * Evaluated this new `cl-defmethod'

    Sébastien> * Taking a screenshot

    Sébastien> * Executed (gui-get-selection 'CLIPBOARD 'TARGETS) from an org-mode
    Sébastien>   buffer

    Sébastien> I got the result:
    Sébastien> [image/png]

    Sébastien> And `yank-media' work mow on an org-mode buffer.


    Sébastien> Thank you very much. :)

Thank you for reporting and testing.

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed, 24 Jul 2024 17:29:54 +0800, Po Lu <luangruo@yahoo.com> said:
>
>     Po Lu> I would prefer to treat this as a bug in GTK by installing a workaround,
>     Po Lu> perhaps in the spirit of:
>
> That works for me (once I remove the '&' from `val' in the make_vector
> call) on Fedora 40 with a pgtk emacs.
>
> An x11 emacs on the same system doesnʼt need a similar fix. I guess
> this is the GTK folks removing 'legacy' stuff.
>
> Robert

Right.  Has anyone anything further to say before this is installed?

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Wed, 24 Jul 2024 20:12:30 +0800, Po Lu <luangruo@yahoo.com> said:

    Po Lu> Robert Pluim <rpluim@gmail.com> writes:
    >>>>>>> On Wed, 24 Jul 2024 17:29:54 +0800, Po Lu <luangruo@yahoo.com> said:
    >> 
    >> Po Lu> I would prefer to treat this as a bug in GTK by installing a workaround,
    >> Po Lu> perhaps in the spirit of:
    >> 
    >> That works for me (once I remove the '&' from `val' in the make_vector
    >> call) on Fedora 40 with a pgtk emacs.
    >> 
    >> An x11 emacs on the same system doesnʼt need a similar fix. I guess
    >> this is the GTK folks removing 'legacy' stuff.
    >> 
    >> Robert

    Po Lu> Right.  Has anyone anything further to say before this is installed?

Not me. I assume youʼre putting it in emacs-30?

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed, 24 Jul 2024 20:12:30 +0800, Po Lu <luangruo@yahoo.com> said:
>
>     Po Lu> Robert Pluim <rpluim@gmail.com> writes:
>     >>>>>>> On Wed, 24 Jul 2024 17:29:54 +0800, Po Lu <luangruo@yahoo.com> said:
>     >> 
>     >> Po Lu> I would prefer to treat this as a bug in GTK by installing a workaround,
>     >> Po Lu> perhaps in the spirit of:
>     >> 
>     >> That works for me (once I remove the '&' from `val' in the make_vector
>     >> call) on Fedora 40 with a pgtk emacs.
>     >> 
>     >> An x11 emacs on the same system doesnʼt need a similar fix. I guess
>     >> this is the GTK folks removing 'legacy' stuff.
>     >> 
>     >> Robert
>
>     Po Lu> Right.  Has anyone anything further to say before this is installed?
>
> Not me. I assume youʼre putting it in emacs-30?

Yes.

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Wed, 24 Jul 2024 22:11:30 +0800, Po Lu <luangruo@yahoo.com> said:

    Po Lu> Robert Pluim <rpluim@gmail.com> writes:
    >>>>>>> On Wed, 24 Jul 2024 20:12:30 +0800, Po Lu <luangruo@yahoo.com> said:
    >> 
    >> Po Lu> Robert Pluim <rpluim@gmail.com> writes:
    >> >>>>>>> On Wed, 24 Jul 2024 17:29:54 +0800, Po Lu <luangruo@yahoo.com> said:
    >> >> 
    >> >> Po Lu> I would prefer to treat this as a bug in GTK by installing a workaround,
    >> >> Po Lu> perhaps in the spirit of:
    >> >> 
    >> >> That works for me (once I remove the '&' from `val' in the make_vector
    >> >> call) on Fedora 40 with a pgtk emacs.
    >> >> 
    >> >> An x11 emacs on the same system doesnʼt need a similar fix. I guess
    >> >> this is the GTK folks removing 'legacy' stuff.
    >> >> 
    >> >> Robert
    >> 
    >> Po Lu> Right.  Has anyone anything further to say before this is installed?
    >> 
    >> Not me. I assume youʼre putting it in emacs-30?

    Po Lu> Yes.

I donʼt see this change on the emacs-30 branch, is anything more needed?

Thanks

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed, 24 Jul 2024 22:11:30 +0800, Po Lu <luangruo@yahoo.com> said:
>
>     Po Lu> Robert Pluim <rpluim@gmail.com> writes:
>     >>>>>>> On Wed, 24 Jul 2024 20:12:30 +0800, Po Lu <luangruo@yahoo.com> said:
>     >> 
>     >> Po Lu> Robert Pluim <rpluim@gmail.com> writes:
>     >> >>>>>>> On Wed, 24 Jul 2024 17:29:54 +0800, Po Lu <luangruo@yahoo.com> said:
>     >> >> 
>     >> >> Po Lu> I would prefer to treat this as a bug in GTK by installing a workaround,
>     >> >> Po Lu> perhaps in the spirit of:
>     >> >> 
>     >> >> That works for me (once I remove the '&' from `val' in the make_vector
>     >> >> call) on Fedora 40 with a pgtk emacs.
>     >> >> 
>     >> >> An x11 emacs on the same system doesnʼt need a similar fix. I guess
>     >> >> this is the GTK folks removing 'legacy' stuff.
>     >> >> 
>     >> >> Robert
>     >> 
>     >> Po Lu> Right.  Has anyone anything further to say before this is installed?
>     >> 
>     >> Not me. I assume youʼre putting it in emacs-30?
>
>     Po Lu> Yes.
>
> I donʼt see this change on the emacs-30 branch, is anything more needed?
>
> Thanks
>
> Robert

No, the patch was lost among the host of matters I had to attend to.
Eli, is this still OK for emacs-30?

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: Sébastien Gendre <seb@k-7.ch>,  Visuwesh
>  <visuweshm@gmail.com>,  Eli
>  Zaretskii <eliz@gnu.org>,  72254@debbugs.gnu.org
> Date: Tue, 20 Aug 2024 20:18:20 +0800
> 
> Robert Pluim <rpluim@gmail.com> writes:
> 
> >>>>>> On Wed, 24 Jul 2024 22:11:30 +0800, Po Lu <luangruo@yahoo.com> said:
> >
> >     Po Lu> Robert Pluim <rpluim@gmail.com> writes:
> >     >>>>>>> On Wed, 24 Jul 2024 20:12:30 +0800, Po Lu <luangruo@yahoo.com> said:
> >     >> 
> >     >> Po Lu> Robert Pluim <rpluim@gmail.com> writes:
> >     >> >>>>>>> On Wed, 24 Jul 2024 17:29:54 +0800, Po Lu <luangruo@yahoo.com> said:
> >     >> >> 
> >     >> >> Po Lu> I would prefer to treat this as a bug in GTK by installing a workaround,
> >     >> >> Po Lu> perhaps in the spirit of:
> >     >> >> 
> >     >> >> That works for me (once I remove the '&' from `val' in the make_vector
> >     >> >> call) on Fedora 40 with a pgtk emacs.
> >     >> >> 
> >     >> >> An x11 emacs on the same system doesnʼt need a similar fix. I guess
> >     >> >> this is the GTK folks removing 'legacy' stuff.
> >     >> >> 
> >     >> >> Robert
> >     >> 
> >     >> Po Lu> Right.  Has anyone anything further to say before this is installed?
> >     >> 
> >     >> Not me. I assume youʼre putting it in emacs-30?
> >
> >     Po Lu> Yes.
> >
> > I donʼt see this change on the emacs-30 branch, is anything more needed?
> >
> > Thanks
> >
> > Robert
> 
> No, the patch was lost among the host of matters I had to attend to.
> Eli, is this still OK for emacs-30?

It looks like the change will affect any selections from the
clipboard?  If so, it's a bit scary to install it so late.  Can we
change the patch such that it affects only media selections?

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 20 Aug 2024 16:15:42 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> 
    >> No, the patch was lost among the host of matters I had to attend to.
    >> Eli, is this still OK for emacs-30?

    Eli> It looks like the change will affect any selections from the
    Eli> clipboard?  If so, it's a bit scary to install it so late.  Can we
    Eli> change the patch such that it affects only media selections?

It only affects pgtk builds, and only when emacs requests the list of
supported formats for yanking, which only `yank-media' does.

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Po Lu <luangruo@yahoo.com>,  seb@k-7.ch,  visuweshm@gmail.com,
>   72254@debbugs.gnu.org
> Date: Tue, 20 Aug 2024 15:20:38 +0200
> 
> >>>>> On Tue, 20 Aug 2024 16:15:42 +0300, Eli Zaretskii <eliz@gnu.org> said:
> 
>     >> 
>     >> No, the patch was lost among the host of matters I had to attend to.
>     >> Eli, is this still OK for emacs-30?
> 
>     Eli> It looks like the change will affect any selections from the
>     Eli> clipboard?  If so, it's a bit scary to install it so late.  Can we
>     Eli> change the patch such that it affects only media selections?
> 
> It only affects pgtk builds, and only when emacs requests the list of
> supported formats for yanking, which only `yank-media' does.

How do you see that it affects only PGTK?

But if these two conditions are the only cases where this method will
be used, I guess we can install it on the emacs-39 branch after all.
Although the problem is hardly urgent.

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 20 Aug 2024 16:30:32 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: Po Lu <luangruo@yahoo.com>,  seb@k-7.ch,  visuweshm@gmail.com,
    >> 72254@debbugs.gnu.org
    >> Date: Tue, 20 Aug 2024 15:20:38 +0200
    >> 
    >> >>>>> On Tue, 20 Aug 2024 16:15:42 +0300, Eli Zaretskii <eliz@gnu.org> said:
    >> 
    >> >> 
    >> >> No, the patch was lost among the host of matters I had to attend to.
    >> >> Eli, is this still OK for emacs-30?
    >> 
    Eli> It looks like the change will affect any selections from the
    Eli> clipboard?  If so, it's a bit scary to install it so late.  Can we
    Eli> change the patch such that it affects only media selections?
    >> 
    >> It only affects pgtk builds, and only when emacs requests the list of
    >> supported formats for yanking, which only `yank-media' does.

    Eli> How do you see that it affects only PGTK?

The change is to `pgtk-get-selection-internal', which only exists in
pgtk builds.

    Eli> But if these two conditions are the only cases where this method will
    Eli> be used, I guess we can install it on the emacs-39 branch after all.
    Eli> Although the problem is hardly urgent.

Itʼs an annoying issue, since org-mode has gone to the trouble of
implementing support for `yank-media' it would be nice if it worked
everywhere (and some distributions have started shipping pgtk-emacs as
their default emacs)

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

> How do you see that it affects only PGTK?

Well, that's easy: for it only modifies pgtkselect.c.

> But if these two conditions are the only cases where this method will
> be used, I guess we can install it on the emacs-39 branch after all.

OK.

> Although the problem is hardly urgent.

I think we (implicitly or otherwise) promised the OP that this would be
addressed in Emacs 30.

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: Robert Pluim <rpluim@gmail.com>,  seb@k-7.ch,  visuweshm@gmail.com,
>   72254@debbugs.gnu.org
> Date: Tue, 20 Aug 2024 22:01:32 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > How do you see that it affects only PGTK?
> 
> Well, that's easy: for it only modifies pgtkselect.c.

I guess I looked at the wrong patch, then: it was for x-win.el.

> > But if these two conditions are the only cases where this method will
> > be used, I guess we can install it on the emacs-39 branch after all.
> 
> OK.
> 
> > Although the problem is hardly urgent.
> 
> I think we (implicitly or otherwise) promised the OP that this would be
> addressed in Emacs 30.

OK.

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Robert Pluim]

>>>>> On Tue, 20 Aug 2024 17:25:48 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Po Lu <luangruo@yahoo.com>
    >> Cc: Robert Pluim <rpluim@gmail.com>,  seb@k-7.ch,  visuweshm@gmail.com,
    >> 72254@debbugs.gnu.org
    >> Date: Tue, 20 Aug 2024 22:01:32 +0800
    >> 
    >> Eli Zaretskii <eliz@gnu.org> writes:
    >> 
    >> > How do you see that it affects only PGTK?
    >> 
    >> Well, that's easy: for it only modifies pgtkselect.c.

    Eli> I guess I looked at the wrong patch, then: it was for x-win.el.

That was my original debugging patch which showed that the reporter
was using pgtk, since it didnʼt do anything ☺️

Robert
-- 

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: Robert Pluim <rpluim@gmail.com>,  seb@k-7.ch,  visuweshm@gmail.com,
>>   72254@debbugs.gnu.org
>> Date: Tue, 20 Aug 2024 22:01:32 +0800
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > How do you see that it affects only PGTK?
>> 
>> Well, that's easy: for it only modifies pgtkselect.c.
>
> I guess I looked at the wrong patch, then: it was for x-win.el.
>
>> > But if these two conditions are the only cases where this method will
>> > be used, I guess we can install it on the emacs-39 branch after all.
>> 
>> OK.
>> 
>> > Although the problem is hardly urgent.
>> 
>> I think we (implicitly or otherwise) promised the OP that this would be
>> addressed in Emacs 30.
>
> OK.

I was preparing to install this patch when I noticed that commits for
the pretest had been created but that the pretest had yet to be
released.  Perhaps this should be postponed till Andrea puts the tarball
out, am I correct?

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: rpluim@gmail.com,  72254@debbugs.gnu.org,  seb@k-7.ch,  visuweshm@gmail.com
> Date: Wed, 21 Aug 2024 10:37:50 +0800
> 
> I was preparing to install this patch when I noticed that commits for
> the pretest had been created but that the pretest had yet to be
> released.  Perhaps this should be postponed till Andrea puts the tarball
> out, am I correct?

That's up to Andrea (CC'ed), it depends on where did he pause the
make-tarball procedure.

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Andrea Corallo]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: rpluim@gmail.com,  72254@debbugs.gnu.org,  seb@k-7.ch,  visuweshm@gmail.com
>> Date: Wed, 21 Aug 2024 10:37:50 +0800
>> 
>> I was preparing to install this patch when I noticed that commits for
>> the pretest had been created but that the pretest had yet to be
>> released.  Perhaps this should be postponed till Andrea puts the tarball
>> out, am I correct?
>
> That's up to Andrea (CC'ed), it depends on where did he pause the
> make-tarball procedure.

I suggest bugfixing on the branch happens indipendently of the release
process, I'm not bothered if commits are installed (worst case they will
not be included in the pretest).

  Andrea

bug#72254: 29.4; Cannot yank media when image come from Gnome-shell screenshot

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Andrea Corallo <acorallo@gnu.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Po Lu <luangruo@yahoo.com>
>>> Cc: rpluim@gmail.com,  72254@debbugs.gnu.org,  seb@k-7.ch,  visuweshm@gmail.com
>>> Date: Wed, 21 Aug 2024 10:37:50 +0800
>>> 
>>> I was preparing to install this patch when I noticed that commits for
>>> the pretest had been created but that the pretest had yet to be
>>> released.  Perhaps this should be postponed till Andrea puts the tarball
>>> out, am I correct?
>>
>> That's up to Andrea (CC'ed), it depends on where did he pause the
>> make-tarball procedure.
>
> I suggest bugfixing on the branch happens indipendently of the release
> process, I'm not bothered if commits are installed (worst case they will
> not be included in the pretest).
>
>   Andrea

Now installed (most belatedly, because I lost this e-mail).