From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Herbert J. Skuhra" Newsgroups: gmane.emacs.bugs Subject: bug#54154: Emacs commit ae963e80a79f5a9184daabfc8197f211a39b136d (sieve-manage) Date: Sun, 29 Sep 2024 14:15:47 +0200 Message-ID: <87jzeu8xl8.wl-herbert@gojira.at> References: <874jsngod2.fsf@tetzco.de> <83tu0nynla.fsf@gnu.org> <873586d7ii.fsf@tetzco.de> <834jsmpqf9.fsf@gnu.org> <87bkmua51z.fsf@tetzco.de> <83v8l2o212.fsf@gnu.org> <878rhut6aq.fsf@tetzco.de> <87ilgxs8vl.fsf@tetzco.de> <878rhts69s.fsf@tetzco.de> <87pmb5qiwv.fsf@tetzco.de> <87bkmpf87t.fsf@igel.home> <87o74696he.wl-herbert@gojira.at> <86seti4xks.fsf@gnu.org> <86plom4v3s.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20275"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/31.0 Mule/6.0 Cc: larsi@gnus.org, 54154@debbugs.gnu.org, emacs+bug@tetzco.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 29 14:18:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sussG-00059F-J9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Sep 2024 14:18:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1susrn-0000HU-KB; Sun, 29 Sep 2024 08:17:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1susri-0000H9-L8 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:17:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1susri-0006HK-BS for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:17:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=IwaM61AK7gePk6KfgnrAU3QmAbSnmmOEBeornEl39mc=; b=ejpvk+uJUUYcF6+qezxFasTbC267aLgztBYcowZ0mE9KNAw0baQ7NTKD4sK3/bYdvRDsaWHcnsiu/a9+0fiB01cUjEUGgztE267KuZvcjx8kr/tAGgfLfADHUAR32UpAOSjsaHHKS9VafTfuDEX3YiqLjW1NLfY+6LXug4P3ZEHS4uXR4d+Xr3NbuD4Y4xhJDAOTIdQyRYygzEji/My89/I9AvH+NdWCjn94xA365IDoQ/2kTw9qE5hkfS0J1NRsAPvbg4dFhAvnRzBSORYvUzfROF+BGKos8dhHB/l3zkFZ7RbmVccBDDOYn2tUewUlksVb0bk8NWVX6Ot+9tjFJA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sussD-00037b-IY for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 08:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Herbert J. Skuhra" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2024 12:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54154-submit@debbugs.gnu.org id=B54154.172761224511913 (code B ref 54154); Sun, 29 Sep 2024 12:18:01 +0000 Original-Received: (at 54154) by debbugs.gnu.org; 29 Sep 2024 12:17:25 +0000 Original-Received: from localhost ([127.0.0.1]:40212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1susrd-000364-94 for submit@debbugs.gnu.org; Sun, 29 Sep 2024 08:17:25 -0400 Original-Received: from mail.bsd4all.net ([94.130.200.20]:20737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1susrb-00035p-Gg for 54154@debbugs.gnu.org; Sun, 29 Sep 2024 08:17:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1727612206; bh=nUjBv4MBuwZ3TqeWh3t0EYFZ9B2ZioSG8uZG5VWs3KE=; h=Date:Message-ID:From:To:Cc:Subject:MIME-Version:Content-Type; b=nuuop65s5QpeaonImVAbFLy/Q9jxiYheP2rXmw7xV2BkUYBy6qasUe7iT2Cibey7M 5pJv/Ps+DVcqnE6fGFlOwjbZ8q1c4PV5gEnpQV5T8wOljT9eI0AOZ+4hx+Iie+r1EY UQlUx4YiXnWjMMK/hmQ4iW6ppeFEXxL5V/QsWh3E+1IfSfzqYdc5fesXjDewa5QYNH 5vpsdjlfUtMDD7cXBnehwDtmrr66j+z5QMTY5SH/b0VH6s/zvoMxjX5BSTFPF8A016 29PDQ+rTSUKziQmv8c8hSmEpQtf4HMpckGV6fPQj8fjBG+MkA3pzWJn5IJGSKbk5rT 5jLVJC9ZQYxeA== In-Reply-To: <86plom4v3s.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292633 Archived-At: On Sun, 29 Sep 2024 12:23:03 +0200, Eli Zaretskii wrote: > > > Cc: larsi@gnus.org, 54154@debbugs.gnu.org, emacs+bug@tetzco.de > > Date: Sun, 29 Sep 2024 12:29:39 +0300 > > From: Eli Zaretskii > > > > > - Run emacs -Q > > > - M-x sieve-manage > > > - Input IMAP server (e.g. imap.mailbox.org) > > > > > > Debugger entered--Lisp error: (wrong-type-argument stringp t) > > > sieve-manage--append-to-log("sieve-manage: Connecting to imap.mailbox.org..." "\n") > > > sieve-manage--message("Connecting to %s..." "imap.mailbox.org") > > > sieve-manage-open("imap.mailbox.org" nil) > > > sieve-open-server("imap.mailbox.org" nil) > > > sieve-manage("imap.mailbox.org") > > > funcall-interactively(sieve-manage "imap.mailbox.org") > > > command-execute(sieve-manage record) > > > execute-extended-command(nil "sieve-manage" "sieve-ma") > > > funcall-interactively(execute-extended-command nil "sieve-manage" "sieve-ma") > > > command-execute(execute-extended-command) > > > > > > On 2nd try it works! > > > > The fix was not merged to the-then master branch, so it is not in > > Emacs 30. Therefore, it is not a surprise you still see the problem: > > it was only fixed in Emacs 29. > > > > I lost the context long ago, so I hope Kai will suggest how to handle > > this. > > However, it's quite possible that the following band-aid should fix > this particular issue: > > diff --git a/lisp/net/sieve-manage.el b/lisp/net/sieve-manage.el > index 0faeb02..da2167c 100644 > --- a/lisp/net/sieve-manage.el > +++ b/lisp/net/sieve-manage.el > @@ -178,7 +178,8 @@ sieve-manage--append-to-log > (with-current-buffer > (get-buffer-create sieve-manage-log) > (set-buffer-multibyte nil) > - (buffer-disable-undo))) > + (buffer-disable-undo) > + (current-buffer))) > (goto-char (point-max)) > (apply #'insert args)))) Yes, this works. Thanks. As manage-sieve logs credentials maybe logging should be disabled by default and/or credentials shouldn't be logged when logging is enabled?