From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73781: [PATCH] Upgrade out-of-date dependencies with package-vc Date: Sun, 13 Oct 2024 01:23:38 +0200 Message-ID: <87jzechpmt.fsf@breatheoutbreathe.in> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37692"; mail-complaints-to="usenet@ciao.gmane.io" To: 73781@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 13 01:25:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szlTt-0009f6-Ga for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Oct 2024 01:25:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szlTf-0005mL-Nb; Sat, 12 Oct 2024 19:24:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szlTd-0005lv-7w for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 19:24:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szlTc-0003WT-Kb for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 19:24:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=nx74bcHEA+sI07TdC+Y0Mzj4cTQ32u1XJGUCvCHGNxs=; b=Q9XvcCqhl5EMmUYd1jMUV4CgRpHQgHjy5VCvHzL17ZeUyEg18ZYsX4RqbQ5kVUCkKHnpKZdx41DC60cN1SsvtmcH/JNymNbvh9a4T++NaRPC43ne89bXQRXrzTDZS46zIUAinP3epgdPrESAL30G4wGV9osamlUa8L9kk/GDQxzE4ZSf9BpaA62MifYzAnU+fnXNrdFqKUh1b5ROSUc7tyJ48yJeuLF4UQjZld0rdg3scuSsyenus9xQ0XsOhnuXjnCIJWtRAbCv5QMcbVsJ+p0eLy4WtJjmKirewV/rii52C9qPDNJb8KHmj2nx1W6tFgJ+HbGM5SIfKH5oi8/ehg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szlTq-0003eJ-0C for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 19:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Oct 2024 23:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172877545313876 (code B ref -1); Sat, 12 Oct 2024 23:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Oct 2024 23:24:13 +0000 Original-Received: from localhost ([127.0.0.1]:39224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szlT2-0003bj-O7 for submit@debbugs.gnu.org; Sat, 12 Oct 2024 19:24:13 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:34582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szlT0-0003bX-Eb for submit@debbugs.gnu.org; Sat, 12 Oct 2024 19:24:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szlSl-0005kR-Ay for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 19:23:55 -0400 Original-Received: from out-170.mta0.migadu.com ([91.218.175.170]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szlSj-0003Uf-5J for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 19:23:55 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1728775428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=nx74bcHEA+sI07TdC+Y0Mzj4cTQ32u1XJGUCvCHGNxs=; b=RdwPd09EFjElFRh99OtQVEpXb13ut+7Cg75o7+QZVRanK4vbe9fRDrVfh4L7NHjf6b0xgg N0TtG6wDBSZvdX/tp0qciLTAUOir20K4lQoIazZ/8/eKtgIEYPVVLZYSCculxz774vZaMH Eer/4l9STLNOptGDpLtcYG438L7YDRY= X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.170; envelope-from=joseph@breatheoutbreathe.in; helo=out-170.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293484 Archived-At: --=-=-= Content-Type: text/plain Tags: patch I noticed this bug when working on hyperdrive.el, which I had installed with package-vc-install-from-checkout. I updated the version of its transient.el dependency in the Package-Requires header and attempted to reinstall, but it did not attempt to update the dependency. I think the attached patch may not be the whole solution. I applied it, attempted package-vc-install-from-checkout again, and got this error: package--with-response-buffer-1: https://melpa.org/packages/transient-20241004.1739.tar: Not found Do we need to call package-refresh-contents at some point inside of package-vc-install-dependencies? Thank you! Joseph --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Upgrade-out-of-date-dependencies.patch >From fd05beab4903e3ba9f2a6866a00e924f8bcd5637 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Sun, 13 Oct 2024 01:10:02 +0200 Subject: [PATCH] Upgrade out-of-date dependencies * lisp/emacs-lisp/package-vc.el (package-vc-install-dependencies): Pass the specified package version when checking if a package is installed. --- lisp/emacs-lisp/package-vc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index e168096e153..58916637008 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -465,7 +465,7 @@ package-vc-install-dependencies "Attempt to find all dependencies for PKG." (cond ((assq (car pkg) to-install)) ;inhibit cycles - ((package-installed-p (car pkg))) + ((package-installed-p (car pkg) (cadr pkg))) ((let* ((pac package-archive-contents) (desc (cadr (assoc (car pkg) pac)))) (if desc -- 2.46.0 --=-=-=--