From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74090: 31.0.50; Problems with dabbrev-expand Date: Sat, 30 Nov 2024 23:30:21 +0100 Message-ID: <87jzcke4n6.fsf@gmx.net> References: <878qu6j0tx.fsf@gmx.net> <86zfml4uay.fsf@gnu.org> <87cyjgwq1a.fsf@gmx.net> <87ttbq7eie.fsf@mail.linkov.net> <87h67q4gv6.fsf@mail.linkov.net> <87wmgm6oe4.fsf@gmx.net> <877c8kboet.fsf@mail.linkov.net> <865xo47af4.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26738"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74090@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 30 23:31:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHVzk-0006qp-0o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Nov 2024 23:31:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHVzX-0005CK-0M; Sat, 30 Nov 2024 17:31:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHVzU-0005C4-9w for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 17:31:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHVzT-0000OZ-5V for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 17:31:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=SQLGth7adSNBh1FZoULpBZ5dDtjGq6heMI5ErHGonvI=; b=cVDcmx6q4zS6/OJdDLzAtMZinPdYO5Efe9B2MSl3Bx61KqJBFN+NTI03l1Fr9L5Xe6OXdflK7Lk94xCXpQcLP3wJmzjol09UeDwhM67AKr4iPz8utzFKfRVM+tZ0+Zd0gSwPqzTRXQoMnXwsZYFRFzh4dYBvLLkzVEEEkZDJX29B4b6J65heb4JyAys7iLogPw/1IQkkRXH47fCICTdtoglJU9UNBgk6IVrVt+RaDPgWsNWWsS0ALZhnAWa1EsEJ5vzS+uaSzMgu97UHF9oWunFh4c8wCNC62Pr2t/gw/LlmVwq8Qe5/n8Hst6BGwJfuqsV6y+FeRKa+0INJPN/GTA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHVzR-0005XA-RH for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 17:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2024 22:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74090 X-GNU-PR-Package: emacs Original-Received: via spool by 74090-submit@debbugs.gnu.org id=B74090.173300583221210 (code B ref 74090); Sat, 30 Nov 2024 22:31:01 +0000 Original-Received: (at 74090) by debbugs.gnu.org; 30 Nov 2024 22:30:32 +0000 Original-Received: from localhost ([127.0.0.1]:49434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHVyx-0005W2-J5 for submit@debbugs.gnu.org; Sat, 30 Nov 2024 17:30:31 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:54623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHVyv-0005Vj-95 for 74090@debbugs.gnu.org; Sat, 30 Nov 2024 17:30:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1733005822; x=1733610622; i=stephen.berman@gmx.net; bh=SQLGth7adSNBh1FZoULpBZ5dDtjGq6heMI5ErHGonvI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=nJboFoMyt7TPaVGw2c/PbpyCthsqXOGm4nu85DQutfc5GduKYavoBk27Ulwh5Kcu ObghHRxz19/FDG4IIDwDuJYStUm9pODxir3S0aiNdTqG94LKX9zm2fPifWTe5AlzA 6Z9Z/A9692MhzXIvgiS63xZLn4misKimFGQaM2EsGK8aVcvX2baM3PHZwHZODO0gd RbVZuLHDzFjghQvmHfZv/mq/LwTuHZqPADzD8LLPHbMfFMPJVuHRndw7q6wtgQAG9 KsWPIOJOk/xGkxnp063sLHACAiKU9Mb/HwfmrJpfZX2jKnMEt4LrkLkII9jny/3ib hvr4jVLFjPvEoFVvsA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([94.134.95.200]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MAfYm-1tO9o608fQ-00CPJ6; Sat, 30 Nov 2024 23:30:22 +0100 In-Reply-To: <865xo47af4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Nov 2024 22:07:27 +0200") X-Provags-ID: V03:K1:dxC9F5sBnLy3525O95z5yGpYmLNaPced7tYF4cuAvS93M9cWIMN mLBSAb1rBD+y/+Bh16CXCLe+K/0dUn1l0hUjETiStOpu8EwwrRS0PAgAJ6rLap+zBICtE6l k8IqQzApNe/J4LRRp7YjYHdN09xJ/6YJWF//uoCO69rOCm32shSTobZYNla5n67+Bh6ACgN uPnKn4GwDHpzRbp0pQTUQ== UI-OutboundReport: notjunk:1;M01:P0:U51Q0AHHceQ=;TWqr+orb5imfFDWwPhfUHvgspEi oyPMiG7GWg7hCwgG6Duln2F0gt4Vk08fo4wDvoLSXKG57t6gGZFSevgkiHuuqb9j1e7UQgMlf cwVGtclIgVSFGN4CXUszJt0DaSzBaowc6XC7GhxklPsklr5JgGJCvyHou0evFWyvCj8Kmc9l8 7+oaeitGku0B9At+nXwwbZaDFf4UUPF8N1xl+g5SxoawYAZB8EtefCMlw6HSA7RsWv+DiA9H/ QmT7d4MVxOwe2GBJOP4S/OfyaD1V86k1txqK6QRr0xg+ZtrxXEBtIuu060mAg1UXY9996kWWT OthM+o3ck0LzuWGJWNMspAvqaE60e0R0fDzFvXmji8EOPSjfrvB0LmU948RpH5PzxXr9Sp89N G4RVYsI218rnxqE3ce52b30xem5LM7ZellTzMkgYJ6RDdF9XPyxDCekKA6hyYO/9g088/byuw wLnx1dyD9C0l32vhBYZBC368ZQx4XwvaUYmdhFnY8PtFlPeLrCuHqb+ecNGdhlGhqEHlEmhLP wrmQYHsSGaFbh/Eg4Zswg5F8iF6neb0/S5+fOh86rVAYS8wQIuYJSM1cLJNjVK7g14NYxR0tr v3jK/IHRhubdMuCtTzd84Lc/6N97FXFQE+35QKZf0tu9QXBbwSBeOGan/60pKZ0NFoaHmoRkq XNhZ0jREsgWrm9e+QZiGxx/dfuc0b8proCRTpYRVSa2D1kTo79gVqcKIGzxnvdgV+7ILv3ge7 fviXD4D4BIbYKrInUGr0WbXedqQOyeeQDoWe+RSeL5eiR/Kvfp0iZUAbpPkz+2eVgL+0DLJ3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296213 Archived-At: On Sat, 30 Nov 2024 22:07:27 +0200 Eli Zaretskii wrote: >> From: Juri Linkov >> Cc: Eli Zaretskii , 74090@debbugs.gnu.org >> Date: Sat, 30 Nov 2024 19:51:38 +0200 >>=20 >> >>> 1. C-x b foo RET >> >>> 2. Type: abc SPC abd >> >>> 3. C-x b *scratch* RET >> >>> 4. Type: ab M-/ >> >>> 5. C-x k foo RET >> >>> 6. Type: SPC ab M-/ >> >> >> >> Sorry, I meant emacs-30, not emacs-29. >> > >> > Thanks, I can reproduce it. With the attached patch (against emacs-30) >> > I don't get the error; instead, at step 6 "ab" expands to "abc", which= I >> > suppose is what's expected, and then typing `M-/' again shows the >> > message "No further dynamic expansion for =E2=80=98ab=E2=80=99 found",= which also seems >> > as expected. And with the patch, all current dabbrev regression tests >> > pass with ert-run-tests-batch-and-exit. Does anyone see a problem with >> > the patch? >>=20 >> Thanks, I confirm it works now. Thanks! > Thanks for testing. Stephen, you have green light for installing this > on the emacs-30 branch. Thanks, done in commit bd8a6f70fb9. >> Would it be nice to have a new test that covers this case? > > Definitely. But it is less urgent than fixing the bug itself. I've added a test but I'm somewhat dissatisfied with it. I wanted to essentially reproduce the behavior I see with the patch, described above. However, after killing buffer "foo", the message about no further expansion is from a user-error in dabbrev-expand, and on hitting this in the test run, the test immediately finishes. So I used should-error with :type 'user-error and the test succeeds, but I cannot test for the final buffer content nor the message displayed by user-error. If anyone has an idea how to do that or otherwise improve the test, please chime in. Steve Berman