From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#74287: [PATCH] Rework history Isearch for Eshell Date: Wed, 11 Dec 2024 09:06:38 +0200 Organization: LINKOV.NET Message-ID: <87jzc6em0x.fsf@mail.linkov.net> References: <871pzjkhmm.fsf@pengjiz.com> <8c80ae91-476e-e665-43be-86d72fb57ed1@gmail.com> <86v7waz603.fsf@gmx.net> <6fdd8386-8915-e3a8-046a-b18750a7057d@gmail.com> <87v7vzgtuq.fsf@mail.linkov.net> <87jzcecnc9.fsf@pengjiz.com> <87h67icmu1.fsf@pengjiz.com> <87cyi159vo.fsf@pengjiz.com> <87msh4n29s.fsf@mail.linkov.net> <8734iwl5kw.fsf@pengjiz.com> <8734iwq8to.fsf@mail.linkov.net> <87frmv245n.fsf@pengjiz.com> <87zfl3mo4z.fsf@mail.linkov.net> <87y10navzm.fsf@pengjiz.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: Jim Porter , 74287@debbugs.gnu.org To: Pengji Zhang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 08:09:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLGqR-0001tz-Sh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 08:09:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLGqI-0002Yu-DF; Wed, 11 Dec 2024 02:09:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLGqF-0002Ym-DZ for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 02:09:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLGqF-0004jP-56 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 02:09:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=OtQ3VAYQk1Tz8iBjva8zREjATUjmolcnZ463lNvtOhg=; b=f873ln95rfQDIwvqC1fsx5CwqfsavR6ssni0D1NaBK4CHh8V6g4X+JoYjHzwhs0v4irT4hXHnhYhIuNcDhDWb+Nddnuzy564CA7fl/8VaejDbfYy2Fwmp5YHMZjK0Mx3finGykIRlNX6Lpp/97HdVj4UDLh8YaKesgxWpE/WSPSHE/H3ekqYHblS705gGQBhA1mtPgPrGH4kSPPQPSom9PKBIbEFFW+OeSfS17Eg0cIhZBSw7v8hHxT4Al3XbHRNoDpeE2Ps1FGX4hBlMIQBL9FD4ntxhTWA5fMFNXt+33J77/h8+W1LKMc1+BM3oQ35ZW2I42BUy3+f3hEN9pAZ+w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLGqD-0000o3-Nz for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 02:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 07:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74287 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74287-submit@debbugs.gnu.org id=B74287.17339009143051 (code B ref 74287); Wed, 11 Dec 2024 07:09:01 +0000 Original-Received: (at 74287) by debbugs.gnu.org; 11 Dec 2024 07:08:34 +0000 Original-Received: from localhost ([127.0.0.1]:60926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLGpm-0000n8-05 for submit@debbugs.gnu.org; Wed, 11 Dec 2024 02:08:34 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLGpi-0000ml-IG for 74287@debbugs.gnu.org; Wed, 11 Dec 2024 02:08:31 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 1959120003; Wed, 11 Dec 2024 07:08:22 +0000 (UTC) In-Reply-To: <87y10navzm.fsf@pengjiz.com> (Pengji Zhang's message of "Wed, 11 Dec 2024 08:45:01 +0800") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296805 Archived-At: >> Please also see the commit 98f8c5fb07dcb4e20b8ba6648bdabf5c0d3b5145 >> that fixed this in dired by using a buffer-local variable. Do you >> agree it's a good fix? Otherwise using a separate variable is also >> fine. > > My concern with using a local variable is that users may also set the > user option locally. That is perhaps not a problem for eshell or dired, > but for comint, e.g., I may set 'comint-history-isearch' to 'dwim' only > in 'M-x shell' via the mode hook. Indeed, this is a valid use case. > IMO, changing an internal variable feels a bit cleaner and safer than > manipulating a user option. So I would prefer using a separate variable. I agree that a separate variable is better. So now I added to comint.el 'comint--force-history-isearch' extracted from your Eshell patch. Thanks for the fix!