unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Pengji Zhang <me@pengjiz.com>
Cc: Jim Porter <jporterbugs@gmail.com>, 74287@debbugs.gnu.org
Subject: bug#74287: [PATCH] Rework history Isearch for Eshell
Date: Wed, 11 Dec 2024 09:06:38 +0200	[thread overview]
Message-ID: <87jzc6em0x.fsf@mail.linkov.net> (raw)
In-Reply-To: <87y10navzm.fsf@pengjiz.com> (Pengji Zhang's message of "Wed, 11 Dec 2024 08:45:01 +0800")

>> Please also see the commit 98f8c5fb07dcb4e20b8ba6648bdabf5c0d3b5145
>> that fixed this in dired by using a buffer-local variable. Do you
>> agree it's a good fix? Otherwise using a separate variable is also
>> fine.
>
> My concern with using a local variable is that users may also set the
> user option locally. That is perhaps not a problem for eshell or dired,
> but for comint, e.g., I may set 'comint-history-isearch' to 'dwim' only
> in 'M-x shell' via the mode hook.

Indeed, this is a valid use case.

> IMO, changing an internal variable feels a bit cleaner and safer than
> manipulating a user option. So I would prefer using a separate variable.

I agree that a separate variable is better.  So now I added to comint.el
'comint--force-history-isearch' extracted from your Eshell patch.

Thanks for the fix!





      reply	other threads:[~2024-12-11  7:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-10  1:22 bug#74287: [PATCH] Rework history Isearch for Eshell Pengji Zhang
2024-11-10 23:40 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-12  8:54   ` Pengji Zhang
2024-11-26  6:53 ` Jim Porter
2024-11-26  9:41   ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-26 17:00     ` Jim Porter
2024-11-27  5:37       ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-04 18:56       ` Juri Linkov
2024-12-05 12:43         ` Pengji Zhang
2024-12-05 12:53           ` Pengji Zhang
2024-12-09  4:34             ` Jim Porter
2024-12-09 12:16               ` Pengji Zhang
2024-12-09 13:35                 ` Pengji Zhang
2024-12-09 19:06                   ` Jim Porter
2024-12-09 18:23                 ` Juri Linkov
2024-12-10  0:55                   ` Pengji Zhang
2024-12-10  7:46                     ` Juri Linkov
2024-12-10 11:01                       ` Pengji Zhang
2024-12-10 17:41                         ` Juri Linkov
2024-12-11  0:45                           ` Pengji Zhang
2024-12-11  7:06                             ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzc6em0x.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=74287@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=me@pengjiz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).