* shell-script mode indentation skewed encountering "&"
@ 2005-06-28 21:59 Dan Jacobson
2005-06-30 16:47 ` Glenn Morris
[not found] ` <E1DnjNw-0006zx-9h@fencepost.gnu.org>
0 siblings, 2 replies; 3+ messages in thread
From: Dan Jacobson @ 2005-06-28 21:59 UTC (permalink / raw)
#!/bin/sh -xeu
#Here we critique shell-script mode indentation
(
: note how the parentheses are nicely indented
)
(
: note how the closing parentheses is skewed when we add &
)&
{
: same problem with {}
}&
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: shell-script mode indentation skewed encountering "&"
2005-06-28 21:59 shell-script mode indentation skewed encountering "&" Dan Jacobson
@ 2005-06-30 16:47 ` Glenn Morris
[not found] ` <E1DnjNw-0006zx-9h@fencepost.gnu.org>
1 sibling, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2005-06-30 16:47 UTC (permalink / raw)
Cc: bug-gnu-emacs
Dan Jacobson wrote:
> (
> : note how the parentheses are nicely indented
> )
> (
> : note how the closing parentheses is skewed when we add &
> )&
Thanks - I installed this fix in CVS:
*** sh-script.el 14 Jun 2005 23:56:03 -0000 1.157
--- sh-script.el 30 Jun 2005 16:45:04 -0000 1.158
***************
*** 2370,2376 ****
(goto-char where))
(prog1
(buffer-substring (point)
! (progn (skip-chars-forward "^ \t\n;")(point)))
(unless and-move
(goto-char start)))))
--- 2370,2376 ----
(goto-char where))
(prog1
(buffer-substring (point)
! (progn (skip-chars-forward "^ \t\n;&")(point)))
(unless and-move
(goto-char start)))))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: shell-script mode indentation skewed encountering "&"
[not found] ` <E1DnjNw-0006zx-9h@fencepost.gnu.org>
@ 2005-06-30 21:40 ` Dan Jacobson
0 siblings, 0 replies; 3+ messages in thread
From: Dan Jacobson @ 2005-06-30 21:40 UTC (permalink / raw)
rms> Shell mode indentation needs a full rewrite. Are you interested
rms> in doing it?
With a dwindling number of cells up there, I'm not your man.
All I can do is make remarks like "I am disturbed that "do" is
indented vs. "done", but I respect that that must be a preference,
customizable by sh-indent-for-do".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-06-30 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-28 21:59 shell-script mode indentation skewed encountering "&" Dan Jacobson
2005-06-30 16:47 ` Glenn Morris
[not found] ` <E1DnjNw-0006zx-9h@fencepost.gnu.org>
2005-06-30 21:40 ` Dan Jacobson
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).