From: Ryan Yeske <rcyeske@gmail.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Ryan Yeske <rcyeske@gmail.com>, 1233@emacsbugs.donarmstrong.com
Subject: bug#1233: rcirc fill-region bugfix
Date: Mon, 27 Oct 2008 20:06:36 -0700 [thread overview]
Message-ID: <87iqrdquyr.fsf@cut.hackery.lan> (raw)
In-Reply-To: <87fxmnrmrh.fsf@cyd.mit.edu> (Chong Yidong's message of "Thu, 23 Oct 2008 18:04:50 -0400")
Chong Yidong <cyd@stupidchicken.com> writes:
> Hi Ryan,
>
> Could you review this patch?
It looks good to me. Thanks for the patch, Jeff.
The way filling is handled in the CVS trunk has been reworked, and it
includes a fix along these lines already.
Ryan
> Jeff Makey <jeff@sdsc.edu> wrote:
>
>> When a message begins with a very long word (typically a URL), rcirc
>> in Emacs 22 inserts a useless newline like this:
>>
>> 08:10 <SaintNick>
>> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>> has this month's archives
>>
>> The patch below excludes the timestamp and nick from the beginning of
>> the filled region, which will cause such a line to be shown in this
>> more compact format:
>>
>> 08:10 <SaintNick> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>> has this month's archives
>
>
> --- rcirc.el.orig 2008-02-10 06:03:53 -0800
> +++ rcirc.el 2008-10-08 23:33:57 -0700
> @@ -1251,7 +1251,7 @@
> (rcirc-fill-column
> rcirc-fill-column)
> (t fill-column))))
> - (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
> + (fill-region text-start rcirc-prompt-start-marker 'left t)))))
>
> ;; set inserted text to be read-only
> (when rcirc-read-only-flag
next prev parent reply other threads:[~2008-10-28 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 22:04 bug#1233: rcirc fill-region bugfix Chong Yidong
2008-10-28 3:06 ` Ryan Yeske [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-23 15:10 Jeff Makey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqrdquyr.fsf@cut.hackery.lan \
--to=rcyeske@gmail.com \
--cc=1233@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).