From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#5148: Lossage in comint history Date: Mon, 07 Dec 2009 19:27:34 +0200 Organization: JURTA Message-ID: <87iqcjeq45.fsf@mail.jurta.org> Reply-To: Juri Linkov , 5148@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260213112 4119 80.91.229.12 (7 Dec 2009 19:11:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Dec 2009 19:11:52 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 07 20:11:45 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NHize-00063Z-Gc for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Dec 2009 20:11:45 +0100 Original-Received: from localhost ([127.0.0.1]:52772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHizc-0005ai-VB for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Dec 2009 14:11:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHhgP-0000Cg-8U for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:47:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHhgK-00009T-4E for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:47:36 -0500 Original-Received: from [199.232.76.173] (port=50309 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHhgI-00008Y-1D for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:47:30 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:56122) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NHhgH-0007Ky-4k for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:47:29 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB7HlP9L023420; Mon, 7 Dec 2009 09:47:26 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nB7He5al022641; Mon, 7 Dec 2009 09:40:05 -0800 Resent-Date: Mon, 7 Dec 2009 09:40:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 07 Dec 2009 17:40:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 5148 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.126020718122072 (code B ref -1); Mon, 07 Dec 2009 17:40:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 7 Dec 2009 17:33:01 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB7HWxEH022069 for ; Mon, 7 Dec 2009 09:33:00 -0800 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHhSE-0004DU-SC for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:32:58 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHhS9-00046g-BT for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:32:57 -0500 Original-Received: from [199.232.76.173] (port=60832 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHhS9-00046S-4r for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:32:53 -0500 Original-Received: from smtp-out3.starman.ee ([85.253.0.5]:46781 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHhS9-00063f-8j for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2009 12:32:53 -0500 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.97.43.cable.starman.ee [82.131.97.43]) by mx1.starman.ee (Postfix) with ESMTP id A0C823F429C for ; Mon, 7 Dec 2009 19:32:45 +0200 (EET) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 07 Dec 2009 12:47:36 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33368 Archived-At: Using M-x shell in Emacs causes lossage in .bash_history. I set HISTFILESIZE and HISTSIZE to large values in .bashrc to not truncate the history file but comint.el disregards my settings and truncates the history file used by bash. The following patch make `comint-input-ring-size' customizable. The type should be `integer' because this value is used by `make-ring' to create the history ring. The default value increased to 500 to be the same as the default value of HISTFILESIZE and HISTSIZE. Index: lisp/comint.el =================================================================== RCS file: /sources/emacs/emacs/lisp/comint.el,v retrieving revision 1.402 diff -c -r1.402 comint.el *** lisp/comint.el 1 Dec 2009 20:32:00 -0000 1.402 --- lisp/comint.el 7 Dec 2009 17:27:08 -0000 *************** *** 309,317 **** :type 'integer :group 'comint) ! ;; FIXME: this should be defcustom ! (defvar comint-input-ring-size 150 ! "Size of input history ring.") (defvar comint-input-ring-separator "\n" "Separator between commands in the history file.") --- 309,319 ---- :type 'integer :group 'comint) ! (defcustom comint-input-ring-size 500 ! "Size of input history ring." ! :type 'integer ! :group 'comint ! :version "23.2") (defvar comint-input-ring-separator "\n" "Separator between commands in the history file.") -- Juri Linkov http://www.jurta.org/emacs/