unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: martin rudalics <rudalics@gmx.at>
Cc: Christopher Schmidt <christopher@ch.ristopher.com>,
	11795@debbugs.gnu.org
Subject: bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed files
Date: Wed, 22 Aug 2012 06:44:58 +0200	[thread overview]
Message-ID: <87ipcbmt6d.fsf@web.de> (raw)
In-Reply-To: <4FF40A79.5000707@gmx.at> (martin rudalics's message of "Wed, 04 Jul 2012 11:18:49 +0200")

martin rudalics <rudalics@gmx.at> writes:

> >> The call to `dired-mark-remembered' should be wrapped in a
> >> `save-excursion', else it may move point to another position.
>
> Can someone explain why `dired-mark-remembered' cannot do:
>
> (defun dired-mark-remembered (alist)
>   "Mark all files remembered in ALIST.
> Each element of ALIST looks like (FILE . MARKERCHAR)."
>   (let (elt fil chr)
>     (save-excursion
>       (while alist
> 	(setq elt (car alist)
> 	      alist (cdr alist)
> 	      fil (car elt)
> 	      chr (cdr elt))
> 	(when (dired-goto-file fil)
> 	  (beginning-of-line)
> 	  (delete-char 1)
> 	  (insert chr))))))
>
> martin

I guess nobody can explain it because your version simply is better and
more correct.

So, it would be cool if the patch could be applied.


Thanks,

Michael.





  parent reply	other threads:[~2012-08-22  4:44 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 23:53 bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed files Michael Heerdegen
2012-06-27  0:57 ` Drew Adams
2012-06-27  1:27 ` Christopher Schmidt
2012-06-27 14:20   ` Drew Adams
2012-06-27 14:47     ` Christopher Schmidt
2012-06-27 14:59       ` Drew Adams
2012-06-27 17:39       ` Michael Heerdegen
2012-06-27 18:02         ` Christopher Schmidt
2012-06-27 21:05           ` Michael Heerdegen
2012-07-04  4:02             ` Michael Heerdegen
2012-07-04  9:18               ` martin rudalics
2012-07-04 12:29                 ` Stefan Monnier
2012-08-22  4:44                 ` Michael Heerdegen [this message]
2012-08-22  7:08                   ` martin rudalics
2012-08-29 15:19                     ` Christopher Schmidt
2012-08-29 16:15                       ` Michael Heerdegen
2012-08-29 17:22                         ` martin rudalics
2012-10-03  9:14                         ` martin rudalics
2012-10-04 23:52                           ` Michael Heerdegen
2012-10-05  7:05                             ` martin rudalics
2012-10-09  0:41                           ` Michael Heerdegen
2012-10-15 23:01                           ` Michael Heerdegen
2012-10-16  9:39                             ` martin rudalics
2012-10-17  9:37                             ` martin rudalics
2012-10-17  9:51                               ` Christopher Schmidt
2012-10-18  9:15                                 ` martin rudalics
2012-10-23  8:05     ` Juri Linkov
2012-10-24 13:31       ` Michael Heerdegen
2012-10-25  9:03         ` Juri Linkov
2012-10-27  9:18         ` Juri Linkov
2012-10-27 12:55           ` Michael Heerdegen
2012-10-27 14:38             ` Juri Linkov
2012-11-22  9:12               ` Juri Linkov
2012-11-22 15:28                 ` Stefan Monnier
2012-11-23  7:29                   ` Juri Linkov
2012-11-23  0:04                 ` Michael Heerdegen
2012-11-23  7:30                   ` Juri Linkov
2012-11-25  9:12                     ` Juri Linkov
2013-01-19  6:32                     ` Michael Heerdegen
2013-01-19 10:37                       ` Juri Linkov
2013-01-20  5:15                         ` Michael Heerdegen
2020-09-21 14:58 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipcbmt6d.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=11795@debbugs.gnu.org \
    --cc=christopher@ch.ristopher.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).