From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#2224: [PATCH] add-log.el: Modularize add-log-current-defun, new types supported Date: Sat, 01 Dec 2012 13:54:12 +0800 Message-ID: <87ip8mjp17.fsf@gnu.org> References: <87bptf5upl.fsf@jondo.cante.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354341299 7158 80.91.229.3 (1 Dec 2012 05:54:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Dec 2012 05:54:59 +0000 (UTC) Cc: 2224@debbugs.gnu.org, Lars Magne Ingebrigtsen , Jari Aalto To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 01 06:55:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Teg2e-00018J-9w for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Dec 2012 06:55:08 +0100 Original-Received: from localhost ([::1]:38576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Teg2S-0007qk-Tb for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Dec 2012 00:54:56 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Teg2Q-0007qX-Ld for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2012 00:54:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Teg2P-000261-Ki for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2012 00:54:54 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Teg2P-00025x-HL for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2012 00:54:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Teg4U-0005zj-Fz for bug-gnu-emacs@gnu.org; Sat, 01 Dec 2012 00:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Dec 2012 05:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 2224-submit@debbugs.gnu.org id=B2224.135434138922983 (code B ref 2224); Sat, 01 Dec 2012 05:57:02 +0000 Original-Received: (at 2224) by debbugs.gnu.org; 1 Dec 2012 05:56:29 +0000 Original-Received: from localhost ([127.0.0.1]:47819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Teg3x-0005ye-GD for submit@debbugs.gnu.org; Sat, 01 Dec 2012 00:56:29 -0500 Original-Received: from mail-pa0-f44.google.com ([209.85.220.44]:39388) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Teg3v-0005yW-Fa for 2224@debbugs.gnu.org; Sat, 01 Dec 2012 00:56:28 -0500 Original-Received: by mail-pa0-f44.google.com with SMTP id hz11so758677pad.3 for <2224@debbugs.gnu.org>; Fri, 30 Nov 2012 21:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=/x5UJRdBtxlaKDG86wpZjbR9DeNimosTpGjt80C6SCI=; b=IkPm4N1N7G5jra65TS2lb9UXkLo4G06o1EEvk7FfXvZpeFhcqip1Pgs5dWiVGz7es0 vzZ6X9+2WuvvbEkdyssIL58gs/EmHSKA7c1aB3rn6SRkUNjTjB76b0kaLjpZEBwhLpVd uHZamugtH6297j8Np4nvtGDI9rnzjQcE4orca5IRHEGDJGtRWCbe3Bue7WaCgIQn3fvu pQFAvEe6lRGe9Fhc6iS7530p/IWXWgVOxwNUzcbFaqAa/IiGloKSvbRhv5hwD4niePt8 U8e1BU3rf+9lqwQ9F3xtBrKefJx221kdD5jr2rhJSh8a18FGrIDG6Q9ZJSqnqrBR706b 64bQ== Original-Received: by 10.68.233.201 with SMTP id ty9mr12194009pbc.14.1354341257514; Fri, 30 Nov 2012 21:54:17 -0800 (PST) Original-Received: from ulysses (cm198.gamma83.maxonline.com.sg. [202.156.83.198]) by mx.google.com with ESMTPS id oi3sm4239129pbb.1.2012.11.30.21.54.14 (version=SSLv3 cipher=OTHER); Fri, 30 Nov 2012 21:54:16 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 11 Apr 2012 09:49:35 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67715 Archived-At: Stefan Monnier writes: > Having them be separate functions is indeed very good. But most of them > shouldn't be in add-log.el: they should be in their respective > major-mode instead. Done in trunk. Of the new (rather than refactored) add-log-current-defun functions which Jari wrote, the Makefile, Ruby, and Python ones are not applicable because those modes already define their own. The PHP one is not applicable since we still don't have php-mode in Emacs. I added Jari's functions for HTML and CSS mode.