From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christopher Schmidt Newsgroups: gmane.emacs.bugs Subject: bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] Date: Fri, 15 Feb 2013 18:44:24 +0000 (GMT) Message-ID: <87ip5tquwi@ch.ristopher.com> References: <9C9137560F644E759AD573BBBD8E59EF@us.oracle.com> <5EA47A0255F8494DB430B52D46876641@us.oracle.com> <65D921448B0644988BE6445A2EF3E021@us.oracle.com> <21FFB8EA85964411A9B790386C5DA3AD@us.oracle.com> <878v8zow44@ch.ristopher.com> <87k3sj6juj@ch.ristopher.com> <87mwxcx149@ch.ristopher.com> <87wqugmcu8@ch.ristopher.com> <87mwvbuus2@ch.ristopher.com> <87k3qeestt@ch.ristopher.com> <87ehgm7hmx@ch.ristopher.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360953944 13027 80.91.229.3 (15 Feb 2013 18:45:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Feb 2013 18:45:44 +0000 (UTC) To: 6799@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 15 19:46:02 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U6QIH-0008GB-Up for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2013 19:45:58 +0100 Original-Received: from localhost ([::1]:43671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QHy-00015e-9D for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Feb 2013 13:45:38 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QHr-00013M-Mz for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:45:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6QHf-0001Ss-0B for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:45:31 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QHe-0001Sd-RV for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:45:18 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U6QIM-00083c-90 for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Feb 2013 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.136095392730928 (code B ref -1); Fri, 15 Feb 2013 18:46:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Feb 2013 18:45:27 +0000 Original-Received: from localhost ([127.0.0.1]:57998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6QHm-00082k-BK for submit@debbugs.gnu.org; Fri, 15 Feb 2013 13:45:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54680) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6QHk-00082d-9h for submit@debbugs.gnu.org; Fri, 15 Feb 2013 13:45:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6QGz-000167-90 for submit@debbugs.gnu.org; Fri, 15 Feb 2013 13:44:40 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:52960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QGz-000161-57 for submit@debbugs.gnu.org; Fri, 15 Feb 2013 13:44:37 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QGt-0000kU-UU for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:44:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6QGq-00013P-Qi for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:44:31 -0500 Original-Received: from ristopher.com ([146.185.21.93]:56144 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6QGq-00012z-J8 for bug-gnu-emacs@gnu.org; Fri, 15 Feb 2013 13:44:28 -0500 Original-Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id E00E8213F3; Fri, 15 Feb 2013 18:44:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1360953864; bh=rCYXBwLjugaDzgK2U0zHyP4OT6dTaIk7wGeMGLpeTvY=; h=From:To:Subject:In-Reply-To:Message-ID:References:MIME-Version: Content-Type:Date; b=yyhOZJils8xKiEpv1M4iUZ6awHRJutN6wievOZZ8fBo2No8wFWsSI8oC7TQfjebOl 1KXMhnwvjwSkzHRBbIM+BWVSj7pumM2gWJUGCHhcO3doKDTdGQzXLjoyzGT6SDngly ngQNFVhOpCG08YC7lXfYUf5l3LBZoY2yaY43vqbg= In-Reply-To: (Stefan Monnier's message of "Fri, 15 Feb 2013 10:25:50 -0500") Mail-Followup-To: bug-gnu-emacs@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71332 Archived-At: Stefan Monnier writes: >> dired-hide-details-mode also hides full lines other than header and >> file/directory lines. This includes the informational line right >> after >> the header line. >> /my/directory: >> total used in directory 1M available 1.0G <-- >> drwx------ 2 me me 4.0K Feb 11 17:35 file > > Is that the only full line that it hides, or are there others? Each and every line that is not a file line and that dired-insert-set-properties is called upon. In dired it is only this informational line. In find-dired the footer is hidden as well. find finished at Fri Feb 15 20:00:00 > Thinking of how to "fix it right", I think we'd need to introduce > something like a point-adjustment-function which dired-next-line could > set, and would take a "direction" argument. So keyboard.c's > adjust_point_for_property would call this function after adjusting > point. But it seems difficult to introduce such a thing in > a robust way: > - We could have it as a variable, which gets cleared before running > the next command, but then dired-next-line should only set it when > called interactively (otherwise if the caller calls dired-next-line > within, say, a save-excursion, you'd get surprising side-effects). > - We could have it as a property on the `dired-next-line' symbol, but > then we get the reverse problem, that a wrapper command that just > calls dired-next-line and not much else would fail to get this part > of dired-next-line's behavior. > > Maybe a cleaner solution is to export keyboard.c's > adjust_point_for_property to Elisp so that dired-next-line can call > it explicitly (to replace your "(while (and (invisible-p (point))) ...)" > loop). Yes, that would be great. Christopher