From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#16398: 24.3.50; [PATCH] eww: Tiny fix to display bookmark list. Date: Wed, 08 Jan 2014 11:19:28 +0900 Message-ID: <87iotvb4gf.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389147679 28625 80.91.229.3 (8 Jan 2014 02:21:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jan 2014 02:21:19 +0000 (UTC) To: 16398@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 08 03:21:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0iln-0006Mn-Ff for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Jan 2014 03:21:23 +0100 Original-Received: from localhost ([::1]:44480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0iln-00059R-2A for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2014 21:21:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0ilb-00058J-DD for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 21:21:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0ilS-0003fh-VV for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 21:21:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0ilS-0003fZ-Ra for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 21:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0ilS-0005xr-Kr for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 21:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2014 02:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138914760822838 (code B ref -1); Wed, 08 Jan 2014 02:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Jan 2014 02:20:08 +0000 Original-Received: from localhost ([127.0.0.1]:41762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0ikZ-0005wH-83 for submit@debbugs.gnu.org; Tue, 07 Jan 2014 21:20:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55734) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0ikV-0005w6-C4 for submit@debbugs.gnu.org; Tue, 07 Jan 2014 21:20:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0ikM-0002op-NJ for submit@debbugs.gnu.org; Tue, 07 Jan 2014 21:20:03 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0ikM-0002og-Kb for submit@debbugs.gnu.org; Tue, 07 Jan 2014 21:19:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0ikE-0004d2-5B for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 21:19:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0ik5-0002kl-Mh for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 21:19:46 -0500 Original-Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]:39291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0ik5-0002kP-FB for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 21:19:37 -0500 Original-Received: by mail-pa0-f44.google.com with SMTP id fa1so1199884pad.31 for ; Tue, 07 Jan 2014 18:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=user-agent:from:to:subject:date:message-id:mime-version :content-type; bh=YtoN1lXIT9imjssrREhdJB47QEQ+q0+LhqO5HsOB2nk=; b=XCwjFsUOxqIOZuJ+y0Gmn9fzTXgqeM8DASmu4Osy5WlnpO0ZiZmYiLrd/pld4guGqf vKlOdXrh2BsrDpTBd05B0NuXTaCeq9Gp3tdUp+k2p1/m/zXyMLQvNu6YswqsVyx10XcO ULVPvn3ZwI2ZW3sLUKXA3meDB3PyWtpHVLNTpfR4Xc4PCuDlvVqQgy1AfKmUZA0ZvKWN XDjvUJS/EH4+M/dAkPm7OREpVKQ810UTYa45kUO0m9snDADOtfOe3EtZmPmfh1Es69Wf +xTQA0J3H79gZ42bOM5b+KJixKoxG2Ed++QuzcCtPjmla/2VKpepeUEdO45Ju03bnFwp 4FKw== X-Received: by 10.68.226.70 with SMTP id rq6mr123645353pbc.107.1389147575888; Tue, 07 Jan 2014 18:19:35 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id id1sm73738552pbc.11.2014.01.07.18.19.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 18:19:35 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83156 Archived-At: (I sent this mail before, but since the mail did not receive mailing list , I resend. Sorry if it is duplicated.) Altough current eww bookmark list shows "URL" and "Title", it is better that "Title" is left side and "URL" is right, in my opinion. And it makes possible to display full URL withought clip. This is the patch for it. Please review and install it to the official tree if appreciated. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-bookmark-prepare): Tiny fix to display bookmark list. --- lisp/net/eww.el | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 38726fd..a9f97bb 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1140,19 +1140,24 @@ Differences in #targets are ignored." (user-error "No bookmarks are defined")) (set-buffer (get-buffer-create "*eww bookmarks*")) (eww-bookmark-mode) - (let ((format "%-40s %s") - (inhibit-read-only t) - start url) + (let ((inhibit-read-only t) + (domain-length 0) + (title-length 0) + start url title format) (erase-buffer) - (setq header-line-format (concat " " (format format "URL" "Title"))) + (dolist (bookmark eww-bookmarks) + (setq start (point)) + (setq domain-length (max domain-length (length (plist-get bookmark :url)))) + (setq title-length (max title-length (length (plist-get bookmark :title))))) + (setq format (format "%%-%ds %%-%ds" title-length domain-length) + header-line-format + (concat " " (format format "Title" "URL"))) (dolist (bookmark eww-bookmarks) (setq start (point)) (setq url (plist-get bookmark :url)) - (when (> (length url) 40) - (setq url (substring url 0 40))) - (insert (format format url - (plist-get bookmark :title)) - "\n") + (setq title (plist-get bookmark :title)) + (insert (format format title url)) + (insert "\n") (put-text-property start (1+ start) 'eww-bookmark bookmark)) (goto-char (point-min)))) -- 1.8.3.1 Kenjiro