From: Ivan Shmakov <ivan@siamics.net>
To: 17300@debbugs.gnu.org
Subject: bug#17300: fails to build due to defsetf, cl-define-compiler-macro in cl-macs.el (structures)
Date: Sun, 20 Apr 2014 11:26:25 +0000 [thread overview]
Message-ID: <87ioq4gs2m.fsf@violet.siamics.net> (raw)
Package: emacs
As of 20eb3d6e5262 [1], Emacs fails to build from a clean
directory with the output like:
Loading /home/private/users/ivan/devel/emacs-2014-04-20-build/lisp/emacs-lisp/nadvice.el (source)...
Loading /home/private/users/ivan/devel/emacs-2014-04-20-build/lisp/minibuffer.el (source)...
Eager macro-expansion failure: (void-function defsetf)
Symbol's function definition is void: defsetf
make[1]: *** [bootstrap-emacs] Error 1
make[1]: Leaving directory `/home/private/users/ivan/devel/emacs-2014-04-20-build/src'
Apparently, the “defstruct introspection” commit [2] is to
blame, as it introduced to cl-macs.el:
• the use of the ‘defsetf’ macro, defined in cl.el (not
currently required by cl-macs.el, and possibly leading to a
circular dependency);
• two invocations of the ‘cl-define-compiler-macro’ in the
“Structures.” section /prior/ to its definition in “Compiler
macros.” later in the same file.
The first issue could be solved by simply replacing defsetf by
gv-define-simple-setter. The solution for the second is to move
these two invocations below the definition of the macro.
[1] http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/vc/ediff-diff.el?h=emacs-24&id=20eb3d6e5262a31147b42a9733010ce397fdc3d8
[2] http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/vc/ediff-diff.el?h=emacs-24&id=49b8b4c4a07e9e3d160367cc52d4ef4fb7f3fa22
PS. And since when using periods in ‘;;; ’-headings within the code
became a convention, BTW?
--
FSF associate member #7257
next reply other threads:[~2014-04-20 11:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 11:26 Ivan Shmakov [this message]
2014-04-20 11:36 ` bug#17300: fails to build due to defsetf, cl-define-compiler-macro in cl-macs.el (structures) Eli Zaretskii
2014-04-20 12:28 ` Daimrod
2014-04-20 13:35 ` Ivan Shmakov
2014-04-20 13:52 ` Eli Zaretskii
2014-04-20 16:37 ` Ivan Shmakov
2014-04-20 16:46 ` Eli Zaretskii
2014-04-20 17:32 ` Ivan Shmakov
2014-04-20 18:53 ` Eli Zaretskii
2014-04-20 21:58 ` Stefan Monnier
2014-04-20 14:46 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioq4gs2m.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=17300@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).