From: Juri Linkov <juri@jurta.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: Tu Do <tuhdo1710@gmail.com>, 17218-done@debbugs.gnu.org
Subject: bug#17218: 24.3; Dired does not insert subdirs when used with switch "--group-directories-first"
Date: Sat, 03 May 2014 12:23:54 +0300 [thread overview]
Message-ID: <87iopn43md.fsf@mail.jurta.org> (raw)
In-Reply-To: <871twjjhrx.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 27 Apr 2014 11:30:58 +0300")
Version: 24.5
>>> I found out the problem in the function "dired-insert-old-subdirs"
>>> at line 1367 in dired.el.
>>
>> There is a similar problem in `dired-sort-R-check' and
>> `dired-build-subdir-alist'.
>>
>> [There probably should be a function that checks for a given switch,
>> and does not just use `string-match-p' in such a simple way.
>> (At least it should respect case etc.)]
>
> Below is the implementation of such a function:
Installed to trunk since this is not a regression.
next prev parent reply other threads:[~2014-05-03 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 14:12 bug#17218: 24.3; Dired does not insert subdirs when used with switch "--group-directories-first" Tu Do
2014-04-07 16:00 ` Drew Adams
2014-04-08 8:45 ` Juri Linkov
2014-04-27 8:30 ` Juri Linkov
2014-05-03 9:23 ` Juri Linkov [this message]
2014-05-07 19:50 ` Glenn Morris
2014-05-07 20:14 ` Juri Linkov
2014-05-08 18:15 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iopn43md.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=17218-done@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=tuhdo1710@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).