From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daimrod Newsgroups: gmane.emacs.bugs Subject: bug#17769: 24.4.50; [PATCH] rcirc-omit-mode: `recenter'ing a window that does not display current-buffer. Date: Fri, 13 Jun 2014 15:59:33 +0900 Message-ID: <87ioo5cn1m.fsf@tanger.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1402642819 3534 80.91.229.3 (13 Jun 2014 07:00:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Jun 2014 07:00:19 +0000 (UTC) To: 17769@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 13 09:00:12 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WvLT9-00028p-1X for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 09:00:11 +0200 Original-Received: from localhost ([::1]:57117 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLT8-0006EP-NZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 03:00:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLT4-0006Cb-DJ for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 03:00:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvLT3-0007Ru-Dl for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 03:00:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLT3-0007Qf-Ao for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 03:00:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WvLT2-0004KR-Gj for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 03:00:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jun 2014 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 17769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.140264279416584 (code B ref -1); Fri, 13 Jun 2014 07:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jun 2014 06:59:54 +0000 Original-Received: from localhost ([127.0.0.1]:46116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvLSr-0004JP-F4 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45326) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvLSo-0004J4-F3 for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvLSi-0007Ij-3j for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:45 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:51956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSi-0007Ie-1A for submit@debbugs.gnu.org; Fri, 13 Jun 2014 02:59:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSg-0005lk-UK for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvLSe-0007HK-UT for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:42 -0400 Original-Received: from mail-pb0-x235.google.com ([2607:f8b0:400e:c01::235]:61766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvLSe-0007H4-NO for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 02:59:40 -0400 Original-Received: by mail-pb0-f53.google.com with SMTP id uo5so1611569pbc.40 for ; Thu, 12 Jun 2014 23:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=34semi+MYdnDIWWvXA5s+ypPKFP1sIi3zeX0c3AbzLY=; b=BJu83IIx9kD3inw4Q32V8GxQONR0rvDPG/cb3K8IGVmwTTC0OBKj1qw5WxFx4a9t12 dpnYUpWtjQPtoW67gS+1apk7fIrCuQI0gbKCy1fQ804T1xmyDNZqMWKeC7YEe7b7Kst4 AlFp/Lo0fb5fZkRTrWCjkm1xz31PU8obtFvLqOEa83nwi/wXV9aZbSKcLw18ncj4Gpiq 8lywzXwjhzZS1/fan0xzZMn79UaSPMQvO2oqMoHwvCDjRP+6w/r0zSscIiFhVEblhM7h mpKBUh14xfdqvOOu7nB4tGM3XYOnS5V0OANYMQA7Uu1z8nqmMsrskvNRPPM0WZfGa1ZW SUBw== X-Received: by 10.66.226.172 with SMTP id rt12mr924349pac.101.1402642779667; Thu, 12 Jun 2014 23:59:39 -0700 (PDT) Original-Received: from localhost ([2001:2f8:200:1:e206:e6ff:fecb:5a]) by mx.google.com with ESMTPSA id uj2sm16777668pab.14.2014.06.12.23.59.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jun 2014 23:59:38 -0700 (PDT) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90309 Archived-At: --=-=-= Content-Type: text/plain Hi, The attached patch prevents `rcirc-omit-mode' to call `recenter' when `window-buffer' isn't the same as `current-buffer'. If `rcirc-omit-mode' is enabled by the user interactively (e.g. with C-c C-o) then it will do the right thing. If `rcirc-omit-mode' was called from elisp (e.g. from a hook), then we don't need to `recenter' the buffer, because it will be done the next time the user switch to the buffer with `rcirc-next-active-buffer'. I'm not an RCIRC expert, but I don't think anything else is required. WDYT? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-net-rcirc.el-rcirc-omit-mode-Do-not-recenter-if.patch >From 7bb493830bb0aaebeab69851ed044a5562875641 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= Date: Fri, 13 Jun 2014 14:12:52 +0900 Subject: [PATCH] * lisp/net/rcirc.el (rcirc-omit-mode): Do not `recenter' if the `current-buffer' isn't the buffer displayed by the selected window. --- lisp/net/rcirc.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 41cc002..7bd7e93 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1903,7 +1903,8 @@ Uninteresting lines are those whose responses are listed in (message "Rcirc-Omit mode enabled")) (remove-from-invisibility-spec '(rcirc-omit . nil)) (message "Rcirc-Omit mode disabled")) - (recenter (when (> (point) rcirc-prompt-start-marker) -1))) + (when (eq (current-buffer) (window-buffer)) + (recenter (when (> (point) rcirc-prompt-start-marker) -1)))) (defun rcirc-switch-to-server-buffer () "Switch to the server buffer associated with current channel buffer." -- 1.8.0.2722.gc0242e5 --=-=-= Content-Type: text/plain -- Daimrod/Greg --=-=-=--