From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17809: 24.4.50; Completions display Date: Mon, 06 Oct 2014 01:02:45 +0300 Organization: JURTA Message-ID: <87iojyfa4a.fsf@mail.jurta.org> References: <87d2e5js1o.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1412546666 27192 80.91.229.3 (5 Oct 2014 22:04:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Oct 2014 22:04:26 +0000 (UTC) To: 17809@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 06 00:04:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xatuc-0007ZN-8j for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Oct 2014 00:04:18 +0200 Original-Received: from localhost ([::1]:48816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xatub-00009Z-Sx for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Oct 2014 18:04:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XatuS-00009R-HS for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 18:04:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XatuM-0001La-DK for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 18:04:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XatuM-0001LW-AO for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 18:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XatuL-000155-Rn for bug-gnu-emacs@gnu.org; Sun, 05 Oct 2014 18:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Oct 2014 22:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17809-submit@debbugs.gnu.org id=B17809.14125465984101 (code B ref 17809); Sun, 05 Oct 2014 22:04:01 +0000 Original-Received: (at 17809) by debbugs.gnu.org; 5 Oct 2014 22:03:18 +0000 Original-Received: from localhost ([127.0.0.1]:35022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xattd-000144-T6 for submit@debbugs.gnu.org; Sun, 05 Oct 2014 18:03:18 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.222.226]:35438 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xattb-00013v-T4 for 17809@debbugs.gnu.org; Sun, 05 Oct 2014 18:03:16 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 3A47930ED51577 for <17809@debbugs.gnu.org>; Sun, 5 Oct 2014 15:03:15 -0700 (PDT) In-Reply-To: <87d2e5js1o.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 19 Jun 2014 09:57:47 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94188 Archived-At: > - display-buffer-below-selected for completion-at-point > that could work like displaying *Marking Files* in Dired > to display *Completions* near the point of completion > in the current buffer. I noticed that at-bottom is used instead of better below-selected for some completion-at-point commands. For example, completing a color in the Customization UI displays the *Completions* at the bottom even when there is no active minibuffer. Since completion-at-point commands set the value of `this-command' I wonder wouldn't it be right to check its value? === modified file 'lisp/minibuffer.el' --- lisp/minibuffer.el 2014-07-08 19:15:28 +0000 +++ lisp/minibuffer.el 2014-10-05 21:59:09 +0000 @@ -1811,7 +1811,7 @@ (defun minibuffer-completion-help (&opti ;; Use `display-buffer-below-selected' for inline completions, ;; but not in the minibuffer (e.g. in `eval-expression') ;; for which `display-buffer-at-bottom' is used. - ,(if (and completion-in-region-mode-predicate + ,(if (and (eq this-command 'completion-at-point) (not (minibuffer-selected-window))) 'display-buffer-below-selected 'display-buffer-at-bottom))